Skip to content

Guard against version drift in test cassettes #12

Description

@pi-sigma

docker-compose.yaml pins open-klant to 2.17.1, but nothing enforces it:

  • The tag is ${OPEN_KLANT_IMAGE_TAG:-2.17.1}, so an exported env var wins.
  • tests/helpers.py runs docker compose without an explicit env=, so it inherits whatever is in the caller's shell, including on pytest --with-openklant-service, which bypasses regenerate_vcr_fixtures.sh entirely.
  • No test fails if cassettes are recorded at a version other than the pin.

Re-recording part of the suite therefore leaves it green while it asserts the behaviour of two different servers. This has already happened: before #10 the cassettes mixed API versions 0.1.2, 0.4.1, 0.5.0 and 0.8.0.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions