🏷️ [#614] update types

Author: TimdeBeer1

pyproject.toml

@@ -115,11 +115,6 @@ ignore = [
     "SIM117",
 ]
 
-
-[tool.ruff.lint.flake8-tidy-imports.banned-api.logging]
-msg = "Use `structlog.stdlib.get_logger(__name__)` instead."
-
-
 [tool.ruff.lint.isort]
 combine-as-imports = true
 force-wrap-aliases = false

src/openklant/utils/notifications.py

@@ -1,7 +1,6 @@
 from typing import Dict, List, Union
 
 from django.db import models, transaction
-
 from notifications_api_common.models import NotificationTypes
 from notifications_api_common.tasks import create_failed_notification, send_notification
 from notifications_api_common.viewsets import NotificationCreateMixin, NotificationMixin
@@ -18,7 +17,7 @@ def notify(
         self,
         status_code: int,
         data: Union[List, Dict],
-        instance: models.Model = None,
+        instance: models.Model | None = None,
         **kwargs,
     ) -> None:
         super().notify(status_code, data, instance)
@@ -30,7 +29,7 @@ def _message(self, data, instance=None):
 
             for notif in notifications:
                 # build the content of the notification
-                message = self.construct_message(
+                message = self.construct_message(  # type: ignore[reportAttributeAccessIssue]
                     notif,
                     instance=instance,
                     kanaal=config["notifications_kanaal"],
@@ -41,7 +40,7 @@ def _message(self, data, instance=None):
                 pk = create_failed_notification(message, NotificationTypes.notification)
 
                 transaction.on_commit(
-                    lambda msg=message, notification_id=pk: send_notification.delay(
+                    lambda msg=message, notification_id=pk: send_notification.delay(  # type: ignore[reportCallIssue]
                         msg, notification_id
                     )
                 )

src/openklant/utils/serializers.py

@@ -2,9 +2,8 @@
 
 from django.db.models import Model
 from django.utils.module_loading import import_string
-
 from rest_framework.serializers import Serializer
-from rest_framework_nested.serializers import NestedHyperlinkedRelatedField
+from rest_framework_nested.relations import NestedHyperlinkedRelatedField
 
 
 # TODO should be moved to vng-api-common once merged/reviewed
@@ -47,7 +46,7 @@ def to_representation(self, value):
                 serializer.parent = self
 
         if self.default_serializer_kwargs.get("many", False):
-            value = value.all()
+            value = value.all()  # type: ignore[reportAttributeAccessIssue]
 
         return serializer.to_representation(value)
 

src/openklant/utils/validators.py

@@ -1,9 +1,10 @@
+import re
+
 from django.core.exceptions import ValidationError
 from django.core.validators import RegexValidator
 from django.utils.deconstruct import deconstructible
 from django.utils.encoding import force_str
 from django.utils.translation import gettext_lazy as _
-
 from localflavor.generic.countries.iso_3166 import ISO_3166_1_ALPHA2_COUNTRY_CODES
 
 
@@ -28,7 +29,7 @@ def validate_country(value: str) -> None:
         )
 
 
-def validate_charfield_entry(value, allow_apostrophe=False):
+def validate_charfield_entry(value: str, allow_apostrophe=False):
     """
     Validates a charfield entry according with Belastingdienst requirements.
 
@@ -57,6 +58,8 @@ def validate_charfield_entry(value, allow_apostrophe=False):
 
 @deconstructible
 class RegexWithDisallowedPrefixesValidator(RegexValidator):
+    regex: re.Pattern[str]
+
     def __init__(self, *args, **kwargs):
         self.disallowed_prefixes = kwargs.pop("disallowed_prefixes")
         self.message_disallowed_prefix = kwargs.pop("message_disallowed_prefix")
@@ -99,7 +102,7 @@ def __call__(self, value):
         """
         Validates that the input matches the regular expression.
         """
-        if not self.regex.search(force_str(value)):
+        if not self.regex.search(force_str(value)):  # type: ignore[reportAttributeAccessIssue]
             message = "{0}: {1}".format(self.message, force_str(value))
             raise ValidationError(message, code=self.code)
 
@@ -115,7 +118,7 @@ def __call__(self, value):
 )
 
 validate_no_space = CustomRegexValidator(
-    regex="^[\S]+$", message=_("Geen spaties toegestaan")
+    regex=r"^[\S]+$", message=_("Geen spaties toegestaan")
 )
 
 validate_bag_id = CustomRegexValidator(