refactor(carts): fail-closed visibility gate (anything not 'public' is owner-only)

mayur-tolexo · mayur-tolexo · commit 5b9a2ea8a8e8 · 2026-05-25T12:27:26.000+05:30
diff --git a/internal/carts/service.go b/internal/carts/service.go
@@ -112,7 +112,8 @@ func (s *Service) GetPublicCart(ctx context.Context, slug string, viewerUserID i
 	}
 	// Private carts are visible only to their owner; everyone else gets a
 	// not-found (same as a nonexistent cart — no "this is private" leak).
-	if cart.Visibility == "private" && viewerUserID != cart.UserID {
+	// Fail closed: anything not explicitly "public" is treated as owner-only.
+	if cart.Visibility != "public" && viewerUserID != cart.UserID {
 		return sqlcgen.Cart{}, nil, sqlcgen.User{}, ErrNotFound
 	}
 	items, err := s.q.ListCartItems(ctx, cart.ID)

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,8 @@ func (s *Service) GetPublicCart(ctx context.Context, slug string, viewerUserID i`
`112`	`112`	`}`
`113`	`113`	`// Private carts are visible only to their owner; everyone else gets a`
`114`	`114`	`// not-found (same as a nonexistent cart — no "this is private" leak).`
`115`		`- if cart.Visibility == "private" && viewerUserID != cart.UserID {`
	`115`	`+ // Fail closed: anything not explicitly "public" is treated as owner-only.`
	`116`	`+ if cart.Visibility != "public" && viewerUserID != cart.UserID {`
`116`	`117`	`return sqlcgen.Cart{}, nil, sqlcgen.User{}, ErrNotFound`
`117`	`118`	`}`
`118`	`119`	`items, err := s.q.ListCartItems(ctx, cart.ID)`