Skip to content

Commit dc8fb8f

Browse files
authored
Remove leftover test cases from WorkerTest after SecurityManager was removed (bazel-contrib#1721)
WorkerTest was failing after bazel-contrib#1719
1 parent 818f015 commit dc8fb8f

File tree

1 file changed

+0
-55
lines changed

1 file changed

+0
-55
lines changed

src/java/io/bazel/rulesscala/worker/WorkerTest.java

-55
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import java.nio.file.Path;
1313
import java.util.concurrent.atomic.AtomicInteger;
1414
import org.junit.AfterClass;
15-
import org.junit.Assert;
1615
import org.junit.Test;
1716
import org.junit.runner.RunWith;
1817
import org.junit.runners.JUnit4;
@@ -22,60 +21,6 @@
2221
@RunWith(JUnit4.class)
2322
public class WorkerTest {
2423

25-
@Test
26-
public void testEphemeralWorkerSystemExit() throws Exception {
27-
28-
// An ephemeral worker behaves like a regular main method,
29-
// so we expect the worker to system exit normally
30-
31-
Worker.Interface worker =
32-
new Worker.Interface() {
33-
@Override
34-
public void work(String[] args) {
35-
System.exit(99);
36-
}
37-
};
38-
39-
int code =
40-
assertThrows(Worker.ExitTrapped.class, () -> Worker.workerMain(new String[] {}, worker))
41-
.code;
42-
43-
assert (code == 99);
44-
}
45-
46-
@Test
47-
public void testPersistentWorkerSystemExit() throws Exception {
48-
// We're going to spin up a persistent worker and run a single
49-
// work request. We expect System.exit calls to impact the
50-
// worker request lifecycle without exiting the overall worker
51-
// process.
52-
53-
try (PersistentWorkerHelper helper = new PersistentWorkerHelper(); ) {
54-
WorkerProtocol.WorkRequest.newBuilder().build().writeDelimitedTo(helper.requestOut);
55-
56-
Worker.Interface worker =
57-
new Worker.Interface() {
58-
@Override
59-
public void work(String[] args) {
60-
// we should see this print statement
61-
System.out.println("before exit");
62-
System.exit(100);
63-
// we should not see this print statement
64-
System.out.println("after exit");
65-
}
66-
};
67-
68-
helper.runWorker(worker);
69-
70-
WorkerProtocol.WorkResponse response =
71-
WorkerProtocol.WorkResponse.parseDelimitedFrom(helper.responseIn);
72-
73-
assert (response.getOutput().contains("before"));
74-
assert (response.getExitCode() == 100);
75-
assert (!response.getOutput().contains("after"));
76-
}
77-
}
78-
7924
@Test
8025
public void testPersistentWorkerNoStdin() throws Exception {
8126
try (PersistentWorkerHelper helper = new PersistentWorkerHelper(); ) {

0 commit comments

Comments
 (0)