Fix Songbird and Coston bootstrap issues

Author: mboben

avalanchego/network/peer/peer.go

@@ -541,7 +541,7 @@ func (p *peer) writeMessages() {
 
 	myVersion := p.VersionCompatibility.Version()
 	legacyApplication := &version.Application{
-		Name:  version.LegacyAppName,
+		Name:  version.GetApplicationPrefix(),
 		Major: myVersion.Major,
 		Minor: myVersion.Minor,
 		Patch: myVersion.Patch,

avalanchego/version/application.go

@@ -9,8 +9,6 @@ import (
 	"sync"
 )
 
-const LegacyAppName = "avalanche"
-
 var (
 	errDifferentMajor = errors.New("different major version")
 

avalanchego/version/application_test.go

@@ -14,7 +14,7 @@ func TestNewDefaultApplication(t *testing.T) {
 	require := require.New(t)
 
 	v := &Application{
-		Name:  LegacyAppName,
+		Name:  GetApplicationPrefix(),
 		Major: 1,
 		Minor: 2,
 		Patch: 3,

avalanchego/version/compatibility_test.go

@@ -47,7 +47,7 @@ func TestCompatibility(t *testing.T) {
 	}{
 		{
 			peer: &Application{
-				Name:  LegacyAppName,
+				Name:  GetApplicationPrefix(),
 				Major: 1,
 				Minor: 5,
 				Patch: 0,

avalanchego/version/parser.go

@@ -36,7 +36,7 @@ func Parse(s string) (*Semantic, error) {
 
 // TODO: Remove after v1.11.x is activated
 func ParseLegacyApplication(s string) (*Application, error) {
-	prefix := LegacyAppName + "/"
+	prefix := GetApplicationPrefix() + "/"
 	if !strings.HasPrefix(s, prefix) {
 		return nil, fmt.Errorf("%w: %q", errMissingApplicationPrefix, s)
 	}

avalanchego/vms/platformvm/txs/executor/staker_tx_verification_helpers.go

@@ -115,6 +115,10 @@ func GetNextStakerChangeTime(state state.Chain) (time.Time, error) {
 	case hasPendingStaker:
 		return pendingStakerIterator.Value().NextTime, nil
 	default:
+		// Due to no initial stakers in genesis for Songbird networks
+		if state.GetNetworkID() == constants.SongbirdID || state.GetNetworkID() == constants.CostonID || state.GetNetworkID() == constants.LocalID {
+			return songbirdLatestStakingTime, nil
+		}
 		return time.Time{}, database.ErrNotFound
 	}
 }

avalanchego/vms/proposervm/vm.go

@@ -760,8 +760,12 @@ func (vm *VM) getForkHeight() (uint64, error) {
 		switch vm.ctx.NetworkID {
 		case constants.MainnetID:
 			return 805732, nil // https://subnets.avax.network/p-chain/block/805732
-		default:
-			return 1, nil // Flare and Songbird started after Apricot Phase 4
+		case constants.SongbirdID:
+			return 9, nil
+		case constants.CostonID:
+			return 6, nil
+		case constants.FlareID, constants.CostwoID:
+			return 1, nil
 		}
 	case mainnetXChainID:
 		return 1, nil // https://subnets.avax.network/x-chain/block/1