Handle empty Bambu Studio URIs

Ignore empty bambustudioopen URI triggers, log problematic input URIs during extraction failures, and bump the package version to 0.1.2.

Author: mbv06

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "slicer-uri-bridge"
-version = "0.1.1"
+version = "0.1.2"
 description = "Register slicer URI handlers and bridge slicer links to Bambu Studio."
 readme = "README.md"
 requires-python = ">=3.11"

src/slicer_uri_bridge/__init__.py

@@ -1,5 +1,3 @@
 """Slicer URI Bridge package."""
 
 from __future__ import annotations
-
-__version__ = "0.1.1"

src/slicer_uri_bridge/cli.py

@@ -6,9 +6,9 @@
 import subprocess
 import sys
 import tomllib
+from importlib.metadata import version as package_version
 from pathlib import Path
 
-from . import __version__
 from .config import config_matches_default, init_user_config, user_config_path
 from .manager import main as manager_main
 
@@ -32,7 +32,11 @@ def build_parser() -> argparse.ArgumentParser:
         prog="slicer-uri-bridge",
         description="Register slicer URI handlers and bridge slicer links to Bambu Studio.",
     )
-    parser.add_argument("--version", action="version", version=f"%(prog)s {__version__}")
+    parser.add_argument(
+        "--version",
+        action="version",
+        version=f"%(prog)s {package_version('slicer-uri-bridge')}",
+    )
 
     subparsers = parser.add_subparsers(dest="command", required=True)
 

src/slicer_uri_bridge/handler.py

@@ -224,6 +224,15 @@ def extract_download(protocol_uri: str, allowed_extensions: set[str]) -> tuple[s
     return strip_trailing_model_slash(download_url, allowed_extensions), suggested_name
 
 
+def is_empty_bambustudioopen_uri(protocol_uri: str) -> bool:
+    parsed = urllib.parse.urlsplit(protocol_uri)
+    if parsed.scheme.lower() != "bambustudioopen":
+        return False
+
+    payload = protocol_uri.split(":", 1)[1].lstrip("/")
+    return not urllib.parse.unquote(payload).strip()
+
+
 def filename_from_url(url: str) -> str | None:
     parsed = urllib.parse.urlsplit(url)
     query_name = urllib.parse.parse_qs(parsed.query).get("name", [""])[0].strip()
@@ -609,6 +618,7 @@ def show_error(message: str) -> None:
 def main(argv: list[str] | None = None) -> int:
     setup_logging()
     args = parse_args(sys.argv[1:] if argv is None else argv)
+    uri: str | None = None
     local_path: Path | None = None
     download_folder: Path | None = None
 
@@ -620,7 +630,15 @@ def main(argv: list[str] | None = None) -> int:
         download_folder = download_folder_from_config(config)
 
         uri = resolve_protocol_uri(args)
-        download_url, suggested_name = extract_download(uri, allowed_extensions)
+        if is_empty_bambustudioopen_uri(uri):
+            logger.info("Ignoring empty bambustudioopen URI: %r", uri)
+            return 0
+
+        try:
+            download_url, suggested_name = extract_download(uri, allowed_extensions)
+        except BridgeError:
+            logger.error("Input URI: %r", uri)
+            raise
         logger.info(f"Resolved input URI with download URL: {download_url}")
         allowed_hosts, allow_any_original_host = load_allowed_hosts(config)
         validate_remote_url(

tests/test_handler.py

@@ -15,7 +15,9 @@
     choose_filename,
     extract_download,
     filename_from_url,
+    is_empty_bambustudioopen_uri,
     normalize_host,
+    main,
     read_protocol_uri,
     has_executable_bits,
     launch_bambu,
@@ -69,6 +71,69 @@ def test_download_url_rejects_control_characters(self) -> None:
             )
 
 
+class BambuEmptyUriTests(unittest.TestCase):
+    def test_detects_empty_bambustudioopen_uri(self) -> None:
+        self.assertTrue(is_empty_bambustudioopen_uri("bambustudioopen:///"))
+        self.assertTrue(is_empty_bambustudioopen_uri("bambustudioopen://%20%20"))
+        self.assertFalse(
+            is_empty_bambustudioopen_uri(
+                "bambustudioopen://https%3A%2F%2Ffiles.example%2Fmodels%2Fbenchy.3mf"
+            )
+        )
+        self.assertFalse(is_empty_bambustudioopen_uri("prusaslicer://open?file="))
+
+    def test_main_ignores_empty_bambustudioopen_uri(self) -> None:
+        config = {
+            "security": {
+                "allowed_extensions": {".3mf"},
+                "allow_plain_http": False,
+                "allowed_hosts": [],
+                "allow_any_original_host": True,
+            },
+            "bambu_studio": {},
+        }
+
+        with (
+            patch("slicer_uri_bridge.handler.load_config", return_value=config),
+            patch("slicer_uri_bridge.handler.resolve_bambu_command") as resolve_command,
+            patch("slicer_uri_bridge.handler.extract_download") as extract,
+            patch("slicer_uri_bridge.handler.launch_bambu") as launch,
+        ):
+            exit_code = main(["bambustudioopen:///"])
+
+        self.assertEqual(exit_code, 0)
+        resolve_command.assert_not_called()
+        extract.assert_not_called()
+        launch.assert_not_called()
+
+
+class MainLoggingTests(unittest.TestCase):
+    def test_logs_input_uri_when_download_extraction_fails(self) -> None:
+        config = {
+            "security": {
+                "allowed_extensions": {".3mf"},
+                "allow_plain_http": False,
+                "allowed_hosts": [],
+                "allow_any_original_host": True,
+            }
+        }
+
+        with (
+            patch("slicer_uri_bridge.handler.load_config", return_value=config),
+            patch("slicer_uri_bridge.handler.show_error"),
+            self.assertLogs("slicer_uri_bridge", level="ERROR") as captured,
+        ):
+            exit_code = main(["prusaslicer://open?file=%20%20"])
+
+        self.assertEqual(exit_code, 1)
+        self.assertTrue(
+            any("Input URI: 'prusaslicer://open?file=%20%20'" in line for line in captured.output)
+        )
+        self.assertTrue(
+            any("Failed: Invalid prusaslicer URI." in line for line in captured.output)
+        )
+
+
 class FilenameTests(unittest.TestCase):
     def test_filename_from_url_prefers_query_name_basename(self) -> None:
         self.assertEqual(