Skip to content

Error messages while processing files appear to be incorrect #353

Open
@ambergorzynski

Description

I mutate a set of files, and Dredd appears to behave correctly by skipping the files in which it encounters compile-time errors. However, it then produces error messages for all subsequent files. These files appear to have been mutated correctly upon inspection after the mutation has finished, and Dredd correctly only lists the files with real errors at the end of mutation. So it seems there is simply a problem with the error message during mutation.

I mutate 19 files and get the following output:

Processing ../src/gallium/auxiliary/util/u_pstipple.c
Processing ../src/gallium/winsys/sw/dri/dri_sw_winsys.c
Processing ../src/compiler/nir/nir_lower_var_copies.c
Processing ../src/gallium/auxiliary/nir/nir_draw_helpers.c
Processing ../src/gallium/drivers/llvmpipe/lp_state_vertex.c
Processing ../src/mesa/state_tracker/st_atom_blend.c
Processing ../src/glx/glx_error.c
Processing ../src/mesa/main/arrayobj.c
Processing ../src/egl/main/egldevice.c
Processing ../src/util/bitscan.c
Processing ../src/mesa/state_tracker/st_format.c
Processing ../src/compiler/nir/nir_gather_info.c
Processing ../src/compiler/nir/nir_opt_find_array_copies.c
Processing ../src/compiler/nir/nir_passthrough_tcs.c
Processing ../src/mesa/main/eval.c
Processing ../src/gallium/frontends/lavapipe/lvp_lower_vulkan_resource.c
In file included from ../src/glx/apple/apple_glx_drawable.c:36:
../src/glx/apple/apple_glx.h:38:10: fatal error: 'Xplugin.h' file not found
   38 | #include <Xplugin.h>
      |          ^~~~~~~~~~~
Processing ../src/glx/apple/apple_glx_drawable.c
Skipping due to errors
1 error generated.
Error while processing /data/dev/mesa_mutated/src/glx/apple/apple_glx_drawable.c.
Processing ../src/gallium/auxiliary/vl/vl_compositor.c
1 error generated.
Error while processing /data/dev/mesa_mutated/src/gallium/auxiliary/vl/vl_compositor.c.
Processing ../src/util/slab.c
1 error generated.
Error while processing /data/dev/mesa_mutated/src/util/slab.c.
Processing ../src/compiler/nir/nir_lower_flrp.c
1 error generated.
Error while processing /data/dev/mesa_mutated/src/compiler/nir/nir_lower_flrp.c.
The following files were not mutated due to compile-time errors; see above for details:
  ../src/glx/apple/apple_glx_drawable.c
Number of files that contain "dredd" in "/data/dev/mesa_mutated" is: 18

There is a 'real' error in src/glx/apple/apple_glx_drawable.c, and that is the only file that is skipped. All other 18 files are mutated correctly (based on a manual review of the files and successfully building the project after mutation), but Dredd emits error messages for all subsequent files e.g. src/util/slab.c.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions