Merge pull request astropy#18236 from astrofrog/py-limited-api-build

Include a limited API build in CI, disabling incompatible extensions

Author: astrofrog

.github/workflows/ci_workflows.yml

@@ -134,3 +134,37 @@ jobs:
       test_command: pytest -p no:warnings --astropy-header -m "not hypothesis" -k "not test_data_out_of_range and not test_set_locale and not TestQuantityTyping" --pyargs astropy
       targets: |
         - cp311-manylinux_x86_64
+
+
+  test_limited_api_build:
+
+    # Test to make sure that we can build astropy with the limited API
+    # Currently, several extensions do not compile, so we remove them for
+    # now to make sure the remaining ones build fine. Once all the exceptions
+    # are removed, we can remove this job and instead opt in to the limited
+    # API in one of the main build+test tox jobs.
+
+    runs-on: ubuntu-latest
+    name: Python 3.11 (build only, partial) with limited API
+    needs: [initial_checks]
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
+        with:
+          persist-credentials: false
+          fetch-depth: 0
+      - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065  # v5.6.0
+        name: Install Python
+        with:
+          python-version: "3.11"
+      - run: |
+          rm \
+            astropy/cosmology/_src/setup_package.py \
+            astropy/table/_column_mixins.pyx \
+            astropy/table/setup_package.py \
+            astropy/utils/xml/setup_package.py \
+            astropy/wcs/setup_package.py
+        name: Remove incompatible extensions
+      - run: pipx run build
+        name: Run build
+        env:
+          EXTENSION_HELPERS_PY_LIMITED_API: 'cp311'

astropy/io/fits/hdu/compressed/src/compression.c

@@ -9,6 +9,8 @@
 #include <unquantize.h>
 #include <ricecomp.h>
 
+/* The following is needed in order to avoid compilation warnings related to calloc() */
+#include <stdlib.h>
 
 /* Define docstrings */
 static char module_docstring[] = "Core compression/decompression functions wrapped from cfitsio.";

astropy/io/votable/src/tablewriter.c

@@ -220,7 +220,7 @@ write_tabledata(PyObject* self, PyObject *args, PyObject *kwds)
     if (!supports_empty_values) goto exit;
     for (i = 0; i < ncols; ++i) {
         supports_empty_values[i] = PyObject_IsTrue(
-                PyList_GET_ITEM(py_supports_empty_values, i));
+                PyList_GetItem(py_supports_empty_values, i));
     }
 
     if ((buf = PyMem_Malloc((size_t)buf_size * sizeof(CHAR))) == NULL) goto exit;
@@ -234,7 +234,7 @@ write_tabledata(PyObject* self, PyObject *args, PyObject *kwds)
         if (_write_cstring(&buf, &buf_size, &x, " <TR>\n", 6)) goto exit;
 
         for (j = 0; j < ncols; ++j) {
-            if ((converter = PyList_GET_ITEM(converters, j)) == NULL) goto exit;
+            if ((converter = PyList_GetItem(converters, j)) == NULL) goto exit;
             if ((array_val = PySequence_GetItem(array_row, j)) == NULL) goto exit;
             if ((mask_val = PySequence_GetItem(mask_row, j)) == NULL) goto exit;
 

pyproject.toml

@@ -168,7 +168,7 @@ requires = ["setuptools>=77.0.0",
             "setuptools_scm>=8.0.0",
             "cython>=3.0.0, <4",
             "numpy>=2.0.0, <3",
-            "extension-helpers>=1,<2"]
+            "extension-helpers>=1.4,<2"]
 build-backend = "setuptools.build_meta"
 
 [tool.setuptools]