Fixing some of the code smells

Author: mccaffers

source/databaseConnection.cpp

@@ -9,9 +9,15 @@
 #include <pqxx/pqxx>
 #include <cstdio>
 #include <charconv>
+#include <format>
 #include <stdexcept>
 #include <boost/decimal.hpp>
 
+class InvalidTimestampFormatError : public std::runtime_error {
+public:
+    using std::runtime_error::runtime_error;
+};
+
 static std::chrono::system_clock::time_point fastParseTimestamp(const char* ts) {
     int year = 0;
     int month = 0;
@@ -23,14 +29,15 @@ static std::chrono::system_clock::time_point fastParseTimestamp(const char* ts)
     const int parsedFields =
         std::sscanf(ts, "%4d-%2d-%2d %2d:%2d:%2d.%d", &year, &month, &day, &hour, &min, &sec, &usec);
     if (parsedFields != 6 && parsedFields != 7) {
-        throw std::runtime_error("Invalid timestamp format");
+        throw InvalidTimestampFormatError("Invalid timestamp format: " + std::string(ts));
     }
 
     // Cache timegm per date — tick data is time-ordered so date changes rarely
-    static char cachedDate[11] = {};
+    static std::string cachedDate;
     static time_t cachedEpoch = 0;
-    if (std::memcmp(ts, cachedDate, 10) != 0) {
-        std::memcpy(cachedDate, ts, 10);
+    const std::string_view date(ts, 10);
+    if (cachedDate != date) {
+        cachedDate.assign(date);
         std::tm tm = {};
         tm.tm_year = year - 1900;
         tm.tm_mon  = month - 1;
@@ -46,13 +53,9 @@ static std::chrono::system_clock::time_point fastParseTimestamp(const char* ts)
 DatabaseConnection::DatabaseConnection(const std::string& endpoint, int port,
                                      const std::string& dbname, const std::string& user,
                                      const std::string& password) {
-    connection_string =
-        "host=" + endpoint + " "
-        "port=" + std::to_string(port) + " "
-        "dbname=" + dbname + " "
-        "user=" + user + " "
-        "password=" + password + " "
-        "connect_timeout=3";
+    connection_string = std::format(
+        "host={} port={} dbname={} user={} password={} connect_timeout=3",
+        endpoint, port, dbname, user, password);
 
 }
 

source/elasticClient.cpp

@@ -59,6 +59,12 @@ int ElasticClient::putTradingResults(const TradingResults& results) {
     curl_easy_setopt(curl, CURLOPT_POSTFIELDS, body.c_str());
     curl_easy_setopt(curl, CURLOPT_POSTFIELDSIZE, static_cast<long>(body.size()));
 
+    // Require TLS 1.2 or newer and enforce certificate / hostname verification
+    // for any HTTPS endpoint (Sonar cpp:S4423 / S5527).
+    curl_easy_setopt(curl, CURLOPT_SSLVERSION, CURL_SSLVERSION_TLSv1_2);
+    curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 1L);
+    curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 2L);
+
     const CURLcode rc = curl_easy_perform(curl);
 
     long httpStatus = 0;

source/redisLoader.cpp

@@ -20,6 +20,7 @@
 #include <boost/asio/use_awaitable.hpp>
 #include <boost/redis.hpp>
 #include <boost/redis/connection.hpp>
+#include <boost/system/system_error.hpp>
 
 #include <nlohmann/json.hpp>
 
@@ -92,7 +93,7 @@ int RedisLoader::load(const std::string& rawJson,
     if (pushError) {
         try {
             std::rethrow_exception(pushError);
-        } catch (const std::exception& ex) {
+        } catch (const boost::system::system_error& ex) {
             std::cerr << "Redis LPUSH failed: " << ex.what() << std::endl;
         }
         return 3;
@@ -145,15 +146,15 @@ int RedisLoader::loadPayload(const std::string& redisHost,
     if (pushError) {
         try {
             std::rethrow_exception(pushError);
-        } catch (const std::exception& ex) {
+        } catch (const boost::system::system_error& ex) {
             std::cerr << "Redis LPUSH failed: " << ex.what() << std::endl;
         }
         return 3;
     }
 
     try {
         JsonParser::parseConfigurationFromBase64(encoded);
-    } catch (const std::exception& ex) {
+    } catch (const nlohmann::json::exception& ex) {
         std::cerr << "RedisLoader: failed to parse payload: " << ex.what()
                   << std::endl;
         return 2;

source/trading/tradeManager.cpp

@@ -9,14 +9,15 @@
 #include <atomic>
 #include <chrono>
 #include <ctime>
+#include <format>
 #include <iomanip>
 #include <iostream>
 #include <sstream>
 
 namespace {
 std::string nextTradeId() {
     static std::atomic<uint64_t> counter{0};
-    return "T" + std::to_string(counter.fetch_add(1));
+    return std::format("T{}", counter.fetch_add(1));
 }
 }