Fix recursion in inheritance check

Adds test for double derived class

Fixes RH-37982

Author: pearswj

src/Compat/Utils.cs

@@ -164,13 +164,12 @@ internal static bool IsDerived(TypeDefinition type, TypeReference base_type)
                 return true;
             try
             {
-                IsDerived(type.BaseType.Resolve(), base_type);
+                return IsDerived(type.BaseType.Resolve(), base_type);
             }
             catch (AssemblyResolutionException)
             {
                 return false;
             }
-            return false;
         }
 
         /// <summary>

test/integration/access.bats

@@ -118,4 +118,8 @@ function teardown {
 
 # @test "should pass if public nested class becomes protected internal when called from derived class" {
   cat test_output | grep "✓ System.Void AccessTestLib.MyClass::PublicMethodBecomesProtectedInternal() < AccessTestLib"
+# }
+
+# @test "should pass if protected method called from double derived class" {
+  cat test_output | grep "✓ System.Void AccessTestLib.BaseClassWithProtectedVirtualMethod::ProtectedVirtualMethod() < AccessTestLib"
 }

test/integration/projects/AccessTest/AccessTest/MyClass.cs

@@ -1,4 +1,5 @@
 using System;
+
 namespace AccessTest
 {
   public class MyClass
@@ -136,4 +137,18 @@ public DerivedClass()
       this.PublicMethodBecomesProtectedInternal();
     }
   }
+
+  // the case of the protected virtual method...
+  // see RH-37982
+
+  class DerivedClassWithProtectedOverrideMethod : AccessTestLib.BaseClassWithProtectedVirtualMethod
+  { }
+
+  class DoubleDerivedClassWithProtectedOverrideMethod : DerivedClassWithProtectedOverrideMethod
+  {
+    protected override void ProtectedVirtualMethod()
+    {
+      base.ProtectedVirtualMethod();
+    }
+  }
 }

test/integration/projects/AccessTest/AccessTestLib/MyClass.cs

@@ -155,4 +155,13 @@ internal struct PublicStructBecomesInternal
   public struct PublicStructBecomesInternal
 #endif
   { }
+
+  // the case of the protected virtual method...
+  // see RH-37982
+
+  public class BaseClassWithProtectedVirtualMethod
+  {
+    protected virtual void ProtectedVirtualMethod()
+    { }
+  }
 }