Remove job history

Author: 0xERR0R

Diff for: core/common.go

@@ -32,8 +32,6 @@ type Job interface {
 	Use(...Middleware)
 	Run(*Context) error
 	Running() int32
-	History() []*Execution
-	AddHistory(...*Execution)
 	NotifyStart()
 	NotifyStop()
 }
@@ -61,7 +59,6 @@ func NewContext(s *Scheduler, j Job, e *Execution) *Context {
 
 func (c *Context) Start() {
 	c.Execution.Start()
-	c.Job.AddHistory(c.Execution)
 	c.Job.NotifyStart()
 }
 

Diff for: core/job.go

@@ -28,16 +28,6 @@ func (j *BareJob) GetCommand() string {
 	return j.Command
 }
 
-func (j *BareJob) History() []*Execution {
-	return j.history
-}
-
-func (j *BareJob) AddHistory(e ...*Execution) {
-	j.lock.Lock()
-	defer j.lock.Unlock()
-	j.history = append(j.history, e...)
-}
-
 func (j *BareJob) Running() int32 {
 	return atomic.LoadInt32(&j.running)
 }

Diff for: core/job_test.go

@@ -18,19 +18,6 @@ func (s *SuiteBareJob) TestGetters(c *C) {
 	c.Assert(job.GetCommand(), Equals, "qux")
 }
 
-func (s *SuiteBareJob) TestHistory(c *C) {
-	eA := NewExecution()
-	eB := NewExecution()
-
-	job := &BareJob{}
-	job.AddHistory(eA, eB)
-
-	h := job.History()
-	c.Assert(h, HasLen, 2)
-	c.Assert(h[0], DeepEquals, eA)
-	c.Assert(h[1], DeepEquals, eB)
-}
-
 func (s *SuiteBareJob) TestNotifyStartStop(c *C) {
 	job := &BareJob{}
 

Diff for: core/localjob_test.go

@@ -1,7 +1,7 @@
 package core
 
 import (
-	"bytes"
+	"github.com/armon/circbuf"
 
 	. "gopkg.in/check.v1"
 )
@@ -14,7 +14,7 @@ func (s *SuiteLocalJob) TestRun(c *C) {
 	job := &LocalJob{}
 	job.Command = `echo "foo bar"`
 
-	b := bytes.NewBuffer(nil)
+	b, _ := circbuf.NewBuffer(1000)
 	e := NewExecution()
 	e.OutputStream = b
 

Diff for: core/scheduler_test.go

@@ -39,13 +39,6 @@ func (s *SuiteScheduler) TestStartStop(c *C) {
 
 	sc.Stop()
 	c.Assert(sc.IsRunning(), Equals, false)
-
-	h := job.History()
-	c.Assert(h, HasLen, 2)
-	c.Assert(h[0].IsRunning, Equals, false)
-	c.Assert(h[0].Date.IsZero(), Equals, false)
-	c.Assert(h[1].IsRunning, Equals, false)
-	c.Assert(h[1].Date.IsZero(), Equals, false)
 }
 
 func (s *SuiteScheduler) TestMergeMiddlewaresSame(c *C) {