Protect daily progress from stale challenge tabs

Author: gmval-g3

index.html

@@ -191,19 +191,26 @@ <h2 id="journal-title">SIGNAL LOG</h2>
 }));
 let progressStorage = null;
 try { progressStorage = window.localStorage; } catch {}
+const loadedProgress = LittleAndroidProgress.loadProgress(progressStorage);
 const savedProgress = LittleAndroidProgress.scopeProgressToChallenge(
-  LittleAndroidProgress.loadProgress(progressStorage),
+  loadedProgress,
   dailyChallenge.dateKey,
 );
+if (loadedProgress.challengeDate !== savedProgress.challengeDate) {
+  LittleAndroidProgress.saveProgress(progressStorage, savedProgress);
+}
 const feedback = LittleAndroidFeedback.createFeedbackController(window, progressStorage);
 const metrics = LittleAndroidEngagement.createLocalMetrics(progressStorage);
 metrics.increment('sessions');
+let progressGeneration = savedProgress.generation;
 for (const fragment of signalFragments) {
   fragment.discovered = savedProgress.discoveredFragments.includes(fragment.id);
   fragment.collected = savedProgress.collectedFragments.includes(fragment.id);
 }
 const discoveredNPCs = new Set(savedProgress.discoveredNPCs);
-const quest = { complete: savedProgress.complete };
+const quest = {
+  complete: savedProgress.complete || signalFragments.every(fragment => fragment.collected),
+};
 
 function isWalkable(tx,ty){
   if(tx<0||ty<0||tx>=MW||ty>=MH)return false;
@@ -998,6 +1005,7 @@ <h2 id="journal-title">SIGNAL LOG</h2>
   return {
     version: LittleAndroidProgress.SAVE_VERSION,
     challengeDate: dailyChallenge.dateKey,
+    generation: progressGeneration,
     discoveredFragments: signalFragments.filter(fragment => fragment.discovered).map(fragment => fragment.id),
     collectedFragments: signalFragments.filter(fragment => fragment.collected).map(fragment => fragment.id),
     discoveredNPCs: [...discoveredNPCs],
@@ -1006,12 +1014,26 @@ <h2 id="journal-title">SIGNAL LOG</h2>
 }
 
 function persistProgress() {
-  const latest = LittleAndroidProgress.scopeProgressToChallenge(
-    LittleAndroidProgress.loadProgress(progressStorage),
-    dailyChallenge.dateKey,
+  const stored = LittleAndroidProgress.loadProgress(progressStorage);
+  if (stored.challengeDate && stored.challengeDate !== dailyChallenge.dateKey) return false;
+  const latest = LittleAndroidProgress.scopeProgressToChallenge(stored, dailyChallenge.dateKey);
+  const merged = LittleAndroidProgress.mergeProgress(
+    latest,
+    currentProgress(),
+    signalFragments.map(fragment => fragment.id),
   );
-  const merged = LittleAndroidProgress.mergeProgress(latest, currentProgress());
+  progressGeneration = merged.generation;
+  for (const fragment of signalFragments) {
+    fragment.discovered = merged.discoveredFragments.includes(fragment.id);
+    fragment.collected = merged.collectedFragments.includes(fragment.id);
+  }
+  discoveredNPCs.clear();
+  for (const identity of merged.discoveredNPCs) discoveredNPCs.add(identity);
+  quest.complete = merged.complete;
+  document.body.classList.toggle('world-restored', quest.complete);
+  updateQuestUI();
   LittleAndroidProgress.saveProgress(progressStorage, merged);
+  return merged;
 }
 
 function rememberNPC(npc) {
@@ -1071,7 +1093,9 @@ <h2 id="journal-title">SIGNAL LOG</h2>
   discoveredNPCs.clear();
   quest.complete = false;
   document.body.classList.remove('world-restored');
-  LittleAndroidProgress.clearProgress(progressStorage);
+  const storedGeneration = LittleAndroidProgress.loadProgress(progressStorage).generation;
+  progressGeneration = Math.max(progressGeneration, storedGeneration) + 1;
+  LittleAndroidProgress.saveProgress(progressStorage, currentProgress());
   updateQuestUI();
   updateJournal();
   showStatus('SIGNAL SEARCH RESTARTED', 2);
@@ -1085,8 +1109,7 @@ <h2 id="journal-title">SIGNAL LOG</h2>
     confirmReset(message) :
     typeof window.confirm === 'function' && window.confirm(message);
   if (!confirmed) return false;
-  resetQuest();
-  return true;
+  return resetQuest();
 }
 
 function performAction() {

src/progress.js

@@ -12,6 +12,7 @@
     return {
       version: SAVE_VERSION,
       challengeDate: '',
+      generation: 0,
       discoveredFragments: [],
       collectedFragments: [],
       discoveredNPCs: [],
@@ -32,6 +33,7 @@
       return {
         version: SAVE_VERSION,
         challengeDate: typeof parsed.challengeDate === 'string' ? parsed.challengeDate : '',
+        generation: Number.isSafeInteger(parsed.generation) && parsed.generation >= 0 ? parsed.generation : 0,
         discoveredFragments: normalizeStringList(parsed.discoveredFragments),
         collectedFragments: normalizeStringList(parsed.collectedFragments),
         discoveredNPCs: normalizeStringList(parsed.discoveredNPCs),
@@ -57,29 +59,38 @@
     return {
       ...defaultProgress(),
       challengeDate,
+      generation: normalized.generation + 1,
       discoveredNPCs: normalized.discoveredNPCs,
     };
   }
 
-  function mergeProgress(base, incoming) {
+  function mergeProgress(base, incoming, requiredFragmentIds = []) {
     const current = parseProgress(base);
     const next = parseProgress(incoming);
+    if (current.generation !== next.generation) {
+      return current.generation > next.generation ? current : next;
+    }
+    const collectedFragments = normalizeStringList([
+      ...current.collectedFragments,
+      ...next.collectedFragments,
+    ]);
     return {
       version: SAVE_VERSION,
       challengeDate: next.challengeDate || current.challengeDate,
+      generation: current.generation,
       discoveredFragments: normalizeStringList([
         ...current.discoveredFragments,
         ...next.discoveredFragments,
       ]),
-      collectedFragments: normalizeStringList([
-        ...current.collectedFragments,
-        ...next.collectedFragments,
-      ]),
+      collectedFragments,
       discoveredNPCs: normalizeStringList([
         ...current.discoveredNPCs,
         ...next.discoveredNPCs,
       ]),
-      complete: current.complete || next.complete,
+      complete: current.complete || next.complete || (
+        requiredFragmentIds.length > 0 &&
+        requiredFragmentIds.every(id => collectedFragments.includes(id))
+      ),
     };
   }
 

tests/progress.test.cjs

@@ -41,6 +41,7 @@ test('progress normalizes lists and ignores unknown fields', () => {
   assert.deepEqual(parsed, {
     version: SAVE_VERSION,
     challengeDate: '2026-07-16',
+    generation: 0,
     discoveredFragments: ['a'],
     collectedFragments: ['a'],
     discoveredNPCs: ['scout'],
@@ -79,11 +80,14 @@ test('daily progress restores only for the matching challenge date', () => {
     complete: true,
   };
   assert.deepEqual(scopeProgressToChallenge(completed, '2026-07-15'), completed);
-  assert.deepEqual(scopeProgressToChallenge(completed, '2026-07-16'), {
+  const rolled = scopeProgressToChallenge(completed, '2026-07-16');
+  assert.deepEqual(rolled, {
     ...defaultProgress(),
     challengeDate: '2026-07-16',
+    generation: 1,
     discoveredNPCs: ['OVERSEER'],
   });
+  assert.deepEqual(mergeProgress(rolled, completed, ['field-coil']), rolled);
 });
 
 test('progress round-trips and clears through storage', () => {
@@ -106,10 +110,22 @@ test('progress merges monotonically across stale tabs', () => {
     ...defaultProgress(),
     discoveredNPCs: ['OVERSEER'],
   };
-  assert.deepEqual(mergeProgress(firstTab, staleTab), {
+  assert.deepEqual(mergeProgress(firstTab, staleTab, ['field-coil']), {
     ...defaultProgress(),
     discoveredFragments: ['field-coil'],
     collectedFragments: ['field-coil'],
     discoveredNPCs: ['OVERSEER'],
+    complete: true,
   });
 });
+
+test('a newer reset generation defeats stale tab writes', () => {
+  const reset = { ...defaultProgress(), generation: 2 };
+  const stale = {
+    ...defaultProgress(),
+    generation: 1,
+    collectedFragments: ['field-coil'],
+    complete: true,
+  };
+  assert.deepEqual(mergeProgress(reset, stale, ['field-coil']), reset);
+});