Merge final gameplay safeguards into feedback polish

Author: gmval-g3

index.html

@@ -252,12 +252,13 @@ <h2 id="journal-title">SIGNAL LOG</h2>
 
   // Interaction targets reserve their tile so the player stops facing them.
   const npcOnTile = isTileOccupiedByNPC(tx, ty, null);
-  const fragmentOnTile = getUncollectedFragmentAt(tx, ty);
+  const fragmentOnTile = getActiveFragmentAt(tx, ty);
   if (npcOnTile || fragmentOnTile || !isWalkable(tx, ty)) {
     // BLOCKED
     player.state = 'BLOCKED';
     player.bumpDir = dir;
     player.bumpProgress = 0;
+    if (fragmentOnTile && !fragmentOnTile.discovered) showStatus('SIGNAL INTERFERENCE · SCAN');
     return;
   }
 
@@ -848,7 +849,7 @@ <h2 id="journal-title">SIGNAL LOG</h2>
 // PATHFINDING
 // ══════════════════════════════════════════════════════
 function findPath(sx,sy,ex,ey){
-  const isPlayerWalkable = (x, y) => isWalkable(x, y) && !getUncollectedFragmentAt(x, y);
+  const isPlayerWalkable = (x, y) => isWalkable(x, y) && !getActiveFragmentAt(x, y);
   return findWorldPath(sx, sy, ex, ey, isPlayerWalkable, { allowNearest: false });
 }
 
@@ -1024,6 +1025,14 @@ <h2 id="journal-title">SIGNAL LOG</h2>
 }
 
 function resetQuest() {
+  const occupiedSignalSite = signalFragments.some(fragment => (
+    entityOccupiesTile(player, fragment.x, fragment.y) ||
+    isTileReserved(npcs, fragment.x, fragment.y, null)
+  ));
+  if (occupiedSignalSite) {
+    showStatus('CLEAR SIGNAL SITES BEFORE RESTART', 2.5);
+    return false;
+  }
   for (const fragment of signalFragments) {
     fragment.discovered = false;
     fragment.collected = false;
@@ -1035,6 +1044,7 @@ <h2 id="journal-title">SIGNAL LOG</h2>
   updateQuestUI();
   updateJournal();
   showStatus('SIGNAL SEARCH RESTARTED', 2);
+  return true;
 }
 
 function requestQuestReset(confirmReset) {
@@ -1069,6 +1079,7 @@ <h2 id="journal-title">SIGNAL LOG</h2>
   journalDialog.showModal();
 });
 journalClose.addEventListener('click', () => journalDialog.close());
+journalDialog.addEventListener('close', () => canvas.focus({ preventScroll: true }));
 function updateSoundButton() {
   const muted = feedback.isMuted();
   soundButton.classList.toggle('muted', muted);

tests/runtime-smoke.test.cjs

@@ -54,6 +54,7 @@ test('runtime initializes and renders a frame', () => {
     'journal-close': element(),
     'sound-button': element(),
   };
+  elements.game.focus = () => { listeners.canvasFocused = true; };
   const sandbox = {
     LittleAndroidLogic,
     LittleAndroidContent,
@@ -98,24 +99,29 @@ test('runtime initializes and renders a frame', () => {
     { ...keyboardTargets },
     { game: true, canvas: true, control: false },
   );
+  listeners.close();
+  assert.equal(listeners.canvasFocused, true);
 
   const retrieval = vm.runInContext(`
     const fragment = signalFragments[0];
     player.tileX = fragment.x;
     player.tileY = fragment.y - 1;
     player.renderX = player.tileX;
     player.renderY = player.tileY;
+    playerStartMove('south');
+    const hiddenBlocked = player.state;
+    player.state = 'IDLE';
     triggerScanPulse();
     updateScanPulse(1);
     playerStartMove('south');
     const blocked = player.state;
     player.state = 'IDLE';
     performAction();
-    ({ discovered: fragment.discovered, blocked, collected: fragment.collected });
+    ({ discovered: fragment.discovered, hiddenBlocked, blocked, collected: fragment.collected });
   `, sandbox);
   assert.deepEqual(
     { ...retrieval },
-    { discovered: true, blocked: 'BLOCKED', collected: true },
+    { discovered: true, hiddenBlocked: 'BLOCKED', blocked: 'BLOCKED', collected: true },
   );
 
   const resetBehavior = vm.runInContext(`
@@ -139,6 +145,17 @@ test('runtime initializes and renders a frame', () => {
   `, sandbox);
   assert.deepEqual({ ...completion }, { complete: true, collected: 3 });
   assert.equal(elements.quest.textContent, 'FACTORY ONLINE');
+
+  const replay = vm.runInContext(`
+    player.tileX = signalFragments[0].x;
+    player.tileY = signalFragments[0].y;
+    const replayRefused = resetQuest();
+    player.tileX = 4;
+    player.tileY = 6;
+    const replayAccepted = resetQuest();
+    ({ refused: replayRefused, accepted: replayAccepted, collected: signalFragments.filter(fragment => fragment.collected).length });
+  `, sandbox);
+  assert.deepEqual({ ...replay }, { refused: false, accepted: true, collected: 0 });
 });
 
 test('NPC movement rejects a destination reserved earlier in the frame', () => {