Fixed clippy warning

senseix21 · senseix21 · commit 43549745829f · 2025-12-20T14:32:55.000+06:00
diff --git a/examples/benchmark.rs b/examples/benchmark.rs
@@ -123,7 +123,7 @@ fn evaluate_certificate(seed: &str, offset: usize, coverage: usize) -> usize {
     measure_block!("tls_parse", {
         let len = bytes.len().max(1);
         bytes.rotate_left(offset % len);
-        if coverage % 2 == 0 {
+        if coverage.is_multiple_of(2) {
             thread::sleep(Duration::from_micros(60));
         }
     });
diff --git a/shadowmap-sbom.json b/shadowmap-sbom.json
@@ -0,0 +1,32 @@
+{
+  "components": [
+    {
+      "licenses": [
+        "Apache-2.0",
+        "MIT"
+      ],
+      "name": "shadowmap",
+      "type": "application",
+      "version": "0.1.0"
+    },
+    {
+      "licenses": [
+        "Apache-2.0"
+      ],
+      "name": "openssl",
+      "type": "library",
+      "version": "3.2.1"
+    },
+    {
+      "licenses": [
+        "MIT"
+      ],
+      "name": "tokio",
+      "type": "library",
+      "version": "1.40.0"
+    }
+  ],
+  "format": "cyclonedx",
+  "generated_at": "2025-12-20T08:28:34.714909+00:00",
+  "manifest": "Cargo.toml"
+}
diff --git a/src/pretty_report.rs b/src/pretty_report.rs
@@ -10,6 +10,21 @@ use tabled::{Table, Tabled, settings::Style};
 use crate::cloud::CloudAssetFinding;
 use crate::social::SocialIntelligenceSummary;
 
+pub struct ReconSummary<'a> {
+    pub domain: &'a str,
+    pub subs: &'a HashSet<String>,
+    pub header_map: &'a HashMap<String, (u16, Option<String>)>,
+    pub open_ports_map: &'a HashMap<String, Vec<u16>>,
+    pub cors_map: &'a HashMap<String, Vec<String>>,
+    pub software_map: &'a HashMap<String, HashMap<String, String>>,
+    pub takeover_map: &'a HashMap<String, Vec<String>>,
+    #[allow(dead_code)]
+    pub cloud_saas_map: &'a HashMap<String, Vec<String>>,
+    pub cloud_asset_map: &'a HashMap<String, Vec<CloudAssetFinding>>,
+    pub social_intel: Option<&'a SocialIntelligenceSummary>,
+    pub output_dir: &'a str,
+}
+
 pub struct PrettyReportGenerator;
 
 #[derive(Tabled)]
@@ -30,27 +45,17 @@ struct SubdomainRow {
 
 impl PrettyReportGenerator {
     pub fn generate_markdown_report(
-        domain: &str,
-        subs: &HashSet<String>,
-        header_map: &HashMap<String, (u16, Option<String>)>,
-        open_ports_map: &HashMap<String, Vec<u16>>,
-        cors_map: &HashMap<String, Vec<String>>,
-        software_map: &HashMap<String, HashMap<String, String>>,
-        takeover_map: &HashMap<String, Vec<String>>,
-        _cloud_saas_map: &HashMap<String, Vec<String>>,
-        cloud_asset_map: &HashMap<String, Vec<CloudAssetFinding>>,
-        social_intel: Option<&SocialIntelligenceSummary>,
-        output_dir: &str,
+        summary: &ReconSummary,
     ) -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
-        let report_file = format!("{}/{}_REPORT.md", output_dir, domain);
+        let report_file = format!("{}/{}_REPORT.md", summary.output_dir, summary.domain);
         let mut f = File::create(&report_file)?;
 
         let timestamp = Local::now().format("%Y-%m-%d %H:%M:%S %Z");
         
         // Header
         writeln!(f, "# ShadowMap Security Report")?;
         writeln!(f)?;
-        writeln!(f, "**Target Domain:** `{}`", domain)?;
+        writeln!(f, "**Target Domain:** `{}`", summary.domain)?;
         writeln!(f, "**Scan Date:** {}", timestamp)?;
         writeln!(f, "**Generated by:** ShadowMap v{}", env!("CARGO_PKG_VERSION"))?;
         writeln!(f)?;
@@ -61,10 +66,10 @@ impl PrettyReportGenerator {
         writeln!(f, "## Executive Summary")?;
         writeln!(f)?;
         
-        let total_subs = subs.len();
-        let cors_issues = cors_map.len();
-        let takeover_risks = takeover_map.len();
-        let cloud_assets = cloud_asset_map.len();
+        let total_subs = summary.subs.len();
+        let cors_issues = summary.cors_map.len();
+        let takeover_risks = summary.takeover_map.len();
+        let cloud_assets = summary.cloud_asset_map.len();
         
         let risk_level = if cors_issues > 0 || takeover_risks > 0 {
             "**HIGH**"
@@ -96,7 +101,7 @@ impl PrettyReportGenerator {
                 writeln!(f, "**Impact:** Data theft, unauthorized API access")?;
                 writeln!(f)?;
                 
-                for (sub, issues) in cors_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
+                for (sub, issues) in summary.cors_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
                     writeln!(f, "**Host:** `{}`", sub)?;
                     for issue in issues {
                         writeln!(f, "- {}", issue)?;
@@ -117,7 +122,7 @@ impl PrettyReportGenerator {
             if takeover_risks > 0 {
                 writeln!(f, "### Subdomain Takeover Risks")?;
                 writeln!(f)?;
-                for (sub, risks) in takeover_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
+                for (sub, risks) in summary.takeover_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
                     writeln!(f, "**Subdomain:** `{}`", sub)?;
                     for risk in risks {
                         writeln!(f, "- {}", risk)?;
@@ -133,8 +138,8 @@ impl PrettyReportGenerator {
         writeln!(f, "| # | Subdomain | Status | Server | Open Ports | Issues |")?;
         writeln!(f, "|---|-----------|--------|--------|------------|--------|")?;
         
-        for (idx, sub) in subs.iter().sorted().enumerate() {
-            let (status, server) = header_map.get(sub).cloned().unwrap_or((0, None));
+        for (idx, sub) in summary.subs.iter().sorted().enumerate() {
+            let (status, server) = summary.header_map.get(sub).cloned().unwrap_or((0, None));
             let status_icon = match status {
                 200..=299 => "OK",
                 300..=399 => "REDIRECT",
@@ -143,12 +148,12 @@ impl PrettyReportGenerator {
                 _ => "UNKNOWN",
             };
             
-            let ports = open_ports_map.get(sub)
+            let ports = summary.open_ports_map.get(sub)
                 .map(|v| v.iter().map(|p| p.to_string()).join(", "))
                 .unwrap_or_else(|| "-".to_string());
             
-            let issues_count = cors_map.get(sub).map(|v| v.len()).unwrap_or(0)
-                + takeover_map.get(sub).map(|v| v.len()).unwrap_or(0);
+            let issues_count = summary.cors_map.get(sub).map(|v| v.len()).unwrap_or(0)
+                + summary.takeover_map.get(sub).map(|v| v.len()).unwrap_or(0);
             
             let issues_display = if issues_count > 0 {
                 format!("ISSUES: {}", issues_count)
@@ -174,15 +179,15 @@ impl PrettyReportGenerator {
         writeln!(f, "## Port Analysis")?;
         writeln!(f)?;
         let mut all_ports: HashSet<u16> = HashSet::new();
-        for ports in open_ports_map.values() {
+        for ports in summary.open_ports_map.values() {
             all_ports.extend(ports);
         }
         
         writeln!(f, "**Unique Open Ports:** {}", all_ports.iter().sorted().map(|p| p.to_string()).join(", "))?;
         writeln!(f)?;
         
         for port in all_ports.iter().sorted() {
-            let hosts_with_port: Vec<&String> = open_ports_map
+            let hosts_with_port: Vec<&String> = summary.open_ports_map
                 .iter()
                 .filter(|(_, ports)| ports.contains(port))
                 .map(|(host, _)| host)
@@ -210,11 +215,11 @@ impl PrettyReportGenerator {
         }
 
         // Software Fingerprints
-        if !software_map.is_empty() {
+        if !summary.software_map.is_empty() {
             writeln!(f, "## Software Fingerprints")?;
             writeln!(f)?;
             
-            for (sub, fingerprints) in software_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
+            for (sub, fingerprints) in summary.software_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
                 if !fingerprints.is_empty() {
                     writeln!(f, "**{}**", sub)?;
                     for (key, value) in fingerprints {
@@ -226,14 +231,14 @@ impl PrettyReportGenerator {
         }
 
         // Cloud Assets
-        if !cloud_asset_map.is_empty() {
+        if !summary.cloud_asset_map.is_empty() {
             writeln!(f, "## Cloud Infrastructure Analysis")?;
             writeln!(f)?;
-            writeln!(f, "**Total Predicted Assets:** {}", cloud_asset_map.values().map(|v| v.len()).sum::<usize>())?;
+            writeln!(f, "**Total Predicted Assets:** {}", summary.cloud_asset_map.values().map(|v| v.len()).sum::<usize>())?;
             writeln!(f)?;
             
             let mut provider_counts: HashMap<String, usize> = HashMap::new();
-            for assets in cloud_asset_map.values() {
+            for assets in summary.cloud_asset_map.values() {
                 for asset in assets {
                     *provider_counts.entry(asset.provider.clone()).or_insert(0) += 1;
                 }
@@ -248,7 +253,7 @@ impl PrettyReportGenerator {
         }
 
         // Social Intelligence
-        if let Some(intel) = social_intel {
+        if let Some(intel) = summary.social_intel {
             writeln!(f, "## AI-Powered Threat Intelligence")?;
             writeln!(f)?;
             writeln!(f, "**Framework:** {}", intel.framework_name)?;
@@ -305,7 +310,7 @@ impl PrettyReportGenerator {
         if takeover_risks > 0 {
             writeln!(f, "2. **Investigate subdomain takeover risks** on {} subdomain(s)", takeover_risks)?;
         }
-        if open_ports_map.values().any(|ports| ports.contains(&22)) {
+        if summary.open_ports_map.values().any(|ports| ports.contains(&22)) {
             writeln!(f, "3. **Review SSH exposure** - Port 22 should not be publicly accessible")?;
         }
         writeln!(f)?;
@@ -331,56 +336,47 @@ impl PrettyReportGenerator {
         Ok(())
     }
 
-    pub fn print_terminal_summary(
-        domain: &str,
-        subs: &HashSet<String>,
-        header_map: &HashMap<String, (u16, Option<String>)>,
-        open_ports_map: &HashMap<String, Vec<u16>>,
-        cors_map: &HashMap<String, Vec<String>>,
-        takeover_map: &HashMap<String, Vec<String>>,
-        cloud_asset_map: &HashMap<String, Vec<CloudAssetFinding>>,
-        social_intel: Option<&SocialIntelligenceSummary>,
-    ) {
+    pub fn print_terminal_summary(summary: &ReconSummary) {
         println!();
         println!("{}", "═══════════════════════════════════════════════════════════".bright_cyan());
-        println!("{}", format!("  SCAN RESULTS: {}", domain).bright_white().bold());
+        println!("{}", format!("  SCAN RESULTS: {}", summary.domain).bright_white().bold());
         println!("{}", "═══════════════════════════════════════════════════════════".bright_cyan());
         println!();
 
         // Quick Stats
         println!("{}", "QUICK STATS".bright_yellow().bold());
         println!("{}", "─────────────────────────────────────────────────────────".bright_black());
-        println!("  {} Subdomains discovered", subs.len().to_string().bright_green().bold());
-        println!("  {} Live hosts verified", subs.len().to_string().bright_green().bold());
+        println!("  {} Subdomains discovered", summary.subs.len().to_string().bright_green().bold());
+        println!("  {} Live hosts verified", summary.subs.len().to_string().bright_green().bold());
         
-        if cors_map.is_empty() {
+        if summary.cors_map.is_empty() {
             println!("  {} CORS vulnerabilities", "0".bright_green().bold());
         } else {
-            println!("  {} CORS vulnerabilities [WARNING]", cors_map.len().to_string().bright_red().bold());
+            println!("  {} CORS vulnerabilities [WARNING]", summary.cors_map.len().to_string().bright_red().bold());
         }
         
-        if takeover_map.is_empty() {
+        if summary.takeover_map.is_empty() {
             println!("  {} Takeover risks", "0".bright_green().bold());
         } else {
-            println!("  {} Takeover risks [WARNING]", takeover_map.len().to_string().bright_yellow().bold());
+            println!("  {} Takeover risks [WARNING]", summary.takeover_map.len().to_string().bright_yellow().bold());
         }
         
-        println!("  {} Cloud assets flagged", cloud_asset_map.len().to_string().bright_cyan().bold());
+        println!("  {} Cloud assets flagged", summary.cloud_asset_map.len().to_string().bright_cyan().bold());
         println!();
 
         // Critical Findings
-        if !cors_map.is_empty() || !takeover_map.is_empty() {
+        if !summary.cors_map.is_empty() || !summary.takeover_map.is_empty() {
             println!("{}", "CRITICAL FINDINGS".bright_red().bold());
             println!("{}", "─────────────────────────────────────────────────────────".bright_black());
             
-            for (sub, issues) in cors_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
+            for (sub, issues) in summary.cors_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
                 println!("  {} {}", "CORS:".bright_red().bold(), sub.bright_white());
                 for issue in issues {
                     println!("    • {}", issue.bright_yellow());
                 }
             }
             
-            for (sub, risks) in takeover_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
+            for (sub, risks) in summary.takeover_map.iter().sorted_by_key(|(k, _)| k.as_str()) {
                 println!("  {} {}", "TAKEOVER:".bright_yellow().bold(), sub.bright_white());
                 for risk in risks {
                     println!("    • {}", risk);
@@ -394,25 +390,25 @@ impl PrettyReportGenerator {
         println!("{}", "─────────────────────────────────────────────────────────".bright_black());
         
         let mut rows: Vec<SubdomainRow> = Vec::new();
-        for sub in subs.iter().sorted().take(10) {
-            let (status, server) = header_map.get(sub).cloned().unwrap_or((0, None));
+        for sub in summary.subs.iter().sorted().take(10) {
+            let (status, server) = summary.header_map.get(sub).cloned().unwrap_or((0, None));
             let status_str = if status == 0 {
                 "N/A".to_string()
             } else {
                 format!("{}", status)
             };
             
-            let ports = open_ports_map.get(sub)
+            let ports = summary.open_ports_map.get(sub)
                 .map(|v| v.iter().take(4).map(|p| p.to_string()).join(","))
                 .unwrap_or_else(|| "-".to_string());
             
-            let cors_str = if cors_map.contains_key(sub) {
+            let cors_str = if summary.cors_map.contains_key(sub) {
                 "WARNING".to_string()
             } else {
                 "OK".to_string()
             };
             
-            let risks = if takeover_map.contains_key(sub) {
+            let risks = if summary.takeover_map.contains_key(sub) {
                 "WARNING".to_string()
             } else {
                 "OK".to_string()
@@ -433,14 +429,14 @@ impl PrettyReportGenerator {
             println!("{}", table);
         }
         
-        if subs.len() > 10 {
+        if summary.subs.len() > 10 {
             println!();
-            println!("  {} more subdomain(s) not shown...", (subs.len() - 10).to_string().bright_black());
+            println!("  {} more subdomain(s) not shown...", (summary.subs.len() - 10).to_string().bright_black());
         }
         println!();
 
         // Social Intelligence Summary
-        if let Some(intel) = social_intel {
+        if let Some(intel) = summary.social_intel {
             if intel.metrics.total_signals > 0 {
                 println!("{}", "AI THREAT INTELLIGENCE".bright_magenta().bold());
                 println!("{}", "─────────────────────────────────────────────────────────".bright_black());
diff --git a/src/reporting.rs b/src/reporting.rs
@@ -7,7 +7,7 @@ use itertools::Itertools;
 
 use crate::cloud::CloudAssetFinding;
 use crate::social::SocialIntelligenceSummary;
-use crate::pretty_report::PrettyReportGenerator;
+use crate::pretty_report::{PrettyReportGenerator, ReconSummary};
 
 pub struct ReconMaps<'a> {
     pub header_map: &'a HashMap<String, (u16, Option<String>)>,
@@ -190,31 +190,24 @@ pub fn write_outputs(
     )?;
 
     // Generate beautiful markdown report
-    PrettyReportGenerator::generate_markdown_report(
+    let summary = ReconSummary {
         domain,
         subs,
-        maps.header_map,
-        maps.open_ports_map,
-        maps.cors_map,
-        maps.software_map,
-        maps.takeover_map,
-        maps.cloud_saas_map,
-        maps.cloud_asset_map,
-        maps.social_intel,
+        header_map: maps.header_map,
+        open_ports_map: maps.open_ports_map,
+        cors_map: maps.cors_map,
+        software_map: maps.software_map,
+        takeover_map: maps.takeover_map,
+        cloud_saas_map: maps.cloud_saas_map,
+        cloud_asset_map: maps.cloud_asset_map,
+        social_intel: maps.social_intel,
         output_dir,
-    )?;
+    };
+    
+    PrettyReportGenerator::generate_markdown_report(&summary)?;
 
     // Print terminal summary
-    PrettyReportGenerator::print_terminal_summary(
-        domain,
-        subs,
-        maps.header_map,
-        maps.open_ports_map,
-        maps.cors_map,
-        maps.takeover_map,
-        maps.cloud_asset_map,
-        maps.social_intel,
-    );
+    PrettyReportGenerator::print_terminal_summary(&summary);
 
     Ok(())
 }

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ fn evaluate_certificate(seed: &str, offset: usize, coverage: usize) -> usize {`
`123`	`123`	`measure_block!("tls_parse", {`
`124`	`124`	`let len = bytes.len().max(1);`
`125`	`125`	`bytes.rotate_left(offset % len);`
`126`		`- if coverage % 2 == 0 {`
	`126`	`+ if coverage.is_multiple_of(2) {`
`127`	`127`	`thread::sleep(Duration::from_micros(60));`
`128`	`128`	`}`
`129`	`129`	`});`