Skip to content

Commit d9fe011

Browse files
committed
bfix: project menu state, loader size
Signed-off-by: Karthik Ayangar <[email protected]>
1 parent 7d761d8 commit d9fe011

File tree

4 files changed

+21
-27
lines changed

4 files changed

+21
-27
lines changed

frontend/src/features/workspace/components/projectCard/index.tsx

+11-18
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ interface Props {
2828
const ProjectCard: React.FC<Props> = ({
2929
projectName,
3030
orgName,
31-
3231
status,
3332
githubData,
3433
}) => {
@@ -166,13 +165,12 @@ const ProjectCard: React.FC<Props> = ({
166165
const fetchData = async () => {
167166
if (token && userContext?.username) {
168167
try {
169-
const userOrgs = await getUserOrgs(
168+
const userOrgsRes = await getUserOrgs(
170169
token,
171170
userContext?.username.toString()
172171
);
173-
userContext?.setUserOrgs(userOrgs.data);
174-
setUserOrgs(userOrgs.data);
175-
172+
userContext?.setUserOrgs(userOrgsRes.data);
173+
setUserOrgs(userOrgsRes.data);
176174
} catch (e) {}
177175

178176
}
@@ -181,33 +179,28 @@ const ProjectCard: React.FC<Props> = ({
181179
fetchProjectData();
182180
fetchProjectMembers();
183181
fetchData();
184-
185-
186-
}, [userOrgs]);
182+
}, []);
187183

188184

189185
return (
190186
<div className='projectcard'>
191187

192188
<div className='pinDiv'>
193-
{pin&&<FaBookmark/>}
189+
{pin && <FaBookmark/>}
194190
</div>
195191
<h1>{projectName}</h1>
196192
<p>{project ? project.description : <></>}</p>
197193

198194
{(userContext?.userOrgs?.userOrgs[orgName].role === 'admin' ||
199195
userContext?.userOrgs?.userOrgs[orgName].role === 'manager') && (
200-
<>
196+
<div>
201197
<div
202198
className='workspace-popup-btn pointer'
203-
onClick={() => setShowPopUp(showPopUp ? false : true)}
199+
onClick={() => setShowPopUp(!showPopUp)}
204200
>
205-
<img
206-
src='https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcR51T-25-1BBmDvoLRWJYNK3P6AENpJBslAp9n_QDXRnA&usqp=CAU&ec=48665701'
207-
alt=''
208-
/>
201+
<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAGQAAABkCAYAAABw4pVUAAAACXBIWXMAAAsTAAALEwEAmpwYAAAB8ElEQVR4nO3bTS5DUQCG4S6C+N0PaSyEin2YGghiZguKnZTYhJ+aCPLK1TswEc7tPfKF90kkHbRNky85bm/zDgaSJEnSB2Ad2AWugGvgqf1rHl8Co+Y5s2erGmAROABe+N4bcAasOEmdMbaAB8o1rxk6Sr9jjIBXumteu+Mo/YyxOecYn4+wLUeZb4zVjsfUV+6BZUfpPsgp/TtykO6Xti8VBmnec81RygfZo56Rg5QPcllxkLGDlA9yW3GQGwcpH2RacZCpg5QP8lhxkAcHKR/kpuIgEwcpH+Si4iDnDlI+yG7FQbYdJOuL4aqDdAAcVxjk0DE6AlbaG4J9uQOWHGQOwIa338MAOz38QOU/8p5HGXY8vppjarPXD6MZYAHYB55/eDV14g9SvwBYa4+x5svjpL3vNW0fj5vjyUtbSZIkSfrDsA/JgH1IDuxDcmAfkgP7kBzYh2TBPiQH9iFZsA/Jgn1IFuxDsmAfkgX7kCzYh2TBPiQL9iFZsA/Jg31IFuxD8mAfkgf7kDzYh+TBPiQT9iGSJEmS9L9hH5IB+5Ac2IfkwD4kB/YhObAPyYJ9SA7sQ7JgH5IF+5As2IdkwT4kC/YhWbAPyYJ9SBbsQ7JgH5IH+5As2IfkwT4kD/YhebAPyYN9SCbsQyRJkjQo8Q6ntzHvrrTO1wAAAABJRU5ErkJggg==" />
209202
</div>
210-
<div className={showPopUp ? 'workspace-popup' : 'hide'}>
203+
{showPopUp && <div className={'workspace-popup'}>
211204
<div className='pin pointer' onClick={PinHandler}>
212205
{pin ? 'Unpin' : 'Pin'}
213206
</div>
@@ -223,8 +216,8 @@ const ProjectCard: React.FC<Props> = ({
223216
<div className='delete pointer' onClick={DeleteHandler}>
224217
Delete
225218
</div>
226-
</div>
227-
</>
219+
</div>}
220+
</div>
228221
)}
229222
<div className='projectcard-status'>
230223
<div>

frontend/src/features/workspace/components/projectCardContainer/index.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
import React, { useEffect, useState } from 'react';
1+
import React, { useEffect } from 'react';
22
import ProjectCard from '../projectCard';
33
import './index.scss';
44
import { Projects } from 'app/api/organization';
55
import { ProjectsGithubData } from 'app/api/githubData';
6-
import { useSelector } from 'react-redux';
76

87
interface Props {
98
weekly: boolean;

frontend/src/features/workspace/index.scss

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
}
2222

2323
.loader {
24-
width: 10px;
25-
height: 10px;
24+
width: 50px;
25+
height: 50px;
2626
position: absolute;
2727
top: 50%;
2828
left: 50%;

frontend/src/features/workspace/index.tsx

+7-5
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { ProjectsGithubData } from 'app/api/githubData';
1515
import { Contributors } from 'app/api/githubData';
1616
import loader from '../../app/assets/gifs/loader.gif';
1717
import UserContext from 'app/context/user/userContext';
18-
import { getUserOrgs } from 'app/api/user';
18+
import { UserOrgs, getUserOrgs } from 'app/api/user';
1919
import { useSelector } from 'react-redux';
2020

2121

@@ -30,6 +30,7 @@ const Workspace = () => {
3030
const [monthlyOrgRank, setMonthlyOrgRank] = useState<Contributors | null>(
3131
null
3232
);
33+
const [userOrgs, setUserOrgs] = useState<UserOrgs>({} as UserOrgs);
3334
const [weeklyOrgRank, setWeeklyOrgRank] = useState<Contributors | null>(null);
3435
const [monthlyOrgProjectsData, setMOnthyOrgProjectsData] =
3536
useState<ProjectsGithubData | null>(null);
@@ -68,14 +69,15 @@ const Workspace = () => {
6869
};
6970

7071
const fetchData = async () => {
72+
console.log(userContext?.username)
7173
if (token && userContext?.username) {
7274
try {
73-
const userOrgs = await getUserOrgs(
75+
const userOrgsRes = await getUserOrgs(
7476
token,
7577
userContext?.username.toString()
7678
);
77-
userContext?.setUserOrgs(userOrgs.data);
78-
79+
userContext?.setUserOrgs(userOrgsRes.data);
80+
setUserOrgs(userOrgsRes.data);
7981
} catch (e) {}
8082

8183
}
@@ -100,7 +102,7 @@ const Workspace = () => {
100102
fetchOrgProjects();
101103
fetchWeeklyData();
102104
fetchMonthlyData();
103-
}, [weekly,spaceName,searchValue]);
105+
}, [spaceName,searchValue]);
104106

105107
return (
106108
<>

0 commit comments

Comments
 (0)