Context
A major link rendering unification landed in 2024-12-16 (commit e547623), centralizing most link rendering into render_internal_link(), render_link_from_page(), and render_link_via_page() in crates/rari-doc/src/html/links.rs.
Current state
Most templates and sidebar rendering use the unified functions. However, several templates still build links inline:
templ/templs/subpages_with_summaries.rs — internal links without badgestempl/templs/glossarydisambiguation.rs — internal links without badgestempl/templs/xsltref.rs — static localized HTML stringstempl/templs/links/rfc.rs — external IETF linkstempl/templs/webext_all_examples.rs — external GitHub linkstempl/templs/web_ext_examples.rs — external GitHub linkstempl/templs/embeds/live_sample_link.rs — fragment-only links
Assessment
Some of these are reasonable exceptions (external URLs, fragment-only links, static HTML). The internal link cases (subpages_with_summaries, glossarydisambiguation) could potentially use the unified functions.
This is a low-priority cleanup — the current code works correctly.
Context
A major link rendering unification landed in 2024-12-16 (commit e547623), centralizing most link rendering into
render_internal_link(),render_link_from_page(), andrender_link_via_page()incrates/rari-doc/src/html/links.rs.Current state
Most templates and sidebar rendering use the unified functions. However, several templates still build links inline:
templ/templs/subpages_with_summaries.rs— internal links without badgestempl/templs/glossarydisambiguation.rs— internal links without badgestempl/templs/xsltref.rs— static localized HTML stringstempl/templs/links/rfc.rs— external IETF linkstempl/templs/webext_all_examples.rs— external GitHub linkstempl/templs/web_ext_examples.rs— external GitHub linkstempl/templs/embeds/live_sample_link.rs— fragment-only linksAssessment
Some of these are reasonable exceptions (external URLs, fragment-only links, static HTML). The internal link cases (
subpages_with_summaries,glossarydisambiguation) could potentially use the unified functions.This is a low-priority cleanup — the current code works correctly.