esa/agent_test.go at master · meain/esa · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
package main

import (
	"strings"
	"testing"

	"github.com/BurntSushi/toml"
)

func TestValidateAgent(t *testing.T) {
	tests := []struct {
		name        string
		agentConfig string
		wantErr     bool
		errContains string
	}{
		{
			name: "valid agent",
			agentConfig: `
name = "test-agent"
description = "A test agent"

[[functions]]
name = "hello"
description = "Say hello"
command = "echo Hello"
safe = true
`,
			wantErr: false,
		},
		{
			name: "function with missing name",
			agentConfig: `
name = "test-agent"
description = "A test agent"

[[functions]]
description = "Function without name"
command = "echo Hello"
`,
			wantErr:     true,
			errContains: "has no name",
		},
		{
			name: "function with missing command",
			agentConfig: `
name = "test-agent"
description = "A test agent"

[[functions]]
name = "hello"
description = "Function without command"
`,
			wantErr:     true,
			errContains: "has no command defined",
		},
		{
			name: "parameter with invalid type",
			agentConfig: `
name = "test-agent"
description = "A test agent"

[[functions]]
name = "hello"
description = "Function with invalid parameter type"
command = "echo Hello"

[[functions.parameters]]
name = "param1"
type = "invalid-type"
description = "A parameter with invalid type"
`,
			wantErr:     true,
			errContains: "invalid type",
		},
		{
			name: "invalid ask level",
			agentConfig: `
name = "test-agent"
ask = "invalid"
`,
			wantErr:     true,
			errContains: "invalid ask level",
		},
		{
			name: "valid ask level none",
			agentConfig: `
name = "test-agent"
ask = "none"
`,
			wantErr: false,
		},
		{
			name: "valid ask level all",
			agentConfig: `
name = "test-agent"
ask = "all"
`,
			wantErr: false,
		},
		{
			name: "duplicate function name",
			agentConfig: `
name = "test-agent"

[[functions]]
name = "hello"
description = "Say hello"
command = "echo Hello"

[[functions]]
name = "hello"
description = "Duplicate hello"
command = "echo World"
`,
			wantErr:     true,
			errContains: "duplicate function name",
		},
		{
			name: "duplicate parameter name",
			agentConfig: `
name = "test-agent"

[[functions]]
name = "hello"
description = "Say hello"
command = "echo {{a}} {{a}}"

[[functions.parameters]]
name = "a"
type = "string"
description = "first"

[[functions.parameters]]
name = "a"
type = "string"
description = "second"
`,
			wantErr:     true,
			errContains: "duplicate parameter name",
		},
		{
			name: "invalid timeout too high",
			agentConfig: `
name = "test-agent"

[[functions]]
name = "hello"
description = "Say hello"
command = "echo Hello"
timeout = 7200
`,
			wantErr:     true,
			errContains: "invalid timeout",
		},
		{
			name: "valid timeout",
			agentConfig: `
name = "test-agent"

[[functions]]
name = "hello"
description = "Say hello"
command = "echo Hello"
timeout = 300
`,
			wantErr: false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			var agent Agent
			if _, err := toml.Decode(tt.agentConfig, &agent); err != nil {
				t.Fatalf("Failed to decode agent config: %v", err)
			}

			_, err := validateAgent(agent)
			if (err != nil) != tt.wantErr {
				t.Errorf("validateAgent() error = %v, wantErr %v", err, tt.wantErr)
				return
			}

			if tt.wantErr && err != nil && tt.errContains != "" {
				if !strings.Contains(err.Error(), tt.errContains) {
					t.Errorf("validateAgent() error = %v, want error containing %q", err, tt.errContains)
				}
			}
		})
	}
}