Incorporate golangci-lint linter

Author: meap

.golangci.yml

@@ -0,0 +1,25 @@
+linters:
+  enable-all: true
+  disable:
+    - funlen
+    - gochecknoinits
+    - wsl
+    - exhaustruct
+    - execinquery
+    - exportloopref
+    - gomnd
+    - copyloopvar
+    - intrange
+    - gochecknoglobals
+    - wrapcheck
+    - err113
+    - depguard
+    - mnd
+    - lll
+    - cyclop
+    - revive
+    - godox
+    - gofumpt
+    - gosec
+    - contextcheck
+    - forbidigo

cmd/main.go

@@ -15,6 +15,7 @@
 package cmd
 
 import (
+	"errors"
 	"fmt"
 	"log"
 	"os"
@@ -25,22 +26,27 @@ import (
 	"runecs.io/v1/pkg/ecs"
 )
 
-var service string
+const (
+	defaultLastNumberOfTasks = 50
+	defaultLastDays          = 0
+)
 
 var rootCmd = &cobra.Command{
 	PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
 		commandsWithoutService := []string{"completion", "help", "list", "version"}
+		serviceValue := cmd.Flag("service").Value.String()
 
 		serviceRequired := true
 		for _, c := range commandsWithoutService {
 			if cmd.Name() == c {
 				serviceRequired = false
+
 				break
 			}
 		}
 
-		if serviceRequired && service == "" {
-			return fmt.Errorf("--service flag is required for this command")
+		if serviceRequired && serviceValue == "" {
+			return errors.New("--service flag is required for this command")
 		}
 
 		return nil
@@ -90,8 +96,8 @@ func init() {
 	}
 
 	pruneCmd.PersistentFlags().BoolP("dry-run", "", false, "dry run")
-	pruneCmd.PersistentFlags().IntP("keep-last", "", 50, "keep last N task definitions")
-	pruneCmd.PersistentFlags().IntP("keep-days", "", 0, "keep task definitions older than N days")
+	pruneCmd.PersistentFlags().IntP("keep-last", "", defaultLastNumberOfTasks, "keep last N task definitions")
+	pruneCmd.PersistentFlags().IntP("keep-days", "", defaultLastDays, "keep task definitions older than N days")
 	rootCmd.AddCommand(pruneCmd)
 
 	////////////
@@ -104,7 +110,7 @@ func init() {
 		DisableFlagsInUseLine: true,
 		PreRunE: func(cmd *cobra.Command, args []string) error {
 			if dockerImageTag == "" {
-				return fmt.Errorf("--image-tag flag is required")
+				return errors.New("--image-tag flag is required")
 			}
 
 			return nil
@@ -205,18 +211,19 @@ func init() {
 	rootCmd.AddCommand(completionCmd)
 
 	rootCmd.CompletionOptions.DisableDefaultCmd = true
-	rootCmd.PersistentFlags().StringVar(&service, "service", "", "service name (cluster/service)")
+	rootCmd.PersistentFlags().String("service", "", "service name (cluster/service)")
 }
 
 func initService() *ecs.Service {
 	svc := ecs.Service{}
+	serviceValue := rootCmd.Flag("service").Value.String()
 
-	parsed := strings.Split(service, "/")
+	parsed := strings.Split(serviceValue, "/")
 	if len(parsed) == 2 {
 		svc.Cluster = parsed[0]
 		svc.Service = parsed[1]
-	} else if service != "" {
-		log.Fatalf("Invalid service name %s\n", service)
+	} else if serviceValue != "" {
+		log.Fatalf("Invalid service name %s\n", serviceValue)
 	}
 
 	validate := validator.New()

main.go

@@ -14,7 +14,9 @@
 // Package herrors contains common Hugo errors and error related utilities.
 package main
 
-import "runecs.io/v1/cmd"
+import (
+	"runecs.io/v1/cmd"
+)
 
 var (
 	version   = "No version provided"

pkg/ecs/deploy.go

@@ -2,6 +2,7 @@ package ecs
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"log"
 	"strings"
@@ -20,7 +21,7 @@ func (s *Service) cloneTaskDef(ctx context.Context, dockerImageTag string, svc *
 	// Load the latest task definition.
 	latestDef, err := s.latestTaskDefinition(ctx, svc)
 	if err != nil {
-		return "", nil
+		return "", err
 	}
 
 	response, err := svc.DescribeTaskDefinition(ctx, &ecs.DescribeTaskDefinitionInput{
@@ -32,7 +33,7 @@ func (s *Service) cloneTaskDef(ctx context.Context, dockerImageTag string, svc *
 	}
 
 	if len(response.TaskDefinition.ContainerDefinitions) > 1 {
-		return "", fmt.Errorf("multiple container definitions in a single task are not supported")
+		return "", errors.New("multiple container definitions in a single task are not supported")
 	}
 
 	newDef := &ecs.RegisterTaskDefinitionInput{}

pkg/ecs/exec.go

@@ -116,10 +116,10 @@ func (s *Service) Execute(cmd []string, wait bool, dockerImageTag string) {
 		if err != nil {
 			log.Fatalln(err)
 		}
-		log.Printf("New task definition %s is created", taskDef)
+		fmt.Printf("New task definition %s is created", taskDef)
 	} else {
 		taskDef = sdef.TaskDef
-		log.Printf("The task definition %s is used", taskDef)
+		fmt.Printf("The task definition %s is used", taskDef)
 	}
 
 	output, err := svc.RunTask(ctx, &ecs.RunTaskInput{
@@ -166,6 +166,6 @@ func (s *Service) Execute(cmd []string, wait bool, dockerImageTag string) {
 			time.Sleep(6 * time.Second)
 		}
 
-		log.Printf("task %s finished", *executedTask.TaskArn)
+		fmt.Printf("task %s finished", *executedTask.TaskArn)
 	}
 }

pkg/ecs/list.go

@@ -12,7 +12,8 @@ import (
 func (s *Service) listClusters(ctx context.Context, svc *ecs.Client) []string {
 	response, err := svc.ListClusters(ctx, &ecs.ListClustersInput{})
 	if err != nil {
-		log.Println(fmt.Errorf("failed to list clusters. (%v)", err))
+		log.Println(fmt.Errorf("failed to list clusters. (%w)", err))
+
 		return []string{}
 	}
 
@@ -25,7 +26,8 @@ func (s *Service) listServices(ctx context.Context, svc *ecs.Client, cluster str
 	})
 
 	if err != nil {
-		log.Println(fmt.Errorf("failed to list services in cluster %s. (%v)", cluster, err))
+		log.Println(fmt.Errorf("failed to list services in cluster %s. (%w)", cluster, err))
+
 		return []string{}
 	}
 
@@ -44,6 +46,7 @@ func (s *Service) List() {
 
 	svc := ecs.NewFromConfig(cfg)
 	clusters := s.listClusters(ctx, svc)
+
 	for _, clusterArn := range clusters {
 		services := s.listServices(ctx, svc, clusterArn)
 		for _, serviceArn := range services {
@@ -53,6 +56,7 @@ func (s *Service) List() {
 	}
 
 	fmt.Println()
+
 	for _, link := range links {
 		fmt.Println(link)
 	}

pkg/ecs/logs.go

@@ -9,24 +9,28 @@ import (
 	"github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs"
 )
 
-func (s *Service) printProcessLogs(ctx context.Context, logGroupname string, logStreamPrefix string, taskArn string, name string) error {
+func (s *Service) printProcessLogs(
+	ctx context.Context, logGroupname string,
+	logStreamPrefix string,
+	taskArn string,
+	name string) error {
 	log.Printf("Loading logs for %s: %s", logGroupname, taskArn)
 
 	cfg, err := s.initCfg()
 	if err != nil {
-		return fmt.Errorf("failed to initialize AWS configuration. (%v)", err)
+		return fmt.Errorf("failed to initialize AWS configuration. (%w)", err)
 	}
 
-	processId := extractProcessId(taskArn)
+	processID := extractProcessID(taskArn)
 	client := cloudwatchlogs.NewFromConfig(cfg)
 
 	output, err := client.FilterLogEvents(ctx, &cloudwatchlogs.FilterLogEventsInput{
 		LogGroupName:   aws.String(logGroupname),
-		LogStreamNames: []string{fmt.Sprintf("%s/%s/%s", logStreamPrefix, name, processId)},
+		LogStreamNames: []string{fmt.Sprintf("%s/%s/%s", logStreamPrefix, name, processID)},
 	})
 
 	if err != nil {
-		return fmt.Errorf("failed to filter log events (%v)", err)
+		return fmt.Errorf("failed to filter log events (%w)", err)
 	}
 
 	for _, event := range output.Events {

pkg/ecs/prune.go

@@ -37,6 +37,7 @@ func (s *Service) deregisterTaskFamily(ctx context.Context, family string, keepL
 
 			if err != nil {
 				log.Printf("Failed to describe task definition %s. (%v)\n", def, err)
+
 				continue
 			}
 
@@ -46,11 +47,13 @@ func (s *Service) deregisterTaskFamily(ctx context.Context, family string, keepL
 			if keep < keepLast {
 				fmt.Println("Task definition", def, "created", diffInDays, "days ago is skipped.")
 				keep++
+
 				continue
 			}
 
 			if diffInDays < keepDays {
 				fmt.Println("Task definition", def, "created", diffInDays, "days ago is skipped.")
+
 				continue
 			}
 
@@ -60,6 +63,7 @@ func (s *Service) deregisterTaskFamily(ctx context.Context, family string, keepL
 				_, err := svc.DeregisterTaskDefinition(ctx, &ecs.DeregisterTaskDefinitionInput{TaskDefinition: &def})
 				if err != nil {
 					fmt.Printf("Deregistering the task definition %s failed. (%v)\n", def, err)
+
 					continue
 				}
 
@@ -76,6 +80,7 @@ func (s *Service) deregisterTaskFamily(ctx context.Context, family string, keepL
 
 	if dryRun {
 		fmt.Printf("Total of %d task definitions. Will delete %d definitions.", totalCount, deleted)
+
 		return
 	}
 

pkg/ecs/restart.go

@@ -24,7 +24,8 @@ func (s *Service) stopAll(ctx context.Context, client *ecs.Client) error {
 			Task:    &taskArn,
 		})
 		if err != nil {
-			log.Println(fmt.Errorf("failed to stop task %s. (%v)", taskArn, err))
+			log.Println(fmt.Errorf("failed to stop task %s. (%w)", taskArn, err))
+
 			continue
 		}
 

pkg/ecs/revision.go

@@ -94,6 +94,7 @@ func (s *Service) printRevisions(ctx context.Context, familyPrefix string, lastR
 
 			if err != nil {
 				log.Printf("Failed to describe task definition %s. (%v)\n", def, err)
+
 				continue
 			}
 

pkg/ecs/service.go

@@ -24,6 +24,10 @@ import (
 	"github.com/aws/aws-sdk-go-v2/service/ecs/types"
 )
 
+const (
+	defaultNumberOfRetries = 10
+)
+
 // ECS parameters that are used to run jobs.
 type Service struct {
 	Cluster string `mapstructure:"CLUSTER"`
@@ -46,7 +50,7 @@ func (s *Service) loadService(ctx context.Context, svc *ecs.Client) (types.Servi
 func (s *Service) initCfg() (aws.Config, error) {
 	configFunctions := []func(*config.LoadOptions) error{
 		config.WithRetryer(func() aws.Retryer {
-			return retry.AddWithMaxAttempts(retry.NewStandard(), 10)
+			return retry.AddWithMaxAttempts(retry.NewStandard(), defaultNumberOfRetries)
 		}),
 	}
 

pkg/ecs/utils.go

@@ -2,7 +2,7 @@ package ecs
 
 import "strings"
 
-func extractProcessId(taskArn string) string {
+func extractProcessID(taskArn string) string {
 	lastSlashIndex := strings.LastIndex(taskArn, "/")
 	if lastSlashIndex != -1 {
 		return taskArn[lastSlashIndex+1:]