Skip to content

Commit 2e024f1

Browse files
committed
chore: MR feedback
1 parent d0f1fc4 commit 2e024f1

File tree

7 files changed

+9
-74
lines changed

7 files changed

+9
-74
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Setup Node.js
2020
uses: actions/setup-node@v3
2121
with:
22-
node-version: 22
22+
node-version: 18
2323

2424
- name: Check Yarn Version
2525
run: yarn --version

.github/workflows/publish-canary.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Setup Node.js
2020
uses: actions/setup-node@v3
2121
with:
22-
node-version: 22
22+
node-version: 18
2323
registry-url: "https://registry.npmjs.org"
2424

2525
- name: Install dependencies

.github/workflows/publish.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- name: Setup Node.js
2424
uses: actions/setup-node@v3
2525
with:
26-
node-version: 22
26+
node-version: 18
2727
registry-url: "https://registry.npmjs.org"
2828

2929
- name: Install dependencies

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@
3535
],
3636
"version": "0.17.1",
3737
"engines": {
38-
"node": ">=22.0.0"
38+
"node": ">=18.18"
3939
}
4040
}

recipes/react-router/app/entry.server.tsx

-68
This file was deleted.

recipes/react-router/app/root.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@ export function ErrorBoundary({ error }: Route.ErrorBoundaryProps) {
5959
}
6060

6161
return (
62-
<main className="pt-16 p-4 container mx-auto">
62+
<main>
6363
<h1>{message}</h1>
6464
<p>{details}</p>
6565
{stack && (
66-
<pre className="w-full p-4 overflow-x-auto">
66+
<pre>
6767
<code>{stack}</code>
6868
</pre>
6969
)}

recipes/react-router/package.json

+3
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,8 @@
2929
"typescript": "^5.7.2",
3030
"vite": "^5.4.11",
3131
"vite-tsconfig-paths": "^5.1.4"
32+
},
33+
"engines": {
34+
"node": ">=20.0.0"
3235
}
3336
}

0 commit comments

Comments
 (0)