fix(canvas): add maxWidth and safe initial height styles to Canvas.
#929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@think-carlo is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisvxd
requested changes
Apr 3, 2025
There was a problem hiding this comment.
Thanks @think-carlo! Unfortunately this breaks the behaviour for me.
Observed behaviour
Canvas is artificially constrained
Expected behaviour
Canvas receives the full width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use the
Puckcomponent within a legacy Javascript application I work with, and found that when mounting the component theCanvaswas broken on the initial render. For some reason the initial side-effects that should appropriately configurezoomConfigweren't throwing and sozoomConfig.rootHeight, i.e. the height of canvas, was set to0.Likewise, while the width should have been set to
1280pxper my viewport (and was showing as such in the styles within Inspector Tools), it still seemed like the canvas was breaking out of the parent container.These two changes fixed the issue on my end, and should prevent them from happening for others!
maxWidthto100%we avoid breaking out of the parent regardless of what we programmatically need to set the width to by viewport.zoomConfig.rootHeightis falsey, we can set it to"auto", in which case it will simply fill its available space on initial render and then re-zoomed on window resize events.