Skip to content

Make sure extra module imports are optional #8

@gbottari

Description

@gbottari

Prerequisites

  • Can you reproduce the problem?
  • Are you running the latest version?
  • Did you check the documentation?
  • Did you perform a cursory search?

For more information, see the contributing guide.

Description

All extra modules in pyproject.toml (section [tool.poetry.extras]) must be truly optional. For instance, PollyTTS requires boto3. If a user doesn't have boto3 installed, they should be able to use other modules (e.g. MicrosoftTTS) without needing to install boto3.

The project already works with this in mind. However, there are no tests for this yet. Maybe we can use importlib to remove an engine dependency and check if importing the TTS engine (without instantiating it) works.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions