Skip to content

Commit d9a6bd1

Browse files
committed
CC-6981: Resolve default value updating when migrating from existing user
(cherry picked from commit d1a2822)
1 parent ade1959 commit d9a6bd1

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

iMEGA/Camera uploads/UploadManagers/CameraUploadManager+Settings.m

+5-5
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,18 @@ + (BOOL)isCameraUploadEnabled {
3434
}
3535

3636
+ (void)setCameraUploadEnabled:(BOOL)cameraUploadEnabled {
37-
[self setMigratedToCameraUploadsV2:YES];
3837
[NSUserDefaults.standardUserDefaults setBool:cameraUploadEnabled forKey:IsCameraUploadsEnabledKey];
3938
[self configDefaultSettingsIfNeededForCameraUpload];
4039
[self configDefaultSharedAlbumsAndSyncedAlbumsSettingsIfNeeded];
40+
[self setMigratedToCameraUploadsV2:YES];
4141
}
4242

4343
+ (void)configDefaultSettingsIfNeededForCameraUpload {
4444
if (![self isCameraUploadEnabled]) {
45+
// Reset default value for VideoUploadsEnabled to YES, so that next time user turns on it will be the default
46+
if([NSUserDefaults.standardUserDefaults objectForKey:IsVideoUploadsEnabledKey] == nil) {
47+
[self setVideoUploadEnabled:YES];
48+
}
4549
return;
4650
}
4751

@@ -56,10 +60,6 @@ + (void)configDefaultSettingsIfNeededForCameraUpload {
5660
if ([NSUserDefaults.standardUserDefaults objectForKey:UploadAllBurstAssetsKey] == nil) {
5761
[self setUploadAllBurstPhotos:YES];
5862
}
59-
60-
if ([NSUserDefaults.standardUserDefaults objectForKey:IsVideoUploadsEnabledKey] == nil) {
61-
[self setVideoUploadEnabled:YES];
62-
}
6363
}
6464

6565
+ (void)configDefaultSharedAlbumsAndSyncedAlbumsSettingsIfNeeded {

iMEGA/My Account/Settings/Camera Uploads/CameraUploadsTableViewController.m

+4-3
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,10 @@ - (void)viewDidLoad {
6060

6161
if (self.isPresentedModally) {
6262
self.navigationItem.rightBarButtonItem = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemDone target:self action:@selector(modalDialogDoneButtonTouched)];
63-
if (!CameraUploadManager.hasMigratedToCameraUploadsV2) {
64-
[CameraUploadManager configDefaultSettingsForCameraUploadV2];
65-
}
63+
}
64+
65+
if (!CameraUploadManager.hasMigratedToCameraUploadsV2) {
66+
[CameraUploadManager configDefaultSettingsForCameraUploadV2];
6667
}
6768

6869
[self updateAppearance];

0 commit comments

Comments
 (0)