Commit 44f22cf
refactor(dynacell): replace microssim dep with cubic.metrics.MicroMS3IM
cubic 0.7.0a4 ships a native MicroSSIM / MicroMS3IM implementation,
making the upstream juglab/microssim git pin redundant. Swap dynacell's
calculate_microssim to lazy-import `cubic.metrics.MicroMS3IM` so the
existing test stubs in `test_evaluation_metrics.py` (which fake
`cubic.metrics` at module load) keep working unchanged.
Notes on the wiring:
- Top-of-file `from microssim import MicroMS3IM` (try/except shim) and
the `_require_microssim` helper are removed; metrics.py no longer
references upstream microssim.
- `_require_cubic()` is NOT called from `calculate_microssim`. That
helper requires the GPU stack (cupy, cucim) and would regress
CPU-only eval runs that only need MicroMS3IM; the lazy import alone
is the gate.
- The cubic.metrics stub gains `MicroMS3IM = object` so future tests
exercising calculate_microssim won't need to re-extend it.
Lock + workspace:
- `applications/dynacell/pyproject.toml` bumps `cubic==0.7.0a2` →
`cubic==0.7.0a4` and drops the microssim git pin from
`optional-dependencies.eval`.
- Workspace `[tool.uv.sources]` carries a temporary git override
pointing cubic at the 0.7.0a4 release commit until PyPI catches up.
Remove the override after the cubic release lands on PyPI.
- `uv.lock` regenerated; no more `juglab/microssim` references.
README sweep: drop microssim from the optional-deps shortlist.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 74085e0 commit 44f22cf
6 files changed
Lines changed: 13 additions & 41 deletions
File tree
- applications/dynacell
- src/dynacell/evaluation
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
| 253 | + | |
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | 6 | | |
12 | 7 | | |
13 | 8 | | |
| |||
24 | 19 | | |
25 | 20 | | |
26 | 21 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | 22 | | |
33 | 23 | | |
34 | 24 | | |
| |||
259 | 249 | | |
260 | 250 | | |
261 | 251 | | |
262 | | - | |
263 | | - | |
| 252 | + | |
| 253 | + | |
264 | 254 | | |
265 | 255 | | |
266 | 256 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | 16 | | |
20 | 17 | | |
21 | 18 | | |
22 | 19 | | |
23 | 20 | | |
24 | 21 | | |
25 | 22 | | |
| 23 | + | |
26 | 24 | | |
27 | 25 | | |
28 | 26 | | |
| |||
31 | 29 | | |
32 | 30 | | |
33 | 31 | | |
34 | | - | |
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
61 | 66 | | |
62 | 67 | | |
63 | 68 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments