Skip to content

Commit f64ed40

Browse files
edyoshikunCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent 6f37d55 commit f64ed40

2 files changed

Lines changed: 10 additions & 7 deletions

File tree

  • applications/dynaclr/configs/training/slurm
  • packages/viscy-utils/src/viscy_utils

applications/dynaclr/configs/training/slurm/train.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,7 @@ WANDB_ID_FILE="${RUN_DIR}/.wandb_run_id"
8383
if [ -z "${WANDB_RUN_ID:-}" ]; then
8484
if [ -f "${WANDB_ID_FILE}" ]; then
8585
WANDB_RUN_ID="$(cat "${WANDB_ID_FILE}")"
86-
else
87-
WANDB_RUN_ID="$(python -c 'import secrets; print(secrets.token_hex(4))')"
88-
echo "${WANDB_RUN_ID}" > "${WANDB_ID_FILE}"
86+
WANDB_RUN_ID="$(uv run --project "$WORKSPACE_DIR" python -c 'import secrets; print(secrets.token_hex(4))')"
8987
fi
9088
fi
9189

packages/viscy-utils/src/viscy_utils/cli.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def _configure_slurm_requeue(config: Namespace, subcommand: str | None) -> None:
8787
root = config[subcommand] if subcommand is not None else config
8888
if not isinstance(root, Namespace):
8989
return
90-
if not root.get("slurm_auto_requeue", False):
90+
if not config.get("slurm_auto_requeue", False):
9191
return
9292
if not SLURMEnvironment.detect():
9393
return
@@ -98,10 +98,15 @@ def _configure_slurm_requeue(config: Namespace, subcommand: str | None) -> None:
9898
if plugins is None:
9999
plugins = []
100100
elif not isinstance(plugins, list):
101-
plugins = [plugins]
102-
if any(isinstance(p, SLURMEnvironment) for p in plugins):
101+
if any(
102+
isinstance(p, SLURMEnvironment)
103+
or (isinstance(p, Namespace) and p.get("class_path") == "lightning.pytorch.plugins.environments.SLURMEnvironment")
104+
for p in plugins
105+
):
103106
return
104-
plugins.append(SLURMEnvironment(auto_requeue=True, requeue_signal=signal.SIGUSR1))
107+
plugins.append(
108+
lazy_instance(SLURMEnvironment, auto_requeue=True, requeue_signal=signal.SIGUSR1.value)
109+
)
105110
trainer["plugins"] = plugins
106111

107112

0 commit comments

Comments
 (0)