-
Notifications
You must be signed in to change notification settings - Fork 17
Update nodejs runtime to node20 #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Build succeeded: |
meili-bors bot
added a commit
that referenced
this pull request
Apr 15, 2025
200: Move typescript to dependencies r=curquiza a=Strift ## why - fix build to allow deploying v0.3.0 ## how - move `typescript` to dependencies note: Google is unclear about it, but it seems that dev dependencies are not installed, as I see other projects including typescript as part of their dependencies (see [stripe-firebase-extensions](https://github.com/invertase/stripe-firebase-extensions/blob/next/firestore-stripe-invoices/functions/package.json)) ``` firebase ext:dev:upload meilisearch/firestore-meilisearch Extension: meilisearch/firestore-meilisearch State: Published Latest Version: 0.1.12 Version in Extensions Hub: 0.1.12 Source in GitHub: Local source ? Enter the GitHub repo URI where this extension's source code is located: https://github.com/meilisearch/firestore-meilisearch ? Enter this extension's root directory in the repo (defaults to previous root if set): / ? Enter the commit hash, branch, or tag name to build from in the repo: HEAD Validating source code at https://github.com/meilisearch/firestore-meilisearch/tree/HEAD/... ? Choose the release stage: Stable (0.3.0, automatically sent for review) You are about to upload a new version to Firebase's registry of extensions. Extension: meilisearch/firestore-meilisearch Version: 0.3.0 (automatically sent for review) Source: https://github.com/meilisearch/firestore-meilisearch/tree/HEAD/ Release notes: Breaking: Update nodejs runtime to node20 (#179) `@brunoocasali` Once an extension version is uploaded, it becomes installable by other users and cannot be changed. If you wish to make changes after uploading, you will need to upload a new version. ? Do you wish to continue? Yes ✖ Uploading meilisearch/[email protected]... Error: generic::invalid_argument: failed to build ExtensionVersion "publishers/meilisearch/extensions/firestore-meilisearch/versions/0.3.0" source: failed to build NPM package: Pulling image: us-docker.pkg.dev/extensions-builder-prod/extensions-builder/builder Using default tag: latest latest: Pulling from extensions-builder-prod/extensions-builder/builder 3153aa388d02: Pulling fs layer ef57089adb55: Pulling fs layer 792066ee936e: Pulling fs layer 9ed9b1b2bc55: Pulling fs layer 9ed9b1b2bc55: Waiting 3153aa388d02: Verifying Checksum 3153aa388d02: Download complete 9ed9b1b2bc55: Verifying Checksum 9ed9b1b2bc55: Download complete ef57089adb55: Download complete 792066ee936e: Verifying Checksum 792066ee936e: Download complete 3153aa388d02: Pull complete ef57089adb55: Pull complete 792066ee936e: Pull complete 9ed9b1b2bc55: Pull complete Digest: sha256:3f9b4d6c7b66b5859a7d894cd23d8ddcf78a23dcee2959a79ef99a5c8c41b81b Status: Downloaded newer image for us-docker.pkg.dev/extensions-builder-prod/extensions-builder/builder:latest us-docker.pkg.dev/extensions-builder-prod/extensions-builder/builder:latest Now using node v20.4.0 (npm v9.7.2) > [email protected] build > tsc sh: 1: tsc: not found ``` Co-authored-by: Strift <[email protected]>
meili-bors bot
added a commit
that referenced
this pull request
Apr 17, 2025
202: Remove jest types from tsconfig r=curquiza a=Strift # Pull Request ## Related issue Error when publishing the extension ``` Extension: meilisearch/firestore-meilisearch State: Published Latest Version: 0.1.12 Version in Extensions Hub: 0.1.12 Source in GitHub: Local source ? Enter the GitHub repo URI where this extension's source code is located: https://github.com/meilisearch/firestore-meilisearch ? Enter this extension's root directory in the repo (defaults to previous root if set): / ? Enter the commit hash, branch, or tag name to build from in the repo: HEAD Validating source code at https://github.com/meilisearch/firestore-meilisearch/tree/HEAD/... ? Choose the release stage: Stable (0.3.0, automatically sent for review) You are about to upload a new version to Firebase's registry of extensions. Extension: meilisearch/firestore-meilisearch Version: 0.3.0 (automatically sent for review) Source: https://github.com/meilisearch/firestore-meilisearch/tree/HEAD/ Release notes: Breaking: Update nodejs runtime to node20 (#179) `@brunoocasali` Once an extension version is uploaded, it becomes installable by other users and cannot be changed. If you wish to make changes after uploading, you will need to upload a new version. ? Do you wish to continue? Yes ✖ Uploading meilisearch/[email protected]... Error: generic::invalid_argument: failed to build ExtensionVersion "publishers/meilisearch/extensions/firestore-meilisearch/versions/0.3.0" source: failed to build NPM package: Pulling image: us-docker.pkg.dev/extensions-builder-prod/extensions-builder/builder Using default tag: latest latest: Pulling from extensions-builder-prod/extensions-builder/builder 3153aa388d02: Pulling fs layer ef57089adb55: Pulling fs layer 792066ee936e: Pulling fs layer 9ed9b1b2bc55: Pulling fs layer 9ed9b1b2bc55: Waiting 3153aa388d02: Verifying Checksum 3153aa388d02: Download complete 9ed9b1b2bc55: Verifying Checksum 9ed9b1b2bc55: Download complete ef57089adb55: Download complete 792066ee936e: Verifying Checksum 792066ee936e: Download complete 3153aa388d02: Pull complete ef57089adb55: Pull complete 792066ee936e: Pull complete 9ed9b1b2bc55: Pull complete Digest: sha256:3f9b4d6c7b66b5859a7d894cd23d8ddcf78a23dcee2959a79ef99a5c8c41b81b Status: Downloaded newer image for us-docker.pkg.dev/extensions-builder-prod/extensions-builder/builder:latest us-docker.pkg.dev/extensions-builder-prod/extensions-builder/builder:latest Now using node v20.4.0 (npm v9.7.2) > [email protected] build > tsc error TS2688: Cannot find type definition file for 'jest'. The file is in the program because: Entry point of type library 'jest' specified in compilerOptions ``` ## What does this PR do? - Move `jest` types to `functions/__tests__/tsconfig.json` - Fix ensuing type errors ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Strift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178