Skip to content

Adds embeddings database metrics to stats #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meili-bors merged 1 commit into from
May 1, 2025
Merged

Adds embeddings database metrics to stats #620

meili-bors merged 1 commit into from
May 1, 2025

Conversation

@pratts
Copy link

@pratts pratts commented Mar 30, 2025

Pull Request

Related issue

Fixes #614

What does this PR do?

  • Adds indexes.INDEXNAME.numberOfEmbeddedDocuments in SDK responses
  • Adds indexes.INDEXNAME.numberOfEmbeddings in SDK responses

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza requested a review from ja7ad April 1, 2025 08:30
@codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (e56172a) to head (0acfffc).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files          14       14           
  Lines        2854     2854           
=======================================
  Hits         2459     2459           
  Misses        283      283           
  Partials      112      112

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

curquiza
curquiza approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza curquiza added the enhancement New feature or request label May 1, 2025
@meili-bors
Copy link
Contributor

meili-bors bot commented May 1, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit 76ee06d into meilisearch:main May 1, 2025
6 checks passed
@pratts pratts deleted the 614-Add-embbedings-database-metrics-to-stats branch May 2, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza curquiza approved these changes

@ja7ad ja7ad Awaiting requested review from ja7ad

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v1.13] Add embbedings database metrics to stats

2 participants

@pratts @curquiza