Skip to content

Commit 82151b3

Browse files
committed
docs: the two settings the reference called broken now work
MEI-139 and MEI-140 landed after the reference that documented them as defects, so three passages described bugs the code no longer has. The first-post moderation warning and the promotion warning in the organiser guide are removed outright — both said "does not currently", and it now does. The groups reference kept its paragraph on the no-demotion guard, rewritten to say what the guard does today: a group it does not rank is not compared at all, so a rule into a group you made runs normally, and a move between two ranked groups in the wrong direction is still refused. The line worth keeping from it is that the guard was never what protected staff — a member in a protected group is skipped before any rank is considered.
1 parent 4e63f70 commit 82151b3

3 files changed

Lines changed: 13 additions & 28 deletions

File tree

docs/antispam.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,10 @@ pre-authentication limits below.
2727
| Hidden-field trap | `antispam.honeypot` | On | Bots that fill every field | Nothing. Leave it on. |
2828
| Minimum fill time | `antispam.min_form_seconds` | 3 seconds | Instant submissions | Occasionally somebody with a password manager. Keep it to a few seconds. |
2929
| A question challenge | `antispam.captcha_mode` | Off | Scripted registration | A moment, every time. Switch it on when you have a problem. |
30-
| Hold a new member's first posts | `antispam.moderate_first_posts` | Off | Most forum spam — but see the warning below | One wait per genuine new member. |
30+
| Hold a new member's first posts | `antispam.moderate_first_posts` | Off | Most forum spam | One wait per genuine new member. |
3131
| Hourly limits | `antispam.*_per_hour` | Off | A night's work by one script | Nothing, set sensibly. |
3232
| The four pre-auth limits | see below | On | Signup floods, reset-mail bombing, password spraying | Nothing. |
3333

34-
> [!WARNING]
35-
> **`antispam.moderate_first_posts` does not currently hold anything.**
36-
> The check asks the authorizer a per-forum question without naming a
37-
> forum; the error that follows is swallowed and the answer defaults to
38-
> *not held*, so an ordinary member's first posts go straight up whatever
39-
> the threshold says. Use the forum's own **Hold new threads / new
40-
> replies for approval** switches, or the per-group *requires approval*
41-
> rows in [the matrix](./forums.md#reading-the-matrix), until this is
42-
> fixed.
43-
4434
## The registration questions
4535

4636
Set **Registration challenge** to *Ask a question* and `/admin/antispam`

docs/groups.md

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,18 @@ primary group is Banned, Administrators or Super moderators are skipped
213213
whatever a rule says. A promoted member keeps every secondary membership
214214
they held.
215215

216-
> [!IMPORTANT]
217-
> **The no-demotion guard reads a fixed table of group ranks**, and only
218-
> Guests, Registered, Super moderators and Administrators are in it.
219-
> Every other group — including one you made — ranks as `0`, so a rule
220-
> promoting members *out of Registered* into a group of your own is
221-
> passed over as a demotion and moves nobody. The preview runs the same
222-
> evaluation as the task, so it reports this honestly: if the preview
223-
> says nobody would be promoted by a rule you believe is right, this is
224-
> the reason.
216+
The no-demotion guard reads a fixed table of ranks holding Guests,
217+
Registered, Super moderators and Administrators. **A group it does not
218+
rank — including every group you make — is not compared at all**, so a
219+
rule promoting members out of Registered into one of your own groups runs
220+
normally. What the guard still refuses is a move between two groups it
221+
does rank, in the wrong direction. The protection that matters does not
222+
depend on the table anyway: a member whose primary group is Banned,
223+
Administrators or Super moderators is skipped before any rank is
224+
considered.
225+
226+
The preview runs the same evaluation as the task, so it always reports
227+
what the run will do.
225228

226229
**Run it** applies exactly what the preview lists, asks for your password
227230
again, and records the count in the admin log. Deleting the target group

docs/organiser-guide.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -345,14 +345,6 @@ does not disturb that. The hourly task works through the membership
345345
board bigger than that a newly earned promotion arrives within a few
346346
runs rather than on the very next one.
347347

348-
> [!WARNING]
349-
> A rule promoting members out of **Registered** into a group of your own
350-
> is currently refused by the safeguard that stops promotions demoting
351-
> anybody, and moves nobody. The preview says so honestly — if it reports
352-
> no members for a rule you believe is right, read
353-
> [Groups and promotions § Promotions](./groups.md#promotions) before
354-
> changing the rule.
355-
356348
### When somebody steps back
357349

358350
Accounts belong to people; roles are group memberships. That one

0 commit comments

Comments
 (0)