Skip to content

Commit a1c387f

Browse files
meizhong986claude
andcommitted
fix(upgrade): Remove NeMo from upgrade path
NeMo toolkit removed from TORCH_DEPENDENT_PACKAGES due to: - @main branch is unstable, breaks reproducibility - 500+ MB download with timeout risk - CUDA version drift could break existing setup - Pip resolver conflicts can hang or fail upgrades Users who need NeMo can install manually after upgrade: pip install nemo_toolkit[asr] Based on expert code review recommendations (GPT flagged as critical). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 8f42f99 commit a1c387f

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

installer/upgrade_whisperjav.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,14 @@
9696

9797
# Dependencies that have torch as a requirement - installed with constraints
9898
# to prevent pip from reinstalling CPU-only torch
99-
TORCH_DEPENDENT_PACKAGES = [
100-
"nemo_toolkit[asr] @ git+https://github.com/NVIDIA/NeMo.git@main",
101-
]
99+
# NOTE: NeMo removed from upgrade path due to:
100+
# - @main branch is unstable, breaks reproducibility
101+
# - 500+ MB download with timeout risk
102+
# - CUDA version drift could break existing setup
103+
# - Pip resolver conflicts can hang or fail upgrades
104+
# Users who need NeMo should install manually after upgrade:
105+
# pip install nemo_toolkit[asr]
106+
TORCH_DEPENDENT_PACKAGES = []
102107

103108
# Files to preserve during upgrade (user data)
104109
PRESERVE_PATTERNS = [

0 commit comments

Comments
 (0)