Skip to content

Commit cce5bfd

Browse files
Merge pull request #16 from philiplambok-mekari/KRED-2061
KRED-2061: Improve regex logic in filtering logs
2 parents 5b347b2 + d9cf5d9 commit cce5bfd

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

.ruby-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
2.7.2

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ midtrans = MidtransApi::Client.new(
2929
server_key: 'YOUR-SERVER-KEY',
3030
sandbox: true|false,
3131
notification_url: 'https://example.com/callback',
32+
filtered_logs: %[word1 word2],
33+
logger: Logger.new(STDOUT),
3234
timeout: 30 # by default will be 60 (seconds)
3335
)
3436

lib/midtrans_api/client.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ def initialize(options = {})
5959
filtered_logs = options[:filtered_logs]
6060
if filtered_logs.respond_to?(:each)
6161
filtered_logs.each do |filter|
62-
log.filter(%r{(#{filter}=)([\w+-.?@:/]+)}, '\1[FILTERED]')
63-
log.filter(%r{(#{filter}":")([\w+-.?@:/]+)}, '\1[FILTERED]')
64-
log.filter(%r{(#{filter}":)([\w+-.?@:/]+)}, '\1[FILTERED]')
62+
log.filter(/(#{filter}":\s*")(.*?)(")/i, '\1[FILTERED]\3')
63+
log.filter(/(#{filter}":\s*)(\d+(?:\.\d+)?|true|false)/i, '\1[FILTERED]')
64+
log.filter(/(#{filter}":\s*)(\[.*?\])/i, '\1[FILTERED]')
6565
end
6666
end
6767
end

0 commit comments

Comments
 (0)