[Release] Code cleanup

Author: melanchall

DryWetMidi/Common/MathUtilities.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Collections;
 using System.Collections.Generic;
 
 namespace Melanchall.DryWetMidi.Common

DryWetMidi/Common/ThrowIfArgument.cs

@@ -151,7 +151,7 @@ internal static void IsNullOrEmptyString(string parameterName, string value, str
 
         internal static void IsInvalidIndex(string parameterName, int index, int collectionSize)
         {
-            IsOutOfRange(parameterName, index, MinNonnegativeValue, collectionSize, "Index is out of range.");
+            IsOutOfRange(parameterName, index, MinNonnegativeValue, collectionSize - 1, "Index is out of range.");
         }
 
         internal static void IsEmptyCollection<T>(string parameterName, IEnumerable<T> collection, string message)

DryWetMidi/Interaction/Notes/NotesManagingUtilities.cs

@@ -3,7 +3,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Runtime;
 
 namespace Melanchall.DryWetMidi.Interaction
 {
@@ -98,7 +97,7 @@ private interface IObjectDescriptor
 
         private class NoteDescriptor : IObjectDescriptor
         {
-            private TimedEvent _noteOnTimedEvent;
+            private readonly TimedEvent _noteOnTimedEvent;
 
             public NoteDescriptor(TimedEvent noteOnTimedEvent)
             {
@@ -144,7 +143,7 @@ public ITimedObject GetObject(Func<NoteData, Note> constructor)
 
         private class TimedEventDescriptor : IObjectDescriptor
         {
-            private TimedEvent _timedEvent;
+            private readonly TimedEvent _timedEvent;
 
             public TimedEventDescriptor(TimedEvent timedEvent)
             {

DryWetMidi/Interaction/TimedEvents/TimedEventsManagingUtilities.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Data;
 using System.Linq;
 using Melanchall.DryWetMidi.Common;
 using Melanchall.DryWetMidi.Core;
@@ -768,7 +767,6 @@ internal static int ProcessTimedEventsInternal(
 
             foreach (var eventsCollection in eventsCollectionsIn)
             {
-                var eventsCount = eventsCollection.Count;
                 var matchedCount = 0;
 
                 var timesChanged = false;

DryWetMidi/Interaction/TimedObject/TimedObjectUtilities.ProcessObjects.cs

@@ -493,7 +493,6 @@ internal static int ProcessObjectsInternal(
 
             foreach (var eventsCollection in eventsCollectionsIn)
             {
-                var eventsCount = eventsCollection.Count;
                 var iMatched = 0;
 
                 var processingContext = new ProcessingContext

DryWetMidi/Interaction/TimedObject/TimedObjectsCollection.cs

@@ -4,7 +4,6 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
-using System.Xml.Linq;
 
 namespace Melanchall.DryWetMidi.Interaction
 {
@@ -50,6 +49,10 @@ internal TimedObjectsCollection(IEnumerable<TObject> objects, TimedObjectsCompar
         /// </summary>
         public int Count => _objects.Count;
 
+        /// <summary>
+        /// Gets a value indicating whether the <see cref="TimedObjectsCollection{TObject}"/>
+        /// is read-only.
+        /// </summary>
         public bool IsReadOnly => false;
 
         #endregion
@@ -175,13 +178,52 @@ public void Clear()
             OnObjectsRemoved(removedObjects);
         }
 
-        public bool Contains(TObject item)
+        /// <summary>
+        /// Determines whether the <see cref="TimedObjectsCollection{TObject}"/> contains a
+        /// specific object.
+        /// </summary>
+        /// <param name="obj">The object to locate in the <see cref="TimedObjectsCollection{TObject}"/>.</param>
+        /// <returns><c>true</c> if the object is found; otherwise, <c>false</c>.</returns>
+        public bool Contains(TObject obj)
         {
-            return _objects.Contains(item);
+            return _objects.Contains(obj);
         }
 
+
+        /// <summary>
+        /// Copies the objects of the <see cref="TimedObjectsCollection{TObject}"/> to an
+        /// array, starting at a particular index.
+        /// </summary>
+        /// <param name="array">The one-dimensional array that is the destination of the objects
+        /// copied from <see cref="TimedObjectsCollection{TObject}"/>. The array must have
+        /// zero-based indexing.</param>
+        /// <param name="arrayIndex">The zero-based index in array at which copying begins.</param>
+        /// <exception cref="ArgumentNullException"><paramref name="array"/> is <c>null</c>.</exception>
+        /// <exception cref="ArgumentOutOfRangeException">
+        /// One of the following errors occurred:
+        /// <list type="bullet">
+        /// <item>
+        /// <description><paramref name="arrayIndex"/> is less than zero or greater than the length of the array.</description>
+        /// </item>
+        /// <item>
+        /// <description>The number of elements in the <see cref="TimedObjectsCollection{TObject}"/> is greater than
+        /// the available space from the <paramref name="arrayIndex"/> to the end of the <paramref name="array"/>.</description>
+        /// </item>
+        /// </list>
+        /// </exception>
         public void CopyTo(TObject[] array, int arrayIndex)
         {
+            ThrowIfArgument.IsNull(nameof(array), array);
+            ThrowIfArgument.IsInvalidIndex(
+                nameof(arrayIndex),
+                arrayIndex,
+                array.Length);
+            ThrowIfArgument.IsLessThan(
+                nameof(array),
+                array.Length - arrayIndex,
+                Count,
+                "The number of elements in the source collection is greater than the available space from the index to the end of the destination array.");
+
             _objects.CopyTo(array, arrayIndex);
         }
 

DryWetMidi/Interaction/ValueLine/ValueLine.cs

@@ -230,7 +230,6 @@ public bool SetValueInternal(long time, TValue value)
             var nextIndex = index;
             var nextValueChange = nextIndex >= 0 ? _valueChanges[nextIndex] : null;
             var nextValue = nextValueChange != null ? nextValueChange.Value : _defaultValue;
-            var nextTime = nextValueChange != null ? nextValueChange.Time : long.MaxValue;
 
             var previousIndex = index > 0 ? index - 1 : (index < 0 ? _valueChanges.Count - 1 : -1);
             var previousValueChange = previousIndex >= 0 ? _valueChanges[previousIndex] : null;

DryWetMidi/Multimedia/Playback/Source/FixedPlaybackSource.cs

@@ -9,7 +9,7 @@ internal sealed class FixedPlaybackSource : IPlaybackSource
     {
         #region Fields
 
-        private IList<PlaybackEvent> _playbackEventsBuffer = new List<PlaybackEvent>();
+        private readonly IList<PlaybackEvent> _playbackEventsBuffer = new List<PlaybackEvent>();
         private PlaybackEvent[] _playbackEvents = null;
         private int _playbackEventsPosition = -1;
         private bool _isCompleted;

DryWetMidi/Multimedia/Playback/Source/IPlaybackSource.cs

@@ -1,6 +1,4 @@
-using Melanchall.DryWetMidi.Common;
-using System;
-using System.Collections.Generic;
+using System;
 
 namespace Melanchall.DryWetMidi.Multimedia
 {