Fix sysex handling

Author: melanchall

.github/workflows/test-mmedia.yml

@@ -103,7 +103,7 @@ jobs:
           enabled: 'true'
 
       - name: Run unit tests
-        continue-on-error:  false
+        continue-on-error: false
         shell: pwsh
         run: |
           dotnet test DryWetMidi.Tests/Melanchall.DryWetMidi.Tests.csproj --blame --blame-hang --blame-hang-timeout 5m --blame-hang-dump-type full --no-build --configuration ${{ vars.TEST_BUILD_CONFIGURATION || 'Release' }} --filter "(FullyQualifiedName~.Multimedia)" --framework ${{ steps.framework.outputs.tfm }} --verbosity normal --diag diagnostic.log --logger "console;verbosity=detailed" -p:SolutionDir="${{ github.workspace }}/"
@@ -116,8 +116,18 @@ jobs:
 
       - name: Upload PlaybackTraces
         if:  failure()
+        continue-on-error: true
         uses: actions/upload-artifact@v4
         with: 
           name: PlaybackTraces_${{ matrix.os }}_${{ matrix.framework }}_Attempt${{ github.run_attempt }}
           path: ${{ github.workspace }}/PlaybackTraces
+          if-no-files-found: ignore
+          
+      - name: Upload SysExTraces
+        if:  failure()
+        continue-on-error: true
+        uses: actions/upload-artifact@v4
+        with: 
+          name: SysExTraces_${{ matrix.os }}_${{ matrix.framework }}_Attempt${{ github.run_attempt }}
+          path: ${{ github.workspace }}/SysExTraces
           if-no-files-found: ignore

DryWetMidi.Tests/Multimedia/Clock/TickGenerator/Session/TickGeneratorSessionTests.cs

@@ -23,14 +23,11 @@ public sealed class TickGeneratorSessionTests
 
 #if TEST
         [Test]
-        public void CheckTickGeneratorSession_DisposeManually()
+        public void CheckTickGeneratorSession_DisposeManually([Values(0, 50, 5000)] int waitAfterSessionCreatedMs)
         {
             var checkpoints = new TestCheckpoints();
 
-            TickGeneratorSessionApi.Api_OpenSession(
-                out var rawHandle,
-                out var errorCode);
-
+            var rawHandle = CreateTickGeneratorSessionHandle(waitAfterSessionCreatedMs);
             var handle = new TickGeneratorSessionHandle(rawHandle);
             handle.TestCheckpoints = checkpoints;
 
@@ -48,29 +45,27 @@ public void CheckTickGeneratorSession_DisposeManually()
         }
 
         [Test]
-        public void CheckTickGeneratorSession_AbandonAndWaitForFinalizer()
+        public void CheckTickGeneratorSession_AbandonAndWaitForFinalizer([Values(0, 50, 5000)] int waitAfterSessionCreatedMs)
         {
             var checkpoints = new TestCheckpoints();
 
-            CreateAndAbandonTickGeneratorSession(checkpoints);
+            CreateAndAbandonTickGeneratorSession(checkpoints, waitAfterSessionCreatedMs);
 
             GC.Collect();
             GC.WaitForPendingFinalizers();
             GC.Collect();
 
             checkpoints.CheckCheckpointsReached(
-                MidiDevicesSessionCheckpointNames.HandleFinalizerEntered,
-                MidiDevicesSessionCheckpointNames.SessionClosedInHandleFinalizer);
+                MidiDevicesSessionCheckpointNames.ReleaseHandleEntered,
+                MidiDevicesSessionCheckpointNames.CloseSessionInReleaseHandle);
         }
 
         [Test]
-        public void CheckTickGeneratorSession_CloseViaApi()
+        public void CheckTickGeneratorSession_CloseViaApi([Values(0, 50, 5000)] int waitAfterSessionCreatedMs)
         {
-            TickGeneratorSessionApi.Api_OpenSession(
-                out var sessionHandle,
-                out var errorCode);
+            var sessionHandle = CreateTickGeneratorSessionHandle(waitAfterSessionCreatedMs);
 
-            var result = TickGeneratorSessionApi.Api_CloseSession(sessionHandle, out errorCode);
+            var result = TickGeneratorSessionApi.Api_CloseSession(sessionHandle, out var errorCode);
             ClassicAssert.AreEqual(
                 TickGeneratorSessionApi.TGSESSION_CLOSERESULT.TGSESSION_CLOSERESULT_OK,
                 result,
@@ -85,18 +80,34 @@ public void CheckTickGeneratorSession_CloseViaApi()
 #if TEST
         [MethodImpl(MethodImplOptions.NoInlining)]
         private void CreateAndAbandonTickGeneratorSession(
-            TestCheckpoints checkpoints)
+            TestCheckpoints checkpoints,
+            int waitAfterSessionCreatedMs)
         {
-            TickGeneratorSessionApi.Api_OpenSession(
-                out var rawHandle,
-                out var errorCode);
-
+            var rawHandle = CreateTickGeneratorSessionHandle(waitAfterSessionCreatedMs);
             var handle = new TickGeneratorSessionHandle(rawHandle);
             handle.TestCheckpoints = checkpoints;
 
             // Don't dispose - let it go out of scope
             // Finalizer will run eventually
         }
+
+        private IntPtr CreateTickGeneratorSessionHandle(
+            int waitAfterSessionCreatedMs)
+        {
+            var result = TickGeneratorSessionApi.Api_OpenSession(
+                out var rawHandle,
+                out var errorCode);
+
+            ClassicAssert.AreEqual(
+                TickGeneratorSessionApi.TGSESSION_OPENRESULT.TGSESSION_OPENRESULT_OK,
+                result,
+                "Session was not opened successfully.");
+
+            if (waitAfterSessionCreatedMs > 0)
+                WaitOperations.Wait(waitAfterSessionCreatedMs);
+
+            return rawHandle;
+        }
 #endif
 
         #endregion

DryWetMidi.Tests/Multimedia/InputDevice/InputDeviceTests.Common.cs

@@ -179,16 +179,20 @@ public void InputDeviceIsReleasedByDispose()
                 ClassicAssert.DoesNotThrow(() => inputDevice.StartEventsListening());
 
                 checkpoints.CheckCheckpointsAreNotReached(
-                    InputDeviceCheckpointsNames.HandleFinalizerEntered,
-                    InputDeviceCheckpointsNames.DeviceDisconnectedInHandleFinalizer,
-                    InputDeviceCheckpointsNames.DeviceClosedInHandleFinalizer);
+                    InputDeviceCheckpointsNames.ReleaseHandleEntered,
+                    InputDeviceCheckpointsNames.DisconnectDeviceExecutedInReleaseHandle,
+                    InputDeviceCheckpointsNames.DisconnectDeviceSuccessInReleaseHandle,
+                    InputDeviceCheckpointsNames.CloseDeviceExecutedInReleaseHandle,
+                    InputDeviceCheckpointsNames.CloseDeviceSuccessInReleaseHandle);
 
                 inputDevice.Dispose();
 
                 checkpoints.CheckCheckpointsReached(
-                    InputDeviceCheckpointsNames.HandleFinalizerEntered,
-                    InputDeviceCheckpointsNames.DeviceDisconnectedInHandleFinalizer,
-                    InputDeviceCheckpointsNames.DeviceClosedInHandleFinalizer);
+                    InputDeviceCheckpointsNames.ReleaseHandleEntered,
+                    InputDeviceCheckpointsNames.DisconnectDeviceExecutedInReleaseHandle,
+                    InputDeviceCheckpointsNames.DisconnectDeviceSuccessInReleaseHandle,
+                    InputDeviceCheckpointsNames.CloseDeviceExecutedInReleaseHandle,
+                    InputDeviceCheckpointsNames.CloseDeviceSuccessInReleaseHandle);
             }
         }
 
@@ -216,9 +220,11 @@ public void InputDeviceIsReleasedByFinalizer()
                 var checkpoints = new TestCheckpoints();
 
                 checkpoints.CheckCheckpointsAreNotReached(
-                    InputDeviceCheckpointsNames.HandleFinalizerEntered,
-                    InputDeviceCheckpointsNames.DeviceDisconnectedInHandleFinalizer,
-                    InputDeviceCheckpointsNames.DeviceClosedInHandleFinalizer);
+                    InputDeviceCheckpointsNames.ReleaseHandleEntered,
+                    InputDeviceCheckpointsNames.DisconnectDeviceExecutedInReleaseHandle,
+                    InputDeviceCheckpointsNames.DisconnectDeviceSuccessInReleaseHandle,
+                    InputDeviceCheckpointsNames.CloseDeviceExecutedInReleaseHandle,
+                    InputDeviceCheckpointsNames.CloseDeviceSuccessInReleaseHandle);
 
                 ClassicAssert.IsTrue(openDevice(checkpoints), $"Can't open device on iteration {i}.");
 
@@ -227,9 +233,11 @@ public void InputDeviceIsReleasedByFinalizer()
                 GC.Collect();
 
                 checkpoints.CheckCheckpointsReached(
-                    InputDeviceCheckpointsNames.HandleFinalizerEntered,
-                    InputDeviceCheckpointsNames.DeviceDisconnectedInHandleFinalizer,
-                    InputDeviceCheckpointsNames.DeviceClosedInHandleFinalizer);
+                    InputDeviceCheckpointsNames.ReleaseHandleEntered,
+                    InputDeviceCheckpointsNames.DisconnectDeviceExecutedInReleaseHandle,
+                    InputDeviceCheckpointsNames.DisconnectDeviceSuccessInReleaseHandle,
+                    InputDeviceCheckpointsNames.CloseDeviceExecutedInReleaseHandle,
+                    InputDeviceCheckpointsNames.CloseDeviceSuccessInReleaseHandle);
             }
         }
 #endif