Satisfy the compiler

Author: Noarkhh

lib/membrane/children_spec.ex

@@ -452,7 +452,9 @@ defmodule Membrane.ChildrenSpec do
       via_in(builder, :input)
     end
     |> Builder.finish_link(child_name)
-    |> then(&%Builder{&1 | children: [child_spec | &1.children]})
+    |> then(fn %Builder{} = builder ->
+      %Builder{builder | children: [child_spec | builder.children]}
+    end)
   end
 
   @doc """
@@ -465,7 +467,9 @@ defmodule Membrane.ChildrenSpec do
     :ok = validate_pad_name(pad)
 
     get_child({Membrane.Bin, :itself})
-    |> then(&%Builder{&1 | status: :from_pad, from_pad: pad, from_pad_props: %{}})
+    |> then(fn %Builder{} = builder ->
+      %Builder{builder | status: :from_pad, from_pad: pad, from_pad_props: %{}}
+    end)
   end
 
   @doc """
@@ -488,7 +492,9 @@ defmodule Membrane.ChildrenSpec do
     else
       via_out(builder, :output)
     end
-    |> then(&%Builder{&1 | status: :to_pad, to_pad: pad, to_pad_props: %{}})
+    |> then(fn %Builder{} = builder ->
+      %Builder{builder | status: :to_pad, to_pad: pad, to_pad_props: %{}}
+    end)
     |> get_child({Membrane.Bin, :itself})
   end
 
@@ -572,7 +578,9 @@ defmodule Membrane.ChildrenSpec do
     else
       via_out(builder, :output)
     end
-    |> then(&%Builder{&1 | status: :to_pad, to_pad: pad, to_pad_props: Enum.into(props, %{})})
+    |> then(fn %Builder{} = builder ->
+      %Builder{builder | status: :to_pad, to_pad: pad, to_pad_props: Enum.into(props, %{})}
+    end)
   end
 
   @doc """

lib/membrane/core/element/lifecycle_controller.ex

@@ -73,7 +73,7 @@ defmodule Membrane.Core.Element.LifecycleController do
   end
 
   @spec handle_playing(State.t()) :: State.t()
-  def handle_playing(state) do
+  def handle_playing(%State{} = state) do
     Membrane.Logger.debug("Got play request")
 
     state =

lib/membrane/core/element/manual_flow_controller.ex

@@ -80,7 +80,7 @@ defmodule Membrane.Core.Element.ManualFlowController do
     |> handle_delayed_demands()
   end
 
-  defp do_supply_demand(pad_ref, state) do
+  defp do_supply_demand(pad_ref, %State{} = state) do
     # marking is state that actual demand supply has been started (note changing back to false when finished)
     state = %State{state | delay_demands?: true}
 
@@ -90,7 +90,7 @@ defmodule Membrane.Core.Element.ManualFlowController do
       InputQueue.take(pad_data.input_queue, pad_data.manual_demand_size)
 
     state = PadModel.set_data!(state, pad_ref, :input_queue, new_input_queue)
-    state = handle_input_queue_output(pad_ref, popped_data, state)
+    %State{} = state = handle_input_queue_output(pad_ref, popped_data, state)
     %State{state | delay_demands?: false}
   end
 

lib/membrane/core/element/playback_queue.ex

@@ -12,7 +12,8 @@ defmodule Membrane.Core.Element.PlaybackQueue do
 
   @spec eval(State.t()) :: State.t()
   def eval(%State{playback_queue: playback_queue} = state) do
-    state =
+    %State{} =
+      state =
       playback_queue
       |> List.foldr(state, fn function, state -> function.(state) end)
 

lib/membrane/core/parent/child_life_controller/crash_group_utils.ex

@@ -92,12 +92,14 @@ defmodule Membrane.Core.Parent.ChildLifeController.CrashGroupUtils do
 
     update_in(
       state.crash_groups[group.name],
-      &%CrashGroup{
-        &1
-        | detonating?: true,
-          crash_initiator: crash_initiator,
-          crash_reason: reason
-      }
+      fn %CrashGroup{} = group ->
+        %CrashGroup{
+          group
+          | detonating?: true,
+            crash_initiator: crash_initiator,
+            crash_reason: reason
+        }
+      end
     )
   end
 

lib/membrane/core/parent/child_life_controller/link_utils.ex

@@ -156,12 +156,14 @@ defmodule Membrane.Core.Parent.ChildLifeController.LinkUtils do
     links =
       Enum.map(
         links,
-        &%Link{
-          &1
-          | spec_ref: spec_ref,
-            from: resolve_endpoint(&1.from, state),
-            to: resolve_endpoint(&1.to, state)
-        }
+        fn %Link{} = link ->
+          %Link{
+            link
+            | spec_ref: spec_ref,
+              from: resolve_endpoint(link.from, state),
+              to: resolve_endpoint(link.to, state)
+          }
+        end
       )
 
     :ok = validate_links(links, state)
@@ -235,13 +237,12 @@ defmodule Membrane.Core.Parent.ChildLifeController.LinkUtils do
     end
   end
 
-  defp resolve_endpoint(endpoint, state) do
-    %Endpoint{child: child, pad_spec: pad_spec} = endpoint
-    child_data = Parent.ChildrenModel.get_child_data!(state, child)
-    pad_name = Pad.name_by_ref(pad_spec)
+  defp resolve_endpoint(%Endpoint{} = endpoint, state) do
+    child_data = Parent.ChildrenModel.get_child_data!(state, endpoint.child)
+    pad_name = Pad.name_by_ref(endpoint.pad_spec)
 
     withl pad: {:ok, pad_info} <- Keyword.fetch(child_data.module.membrane_pads(), pad_name),
-          ref: {:ok, ref} <- make_pad_ref(pad_spec, pad_info.availability) do
+          ref: {:ok, ref} <- make_pad_ref(endpoint.pad_spec, pad_info.availability) do
       %Endpoint{
         endpoint
         | pid: child_data.pid,
@@ -251,11 +252,12 @@ defmodule Membrane.Core.Parent.ChildLifeController.LinkUtils do
       }
     else
       pad: :error ->
-        raise LinkError, "Child #{inspect(child)} does not have pad #{inspect(pad_spec)}"
+        raise LinkError,
+              "Child #{inspect(endpoint.child)} does not have pad #{inspect(endpoint.pad_spec)}"
 
       ref: {:error, :invalid_availability} ->
         raise LinkError,
-              "Dynamic pad ref #{inspect(pad_spec)} passed for static pad of child #{inspect(child)}"
+              "Dynamic pad ref #{inspect(endpoint.pad_spec)} passed for static pad of child #{inspect(endpoint.child)}"
     end
   end
 

lib/membrane/core/parent/child_life_controller/startup_utils.ex

@@ -172,7 +172,7 @@ defmodule Membrane.Core.Parent.ChildLifeController.StartupUtils do
     :ok
   end
 
-  defp start_child(child, node, syncs, log_metadata, group, state) do
+  defp start_child(%ChildEntry{} = child, node, syncs, log_metadata, group, state) do
     %ChildEntry{name: name, module: module, options: options} = child
 
     Membrane.Logger.debug(

lib/membrane/core/parent/specification_parser.ex

@@ -28,7 +28,7 @@ defmodule Membrane.Core.Parent.SpecificationParser do
         %ChildrenSpec.Builder{links: links, children: children, status: :done} = builder ->
           if links == [] and children == [] do
             Membrane.Logger.warning(
-              "The specification you have passed: #{builder} has no effect - it doesn't produce any children nor links."
+              "The specification you have passed: #{inspect(builder)} has no effect - it doesn't produce any children nor links."
             )
           end
 

lib/membrane/core/timer.ex

@@ -40,7 +40,7 @@ defmodule Membrane.Core.Timer do
   end
 
   @spec update_ratio(t, Clock.ratio()) :: t
-  def update_ratio(timer, ratio) do
+  def update_ratio(%__MODULE__{} = timer, ratio) do
     %__MODULE__{timer | ratio: ratio}
   end
 
@@ -55,7 +55,7 @@ defmodule Membrane.Core.Timer do
     timer
   end
 
-  def tick(timer) do
+  def tick(%__MODULE__{} = timer) do
     %__MODULE__{
       id: id,
       interval: interval,
@@ -89,7 +89,7 @@ defmodule Membrane.Core.Timer do
     |> tick()
   end
 
-  def set_interval(timer, interval) do
+  def set_interval(%__MODULE__{} = timer, interval) do
     %__MODULE__{timer | interval: interval}
   end
 end

mix.exs

@@ -17,12 +17,6 @@ defmodule Membrane.Mixfile do
       source_url: link(),
       docs: docs(),
       aliases: [docs: ["docs", &copy_assets/1]],
-      preferred_cli_env: [
-        coveralls: :test,
-        "coveralls.detail": :test,
-        "coveralls.post": :test,
-        "coveralls.html": :test
-      ],
       test_coverage: [tool: ExCoveralls, test_task: "test"],
       deps: deps()
     ]
@@ -32,6 +26,17 @@ defmodule Membrane.Mixfile do
     [extra_applications: [:logger]]
   end
 
+  def cli do
+    [
+      preferred_envs: [
+        coveralls: :test,
+        "coveralls.detail": :test,
+        "coveralls.post": :test,
+        "coveralls.html": :test
+      ]
+    ]
+  end
+
   defp elixirc_paths(:test), do: ["lib", "test/support"]
   defp elixirc_paths(:benchmark), do: ["lib", "benchmark"]
   defp elixirc_paths(_env), do: ["lib"]