Fix process leak (#561)

Author: FelonEkonom

CHANGELOG.md

@@ -1,7 +1,10 @@
 # Changelog
 
+# 0.11.4
+ * Fix process leak. [#561](https://github.com/membraneframework/membrane_core/pull/561)
+
 # 0.11.3
- * Fix bug in `c:Membrane.Pipeline.handle_call/3` [#526](https://github.com/membraneframework/membrane_core/pull/526).
+ * Fix bug in `c:Membrane.Pipeline.handle_call/3` [#526](https://github.com/membraneframework/membrane_core/pull/526)
 
 # 0.11.2
  * Fix bug in Membrane.ChildrenSpec.child/3 spec.

README.md

@@ -23,7 +23,7 @@ This package provides core of the [Membrane Multimedia Framework](https://membra
 Add the following line to your `deps` in `mix.exs`. Run `mix deps.get`.
 
 ```elixir
-	{:membrane_core, "~> 0.11.3"}
+	{:membrane_core, "~> 0.11.4"}
 ```
 
 ## Getting started

guides/upgrading/v0.11.md

@@ -4,11 +4,11 @@ Improvements in v0.11 required some breaking changes, so here comes the guide th
 
 ## Deps upgrade
 
-Update `membrane_core` to `v0.11.3`
+Update `membrane_core` to `v0.11.4`
 ```elixir 
 defp deps do
    [
-     {:membrane_core, "~> 0.11.3"},
+     {:membrane_core, "~> 0.11.4"},
      ...
    ]
 end

lib/membrane/core/bin.ex

@@ -94,7 +94,12 @@ defmodule Membrane.Core.Bin do
     Membrane.Core.Observability.setup(observability_config)
     SubprocessSupervisor.set_parent_component(options.subprocess_supervisor, observability_config)
 
-    clock_proxy = Membrane.Clock.start_link(proxy: true) ~> ({:ok, pid} -> pid)
+    {:ok, clock_proxy} =
+      SubprocessSupervisor.start_utility(
+        options.subprocess_supervisor,
+        {Membrane.Clock, proxy: true}
+      )
+
     clock = if Bunch.Module.check_behaviour(module, :membrane_clock?), do: clock_proxy, else: nil
     Message.send(options.parent, :clock, [name, clock])
 

mix.exs

@@ -1,7 +1,7 @@
 defmodule Membrane.Mixfile do
   use Mix.Project
 
-  @version "0.11.3"
+  @version "0.11.4"
   @source_ref "v#{@version}"
 
   def project do

test/membrane/core/element/action_handler_test.exs

@@ -1,7 +1,7 @@
 defmodule Membrane.Core.Element.ActionHandlerTest do
   use ExUnit.Case, async: true
 
-  alias Membrane.{ActionError, Buffer, ElementError, PadDirectionError}
+  alias Membrane.{ActionError, Buffer, ElementError, PadDirectionError, UnknownPadError}
   alias Membrane.Core.Element.State
   alias Membrane.Support.DemandsTest.Filter
   alias Membrane.Support.Element.{TrivialFilter, TrivialSource}
@@ -166,7 +166,7 @@ defmodule Membrane.Core.Element.ActionHandlerTest do
     test "when pad doesn't exist in the element", %{state: state} do
       state = %{state | playback: :playing}
 
-      assert_raise MatchError, ~r/:unknown_pad/i, fn ->
+      assert_raise UnknownPadError, fn ->
         @module.handle_action(
           buffer_action(:invalid_pad_ref),
           :handle_info,
@@ -289,7 +289,7 @@ defmodule Membrane.Core.Element.ActionHandlerTest do
     test "when pad doesn't exist in the element", %{state: state} do
       state = %{state | playback: :playing}
 
-      assert_raise MatchError, ~r/:unknown_pad/i, fn ->
+      assert_raise UnknownPadError, fn ->
         @module.handle_action(
           event_action(:invalid_pad_ref),
           :handle_info,
@@ -360,7 +360,7 @@ defmodule Membrane.Core.Element.ActionHandlerTest do
     test "when pad doesn't exist in the element", %{state: state} do
       state = %{state | playback: :playing}
 
-      assert_raise MatchError, ~r/:unknown_pad/i, fn ->
+      assert_raise UnknownPadError, fn ->
         @module.handle_action(
           stream_format_action(:invalid_pad_ref),
           :handle_info,
@@ -424,7 +424,7 @@ defmodule Membrane.Core.Element.ActionHandlerTest do
     test "when pad doesn't exist in the element", %{state: state} do
       state = %{state | playback: :playing}
 
-      assert_raise MatchError, ~r/:unknown_pad/i, fn ->
+      assert_raise UnknownPadError, fn ->
         @module.handle_action(
           {:redemand, :invalid_pad_ref},
           :handle_info,

test/membrane/core/element/pad_model_test.exs

@@ -1,6 +1,8 @@
 defmodule Membrane.Core.Child.PadModelTest do
   use ExUnit.Case, async: true
 
+  alias Membrane.UnknownPadError
+
   require Membrane.Core.Child.PadModel, as: PadModel
 
   defp setup_element_state(_ctx) do
@@ -45,7 +47,7 @@ defmodule Membrane.Core.Child.PadModelTest do
     end
 
     test "is :unknown_pad when the pad is not present", ctx do
-      assert_raise MatchError, fn ->
+      assert_raise UnknownPadError, fn ->
         PadModel.get_data!(ctx.state, :output, :demand)
       end
     end
@@ -76,7 +78,7 @@ defmodule Membrane.Core.Child.PadModelTest do
     end
 
     test "raises when the pad is not present", ctx do
-      assert_raise MatchError, fn ->
+      assert_raise UnknownPadError, fn ->
         PadModel.set_data!(ctx.state, :other_input, :start_of_stream?, true)
       end
     end
@@ -105,7 +107,7 @@ defmodule Membrane.Core.Child.PadModelTest do
     end
 
     test "raises when the pad is not present", ctx do
-      assert_raise MatchError, fn ->
+      assert_raise UnknownPadError, fn ->
         PadModel.update_data!(ctx.state, :other_input, :demand, &(&1 + 5))
       end
     end

test/support/bin/test_bins.ex

@@ -1,6 +1,5 @@
 defmodule Membrane.Support.Bin.TestBins do
   @moduledoc false
-  alias Membrane.ChildrenSpec
 
   defmodule TestFilter do
     @moduledoc false