Skip to content

Fix compilation warnings in test files - #1095

Merged
FelonEkonom merged 2 commits into
masterfrom
fix-test-compilation-warnings
Apr 2, 2026
Merged

Fix compilation warnings in test files#1095
FelonEkonom merged 2 commits into
masterfrom
fix-test-compilation-warnings

Conversation

@FelonEkonom

@FelonEkonom FelonEkonom commented Mar 9, 2026

Copy link
Copy Markdown
Member

Squeeze Klaudiusz like a 🍋

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@FelonEkonom
FelonEkonom requested a review from mat-hek as a code owner March 9, 2026 17:33
@FelonEkonom FelonEkonom added the no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md label Mar 9, 2026
@FelonEkonom FelonEkonom self-assigned this Mar 9, 2026
@FelonEkonom FelonEkonom moved this to In Review in Smackore Mar 9, 2026
Comment on lines -91 to +93
case direction do
:up -> {payloads, mult_payloads}
:down -> {mult_payloads, payloads}
end
if direction == :up,
do: {payloads, mult_payloads},
else: {mult_payloads, payloads}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the previous version caused some warnings

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more like a hack than a solution to me. I'd try figuring out the actual reason for the warnings.

@FelonEkonom
FelonEkonom enabled auto-merge April 2, 2026 11:17
@FelonEkonom
FelonEkonom disabled auto-merge April 2, 2026 11:17
@FelonEkonom
FelonEkonom merged commit 804bbbf into master Apr 2, 2026
1 of 3 checks passed
@FelonEkonom
FelonEkonom deleted the fix-test-compilation-warnings branch April 2, 2026 11:17
@github-project-automation github-project-automation Bot moved this from In Review to Done in Smackore Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants