Skip to content

Commit 8af8c28

Browse files
authored
Merge pull request #55 from membraneframework/fix-prevent-adding-pads-when-playing
Fix the guard preventing adding a pad in state `:playing`, bump package version
2 parents cebec49 + d3d14f2 commit 8af8c28

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ The package can be installed by adding `membrane_mp4_plugin` to your list of dep
1212
```elixir
1313
defp deps do
1414
[
15-
{:membrane_mp4_plugin, "~> 0.18.0"}
15+
{:membrane_mp4_plugin, "~> 0.18.1"}
1616
]
1717
end
1818
```

lib/membrane_mp4/muxer/cmaf.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@ defmodule Membrane.MP4.Muxer.CMAF do
6767
end
6868

6969
@impl true
70-
def handle_pad_added(_pad, ctx, _state) when ctx.playback_state == :playing,
70+
def handle_pad_added(_pad, ctx, _state) when ctx.playback == :playing,
7171
do:
7272
raise(
73-
"New tracks can be added to #{inspect(__MODULE__)} only before transition to state: :playing"
73+
"New tracks can be added to #{inspect(__MODULE__)} only before playback transition to :playing"
7474
)
7575

7676
@impl true

mix.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
defmodule Membrane.MP4.Plugin.MixProject do
22
use Mix.Project
33

4-
@version "0.18.0"
4+
@version "0.18.1"
55
@github_url "https://github.com/membraneframework/membrane_mp4_plugin"
66

77
def project do

0 commit comments

Comments
 (0)