Skip to content

Commit 052426c

Browse files
committed
docs: Apply internal-account rename + fix cross-service flow labels
Missed two migrations in the prior schema pass (claude[bot] review): - PR-era 2026-02-25: internal_bank_account renamed to internal_account, internal_bank_account_status_history to internal_account_status_history, correspondent_bank_* to counterparty_* - PR-era 2026-03-06: internal-account lien.currency renamed to instrument_code Also fix cross-service flowchart edge labels that referred to columns that do not exist (balance_ref, counterparty_party_id) or used renamed names (account_type_code, asset_code, dataset). Replace balance_ref with account_id and drop the IBA to party edge since internal_account holds a varchar counterparty identifier, not a direct party FK.
1 parent 6610339 commit 052426c

1 file changed

Lines changed: 19 additions & 20 deletions

File tree

docs/architecture/data-model.md

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@ Tables listed below live in the `org_<tenant_id>` schema of the service database
167167
- `valuation_features` — per-account valuation cache
168168

169169
**internal-account** — counterparty and operational accounts
170-
- `internal_bank_account` — CLEARING / NOSTRO / VOSTRO / HOLDING / SUSPENSE / REVENUE / EXPENSE / INVENTORY. Multi-asset dimension support. No balance columns — delegates to `position-keeping`.
171-
- `internal_bank_account_status_history` — ACTIVE / SUSPENDED / CLOSED transitions
170+
- `internal_account` — CLEARING / NOSTRO / VOSTRO / HOLDING / SUSPENSE / REVENUE / EXPENSE / INVENTORY. Multi-asset dimension support. No balance columns — delegates to `position-keeping`. Counterparty fields are `counterparty_id` / `counterparty_name` / `counterparty_external_ref` (renamed from `correspondent_bank_*` in 2026-02).
171+
- `internal_account_status_history` — ACTIVE / SUSPENDED / CLOSED transitions
172172
- `lien` — fund reservations with bucket-aware multi-asset valuation
173173
- `valuation_features`
174174

@@ -482,11 +482,13 @@ erDiagram
482482

483483
### Internal Account
484484

485+
The service is still packaged as `internal-account` but the underlying tables were renamed in PR-era 2026-02-25: `internal_bank_account``internal_account`, `correspondent_bank_*``counterparty_*`. The `lien.currency` column was subsequently renamed to `instrument_code`.
486+
485487
```mermaid
486488
erDiagram
487-
INTERNAL_BANK_ACCOUNT ||--o{ INTERNAL_BANK_ACCOUNT_STATUS_HISTORY : audits
488-
INTERNAL_BANK_ACCOUNT ||--o{ LIEN : reserves
489-
INTERNAL_BANK_ACCOUNT {
489+
INTERNAL_ACCOUNT ||--o{ INTERNAL_ACCOUNT_STATUS_HISTORY : audits
490+
INTERNAL_ACCOUNT ||--o{ LIEN : reserves
491+
INTERNAL_ACCOUNT {
490492
uuid id PK
491493
varchar account_id
492494
varchar account_code
@@ -495,10 +497,12 @@ erDiagram
495497
varchar instrument_code
496498
varchar dimension
497499
varchar status
498-
varchar correspondent_bank_id
500+
varchar counterparty_id
501+
varchar counterparty_name
502+
varchar counterparty_external_ref
499503
jsonb attributes
500504
}
501-
INTERNAL_BANK_ACCOUNT_STATUS_HISTORY {
505+
INTERNAL_ACCOUNT_STATUS_HISTORY {
502506
uuid id PK
503507
varchar account_id FK
504508
varchar from_status
@@ -511,7 +515,7 @@ erDiagram
511515
uuid id PK
512516
uuid account_id FK
513517
bigint amount_cents
514-
varchar currency
518+
varchar instrument_code
515519
varchar bucket_id
516520
varchar status
517521
varchar payment_order_reference
@@ -946,7 +950,7 @@ flowchart LR
946950
CAL[lien]
947951
end
948952
subgraph IA["internal-account service"]
949-
IBA[internal_bank_account]
953+
IBA[internal_account]
950954
end
951955
subgraph PK["position-keeping service"]
952956
FPL[financial_position_log]
@@ -963,23 +967,18 @@ flowchart LR
963967
INST[instrument_definition]
964968
ATD[account_type_definitions]
965969
end
966-
subgraph MI["market-information service"]
967-
OBS[market_price_observation]
968-
end
969970
970971
ACC -. party_id .-> P
971-
IBA -. counterparty_party_id .-> P
972-
ACC -. account_type_code .-> ATD
973-
IBA -. account_type_code .-> ATD
972+
ACC -. account_type .-> ATD
973+
IBA -. account_type .-> ATD
974974
POS -. instrument_code .-> INST
975-
IBA -. asset_code .-> INST
975+
IBA -. instrument_code .-> INST
976976
CAL -. payment_order_reference .-> PMO
977977
PMO -. lien_id .-> CAL
978978
INV -. payment_order_id .-> PMO
979-
FBL -. reference_id .-> FPL
980-
ACC -. balance_ref .-> FPL
981-
IBA -. balance_ref .-> FPL
982-
OBS -. dataset .-> INST
979+
FBL -. account_id .-> FPL
980+
ACC -. account_id .-> FPL
981+
IBA -. account_id .-> FPL
983982
```
984983

985984
## Cross-Tenant Access

0 commit comments

Comments
 (0)