feat: Update current-account persistence layer for dimension-agnostic Amount (#1251)

* feat: Add precision column migrations for account, lien, withdrawal tables

Add precision column to account table (default 2 for existing CURRENCY
accounts) and instrument_code/dimension/precision columns to lien and
withdrawal tables. Follows CockroachDB rules: separate migrations for
DDL and DML.

* feat: Update persistence entities and repositories for dimension-agnostic Amount

Add Precision field to CurrentAccountEntity, instrument_code/dimension/precision
fields to LienEntity and WithdrawalEntity. Update toDomain/toEntity functions
to use entity.Precision instead of hardcoded 0, enabling correct Amount
reconstruction for non-CURRENCY instruments (ENERGY, CARBON, COMPUTE).

Legacy currency column preserved for backward compatibility; instrument_code
is the canonical source with fallback to currency for pre-migration rows.

* test: Update test table schemas for precision columns; add multi-asset round-trip tests

Update inline table creation SQL in all persistence test helpers to include
precision, instrument_code, and dimension columns. Add multi_asset_repository_test.go
with round-trip tests for ENERGY (KWH/precision=3), CARBON (CARBON_CREDIT/precision=4),
COMPUTE (GPU_HOUR/precision=6) accounts, liens, and withdrawals. Includes backward
compatibility test for legacy currency column fallback.

* fix: Add check constraints and correct backfill logic for precision migrations

Address CodeRabbit feedback:
- Add CHECK constraints to prevent negative precision on account, lien, withdrawal
- Fix backfill to handle JPY exception (precision=0) using CASE expression
- Fix lien/withdrawal backfill to JOIN account for authoritative dimension/precision
  values instead of hardcoding CURRENCY/2

* fix: Use instrument_code for lien consistency check instead of legacy currency column

COUNT(DISTINCT currency) returns 2 for a mix of CURRENCY and non-CURRENCY liens
because non-CURRENCY liens store empty string in currency. Use instrument_code
instead for accurate multi-asset consistency validation.

* fix: Add instrument_code non-empty constraints after backfill

The instrument_code non-empty check constraints must be in migration 004
(after the backfill) rather than 003, because existing rows have the
default empty string until backfilled. Adding these constraints before
the backfill would reject existing rows.

Addresses CodeRabbit feedback on missing integrity constraints.

* fix: Update schema validation test entities to include instrument_code

The new chk_lien_instrument_code_non_empty and
chk_withdrawal_instrument_code_non_empty constraints require instrument_code
to be non-empty. Update testLienEntity and testWithdrawalEntity to populate
InstrumentCode, Dimension, and Precision fields on all created test rows.

* fix: Add precision/instrument_code columns to service-layer test DDL

Four service integration tests use manual DDL to create test schemas.
Add precision INT NOT NULL DEFAULT 2 to all account table definitions,
and add instrument_code/dimension/precision columns to lien table
definitions, matching the schema added in migration 20260226000003.

* chore: Upgrade golang.org/x/net to v0.51.0 (GO-2026-4559)

Fixes vulnerability GO-2026-4559: sending certain HTTP/2 frames can
cause a server to panic in golang.org/x/net. Upgrade from v0.50.0
to v0.51.0 which contains the fix.

---------

Co-authored-by: Ben Coombs <bjcoombs@users.noreply.github.com>

Author: bjcoombs

go.mod

@@ -4,6 +4,7 @@ go 1.26.0
 
 require (
 	ariga.io/atlas-provider-gorm v0.6.0
+	buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.36.11-20260209202127-80ab13bee0bf.1
 	buf.build/go/protovalidate v1.1.3
 	connectrpc.com/connect v1.19.1
 	connectrpc.com/vanguard v0.3.0
@@ -54,7 +55,6 @@ require (
 )
 
 require (
-	buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.36.11-20260209202127-80ab13bee0bf.1 // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/bits-and-blooms/bitset v1.24.2 // indirect
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
@@ -129,7 +129,7 @@ require (
 	github.com/googleapis/gax-go/v2 v2.15.0 // indirect
 	github.com/googleapis/go-gorm-spanner v1.8.6 // indirect
 	github.com/googleapis/go-sql-spanner v1.17.0 // indirect
-	github.com/grpc-ecosystem/grpc-gateway/v2 v2.28.0 // indirect
+	github.com/grpc-ecosystem/grpc-gateway/v2 v2.28.0
 	github.com/hashicorp/golang-lru/v2 v2.0.7
 	github.com/jackc/pgpassfile v1.0.0 // indirect
 	github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
@@ -172,14 +172,14 @@ require (
 	go.opentelemetry.io/proto/otlp v1.9.0 // indirect
 	golang.org/x/crypto v0.48.0 // indirect
 	golang.org/x/exp v0.0.0-20250813145105-42675adae3e6 // indirect
-	golang.org/x/net v0.50.0
+	golang.org/x/net v0.51.0
 	golang.org/x/oauth2 v0.35.0 // indirect
 	golang.org/x/sync v0.19.0
 	golang.org/x/sys v0.41.0 // indirect
 	golang.org/x/text v0.34.0 // indirect
 	golang.org/x/time v0.14.0
 	google.golang.org/api v0.249.0 // indirect
-	google.golang.org/genproto/googleapis/api v0.0.0-20260209200024-4cfbd4190f57 // indirect
+	google.golang.org/genproto/googleapis/api v0.0.0-20260209200024-4cfbd4190f57
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20260209200024-4cfbd4190f57 // indirect
 	gopkg.in/yaml.v3 v3.0.1
 	gorm.io/driver/mysql v1.5.7 // indirect

go.sum

@@ -1402,8 +1402,8 @@ golang.org/x/net v0.10.0/go.mod h1:0qNGK6F8kojg2nk9dLZ2mShWaEBan6FAoqfSigmmuDg=
 golang.org/x/net v0.15.0/go.mod h1:idbUs1IY1+zTqbi8yxTbhexhEEk5ur9LInksu6HrEpk=
 golang.org/x/net v0.21.0/go.mod h1:bIjVDfnllIU7BJ2DNgfnXvpSvtn8VRwhlsaeUTyUS44=
 golang.org/x/net v0.25.0/go.mod h1:JkAGAh7GEvH74S6FOH42FLoXpXbE/aqXSrIQjXgsiwM=
-golang.org/x/net v0.50.0 h1:ucWh9eiCGyDR3vtzso0WMQinm2Dnt8cFMuQa9K33J60=
-golang.org/x/net v0.50.0/go.mod h1:UgoSli3F/pBgdJBHCTc+tp3gmrU4XswgGRgtnwWTfyM=
+golang.org/x/net v0.51.0 h1:94R/GTO7mt3/4wIKpcR5gkGmRLOuE/2hNGeWq/GBIFo=
+golang.org/x/net v0.51.0/go.mod h1:aamm+2QF5ogm02fjy5Bb7CQ0WMt1/WVM7FtyaTLlA9Y=
 golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
 golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
 golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=

services/current-account/adapters/persistence/account_entity.go

@@ -27,6 +27,7 @@ type CurrentAccountEntity struct {
 	AccountType           string     `gorm:"column:account_type;type:varchar(50);not null"`                       // current, savings, etc. (legacy)
 	InstrumentCode        string     `gorm:"column:instrument_code;type:varchar(32);not null;default:'GBP'"`      // Instrument code (e.g. GBP, kWh)
 	Dimension             string     `gorm:"column:dimension;type:varchar(20);not null;default:'CURRENCY'"`       // Asset dimension (e.g. CURRENCY, ELECTRICITY)
+	Precision             int        `gorm:"column:precision;not null;default:2"`                                 // Decimal places for the instrument (2 for GBP, 3 for kWh, 4 for CARBON_CREDIT)
 	Status                string     `gorm:"column:status;type:varchar(20);not null;default:'active'"`
 	PartyID               uuid.UUID  `gorm:"column:party_id;type:uuid;not null;index"`
 	OrgPartyID            *uuid.UUID `gorm:"column:org_party_id;type:uuid"`             // NULL for personal accounts, set for org-scoped accounts

services/current-account/adapters/persistence/lien_entity.go

@@ -23,8 +23,11 @@ type LienEntity struct {
 	AccountID uuid.UUID `gorm:"not null;index:idx_lien_account_status"`
 
 	// Monetary amount
-	AmountCents int64  `gorm:"not null;check:amount_cents > 0"`
-	Currency    string `gorm:"not null;size:3"`
+	AmountCents    int64  `gorm:"column:amount_cents;not null;check:amount_cents > 0"`
+	Currency       string `gorm:"column:currency;not null;size:3"`         // Legacy column - kept for backward compatibility
+	InstrumentCode string `gorm:"column:instrument_code;not null;size:32"` // Instrument code (e.g. GBP, kWh)
+	Dimension      string `gorm:"column:dimension;not null;size:20"`       // Asset dimension (e.g. CURRENCY, ENERGY)
+	Precision      int    `gorm:"column:precision;not null;default:2"`     // Decimal places for the instrument
 
 	// Bucket identifier for bucket-aware reservations (fungibility key)
 	// Empty string represents the default bucket for backward compatibility

services/current-account/adapters/persistence/lien_repository.go

@@ -10,6 +10,7 @@ import (
 	"github.com/google/uuid"
 	"github.com/meridianhub/meridian/services/current-account/domain"
 	"github.com/meridianhub/meridian/shared/platform/db"
+	"github.com/meridianhub/meridian/shared/platform/quantity"
 	"gorm.io/gorm"
 	"gorm.io/gorm/clause"
 )
@@ -251,11 +252,12 @@ func (r *LienRepository) SumActiveAmountByAccountID(ctx context.Context, account
 	var totalCents int64
 
 	err := r.withTenantTransaction(ctx, func(tx *gorm.DB) error {
-		// First, check for currency consistency (defensive check for data corruption)
+		// First, check for instrument consistency (defensive check for data corruption).
+		// Use instrument_code (not legacy currency) to correctly handle non-CURRENCY liens.
 		countResult := tx.Model(&LienEntity{}).
 			Where("account_id = ? AND status = ? AND (expires_at IS NULL OR expires_at > ?)",
 				accountID, string(domain.LienStatusActive), now).
-			Select("COUNT(DISTINCT currency)").
+			Select("COUNT(DISTINCT instrument_code)").
 			Scan(&currencyCount)
 
 		if countResult.Error != nil {
@@ -293,11 +295,12 @@ func (r *LienRepository) SumActiveAmountByAccountIDAndBucket(ctx context.Context
 	var totalCents int64
 
 	err := r.withTenantTransaction(ctx, func(tx *gorm.DB) error {
-		// First, check for currency consistency (defensive check for data corruption)
+		// First, check for instrument consistency (defensive check for data corruption).
+		// Use instrument_code (not legacy currency) to correctly handle non-CURRENCY liens.
 		countResult := tx.Model(&LienEntity{}).
 			Where("account_id = ? AND bucket_id = ? AND status = ? AND (expires_at IS NULL OR expires_at > ?)",
 				accountID, bucketID, string(domain.LienStatusActive), now).
-			Select("COUNT(DISTINCT currency)").
+			Select("COUNT(DISTINCT instrument_code)").
 			Scan(&currencyCount)
 
 		if countResult.Error != nil {
@@ -328,11 +331,21 @@ func (r *LienRepository) SumActiveAmountByAccountIDAndBucket(ctx context.Context
 func toLienEntity(lien *domain.Lien) *LienEntity {
 	// ToMinorUnitsUnchecked is safe here: domain layer validates amounts before persistence,
 	// so overflow (>92 quadrillion cents) cannot occur for valid liens
+	// Legacy currency column only holds 3-char ISO codes; populate only for CURRENCY dimension.
+	// Non-CURRENCY instruments use instrument_code/dimension/precision columns exclusively.
+	legacyCurrency := ""
+	if lien.Amount.Dimension() == quantity.DimensionCurrency {
+		legacyCurrency = lien.Amount.InstrumentCode()
+	}
+
 	entity := &LienEntity{
 		ID:                    lien.ID,
 		AccountID:             lien.AccountID,
 		AmountCents:           lien.Amount.ToMinorUnitsUnchecked(),
-		Currency:              lien.Amount.InstrumentCode(),
+		Currency:              legacyCurrency,
+		InstrumentCode:        lien.Amount.InstrumentCode(),
+		Dimension:             lien.Amount.Dimension(),
+		Precision:             lien.Amount.Precision(),
 		BucketID:              lien.BucketID,
 		Status:                string(lien.Status),
 		PaymentOrderReference: lien.PaymentOrderReference,
@@ -363,7 +376,14 @@ func toLienEntity(lien *domain.Lien) *LienEntity {
 
 // toLienDomain converts database entity to domain model
 func toLienDomain(entity *LienEntity) (*domain.Lien, error) {
-	amount, err := domain.NewMoney(entity.Currency, entity.AmountCents)
+	// Prefer instrument_code/dimension/precision (new columns) over legacy currency column.
+	// instrument_code is populated for all rows via backfill migration; fall back to currency
+	// only for rows that pre-date the migration (instrument_code would be empty string).
+	instrumentCode := entity.InstrumentCode
+	if instrumentCode == "" {
+		instrumentCode = entity.Currency
+	}
+	amount, err := domain.NewAmountFromInstrument(instrumentCode, entity.Dimension, entity.Precision, entity.AmountCents)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create lien amount from database: %w", err)
 	}

services/current-account/adapters/persistence/lien_repository_test.go

@@ -38,6 +38,9 @@ func setupLienTestDB(t *testing.T) (*gorm.DB, context.Context, func()) {
 		account_id UUID NOT NULL,
 		amount_cents BIGINT NOT NULL,
 		currency VARCHAR(3) NOT NULL,
+		instrument_code VARCHAR(32) NOT NULL DEFAULT '',
+		dimension VARCHAR(20) NOT NULL DEFAULT 'CURRENCY',
+		precision INT NOT NULL DEFAULT 2,
 		bucket_id VARCHAR(255) NOT NULL DEFAULT '',
 		status VARCHAR(20) NOT NULL,
 		payment_order_reference VARCHAR(255) NOT NULL UNIQUE,
@@ -662,6 +665,9 @@ func setupMultiTenantLienTestDB(t *testing.T, tenantIDs ...string) (*gorm.DB, ma
 			account_id UUID NOT NULL,
 			amount_cents BIGINT NOT NULL,
 			currency VARCHAR(3) NOT NULL,
+			instrument_code VARCHAR(32) NOT NULL DEFAULT '',
+			dimension VARCHAR(20) NOT NULL DEFAULT 'CURRENCY',
+			precision INT NOT NULL DEFAULT 2,
 			bucket_id VARCHAR(255) NOT NULL DEFAULT '',
 			status VARCHAR(20) NOT NULL,
 			payment_order_reference VARCHAR(255) NOT NULL UNIQUE,