test: remove stale current_accounts DDL from service test helpers (#1219)

The service test setup functions contained a dead CREATE TABLE for
current_accounts with the old schema (currency VARCHAR(3)). The actual
persistence layer uses an 'account' table auto-migrated by GORM from
CurrentAccountEntity, which already uses instrument_code/dimension.

Remove the unused current_accounts table DDL from four test setup
functions across grpc_service_test, grpc_service_integration_test,
grpc_service_party_integration_test, and lien_service_test.

Co-authored-by: Ben Coombs <bjcoombs@users.noreply.github.com>

Author: bjcoombs

services/current-account/service/grpc_service_integration_test.go

@@ -438,22 +438,6 @@ func setupIntegrationTestDB(t *testing.T) (*gorm.DB, context.Context, func()) {
 	err := db.Exec(fmt.Sprintf("CREATE SCHEMA IF NOT EXISTS %s", pq.QuoteIdentifier(schemaName))).Error
 	require.NoError(t, err)
 
-	// Create the current_accounts table in the tenant schema
-	err = db.Exec(fmt.Sprintf(`CREATE TABLE IF NOT EXISTS %s.current_accounts (
-		id UUID PRIMARY KEY,
-		account_number VARCHAR(255) NOT NULL UNIQUE,
-		party_id UUID NOT NULL,
-		currency VARCHAR(3) NOT NULL,
-		balance_cents BIGINT NOT NULL DEFAULT 0,
-		status VARCHAR(20) NOT NULL,
-		created_at TIMESTAMP WITH TIME ZONE NOT NULL,
-		updated_at TIMESTAMP WITH TIME ZONE NOT NULL,
-		version INT NOT NULL DEFAULT 1,
-		created_by VARCHAR(255),
-		updated_by VARCHAR(255)
-	)`, pq.QuoteIdentifier(schemaName))).Error
-	require.NoError(t, err)
-
 	// Set default search_path to include tenant schema
 	err = db.Exec(fmt.Sprintf("SET search_path TO %s, public", pq.QuoteIdentifier(schemaName))).Error
 	require.NoError(t, err)

services/current-account/service/grpc_service_party_integration_test.go

@@ -138,22 +138,6 @@ func setupPartyIntegrationTestDB(t *testing.T) (*gorm.DB, context.Context, func(
 	err := db.Exec(fmt.Sprintf("CREATE SCHEMA IF NOT EXISTS %s", pq.QuoteIdentifier(schemaName))).Error
 	require.NoError(t, err)
 
-	// Create the current_accounts table in the tenant schema
-	err = db.Exec(fmt.Sprintf(`CREATE TABLE IF NOT EXISTS %s.current_accounts (
-		id UUID PRIMARY KEY,
-		account_number VARCHAR(255) NOT NULL UNIQUE,
-		party_id UUID NOT NULL,
-		currency VARCHAR(3) NOT NULL,
-		balance_cents BIGINT NOT NULL DEFAULT 0,
-		status VARCHAR(20) NOT NULL,
-		created_at TIMESTAMP WITH TIME ZONE NOT NULL,
-		updated_at TIMESTAMP WITH TIME ZONE NOT NULL,
-		version INT NOT NULL DEFAULT 1,
-		created_by VARCHAR(255),
-		updated_by VARCHAR(255)
-	)`, pq.QuoteIdentifier(schemaName))).Error
-	require.NoError(t, err)
-
 	// Set default search_path to include tenant schema
 	err = db.Exec(fmt.Sprintf("SET search_path TO %s, public", pq.QuoteIdentifier(schemaName))).Error
 	require.NoError(t, err)

services/current-account/service/grpc_service_test.go

@@ -314,23 +314,7 @@ func setupTestDB(t *testing.T) (*gorm.DB, context.Context, func()) {
 	err := db.Exec(fmt.Sprintf("CREATE SCHEMA IF NOT EXISTS %s", pq.QuoteIdentifier(schemaName))).Error
 	require.NoError(t, err)
 
-	// Create the current_accounts table in the tenant schema
-	err = db.Exec(fmt.Sprintf(`CREATE TABLE IF NOT EXISTS %s.current_accounts (
-		id UUID PRIMARY KEY,
-		account_number VARCHAR(255) NOT NULL UNIQUE,
-		party_id UUID NOT NULL,
-		currency VARCHAR(3) NOT NULL,
-		balance_cents BIGINT NOT NULL DEFAULT 0,
-		status VARCHAR(20) NOT NULL,
-		created_at TIMESTAMP WITH TIME ZONE NOT NULL,
-		updated_at TIMESTAMP WITH TIME ZONE NOT NULL,
-		version INT NOT NULL DEFAULT 1,
-		created_by VARCHAR(255),
-		updated_by VARCHAR(255)
-	)`, pq.QuoteIdentifier(schemaName))).Error
-	require.NoError(t, err)
-
-	// Set default search_path to include tenant schema
+	// Set default search_path to include tenant schema so queries route to tenant-scoped tables
 	err = db.Exec(fmt.Sprintf("SET search_path TO %s, public", pq.QuoteIdentifier(schemaName))).Error
 	require.NoError(t, err)
 

services/current-account/service/lien_service_test.go

@@ -43,22 +43,6 @@ func setupLienTestDB(t *testing.T) (*gorm.DB, context.Context, func()) {
 	err := db.Exec(fmt.Sprintf("CREATE SCHEMA IF NOT EXISTS %s", pq.QuoteIdentifier(schemaName))).Error
 	require.NoError(t, err)
 
-	// Create the current_accounts table in the tenant schema
-	err = db.Exec(fmt.Sprintf(`CREATE TABLE IF NOT EXISTS %s.current_accounts (
-		id UUID PRIMARY KEY,
-		account_number VARCHAR(255) NOT NULL UNIQUE,
-		party_id UUID NOT NULL,
-		currency VARCHAR(3) NOT NULL,
-		balance_cents BIGINT NOT NULL DEFAULT 0,
-		status VARCHAR(20) NOT NULL,
-		created_at TIMESTAMP WITH TIME ZONE NOT NULL,
-		updated_at TIMESTAMP WITH TIME ZONE NOT NULL,
-		version INT NOT NULL DEFAULT 1,
-		created_by VARCHAR(255),
-		updated_by VARCHAR(255)
-	)`, pq.QuoteIdentifier(schemaName))).Error
-	require.NoError(t, err)
-
 	// Create the lien table in the tenant schema
 	err = db.Exec(fmt.Sprintf(`CREATE TABLE IF NOT EXISTS %s.lien (
 		id UUID PRIMARY KEY,