Skip to content

Commit 3886ae2

Browse files
authored
Remove dead cmd/rebucketing-tool and orphan cmd/audit-consumer (#1233)
* chore: Remove dead cmd/rebucketing-tool and orphan cmd/audit-consumer cmd/rebucketing-tool has no main.go entry point and zero imports anywhere in the codebase. Its functionality was absorbed into cmd/position-tool/internal/rebucket/. cmd/audit-consumer is an orphan duplicate entry point that is never built. The canonical entry point is services/audit-worker/cmd/. Also fixes a stale comment in position-tool referencing the removed package and updates a broken README link in tests/audit-e2e. * docs: Add CLI tools reference guide and ibactl to deployment runbook Add docs/guides/cli-tools.md documenting all operational CLIs: tenantctl, ibactl, instrument-cli, position-tool, market-data-tool, and meridian-cli. These tools had zero discoverability despite being actively used. Add ibactl internal account provisioning step to the production deployment smoke test in the deployment runbook. * docs: Address review feedback on CLI tools guide Clarify intro to note position-tool uses direct DB access and meridian-cli is offline, rather than implying all tools use gRPC. Replace placeholder <tenant-port> with actual port 50056. --------- Co-authored-by: Ben Coombs <bjcoombs@users.noreply.github.com>
1 parent de13347 commit 3886ae2

33 files changed

Lines changed: 183 additions & 7401 deletions

cmd/audit-consumer/main.go

Lines changed: 0 additions & 187 deletions
This file was deleted.

cmd/position-tool/cmd/rebucket.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -189,11 +189,9 @@ var (
189189
)
190190

191191
// executeRebucket performs the actual rebucket operation.
192-
// It integrates with the rebucketing-tool's internal packages for:
193-
// 1) Fetching positions by instrument
194-
// 2) Recalculating bucket keys using instrument CEL expressions
195-
// 3) Batch updating positions with audit logging
196-
// 4) Progress reporting
192+
// It fetches positions by instrument, recalculates bucket keys using
193+
// instrument CEL expressions, batch updates positions with audit logging,
194+
// and reports progress.
197195
func executeRebucket(ctx context.Context, cfg *rebucketConfig) (*rebucketResult, error) {
198196
logger := slog.Default()
199197

cmd/rebucketing-tool/internal/engine/cel_evaluator.go

Lines changed: 0 additions & 126 deletions
This file was deleted.

0 commit comments

Comments
 (0)