fix: address CodeRabbit review comments

- Add nil logger guard in NewGRPCReferenceDataProvider to prevent
  panic when Logger is not provided in config
- Remove AccountTypeClient wiring from main.go because the identity-only
  method resolver cannot resolve non-identity method IDs that account
  type lookups may return; will be wired when a full method resolver
  is available

Author: bjcoombs

services/reconciliation/cmd/main.go

@@ -557,8 +557,10 @@ func buildValuationComponents(cfg *config.Config, logger *slog.Logger) (valuatio
 			refDataConn = nil
 		} else {
 			providerCfg.InstrumentClient = referencedatav1.NewReferenceDataServiceClient(refDataConn)
-			providerCfg.AccountTypeClient = referencedatav1.NewAccountTypeRegistryServiceClient(refDataConn)
-			logger.Info("reference data gRPC clients configured",
+			// AccountTypeClient is not wired here because the identity-only method resolver
+			// cannot resolve non-identity method IDs that account type lookups may return.
+			// Wire AccountTypeClient when a full gRPC method resolver is available.
+			logger.Info("reference data gRPC client configured for instrument lookups",
 				"url", cfg.Services.ReferenceDataURL)
 		}
 	} else {

services/reconciliation/service/grpc_reference_data_provider.go

@@ -42,11 +42,16 @@ type GRPCReferenceDataProviderConfig struct {
 
 // NewGRPCReferenceDataProvider creates a new provider backed by Reference Data gRPC services.
 func NewGRPCReferenceDataProvider(cfg GRPCReferenceDataProviderConfig) *GRPCReferenceDataProvider {
+	logger := cfg.Logger
+	if logger == nil {
+		logger = slog.Default()
+	}
+
 	return &GRPCReferenceDataProvider{
 		instrumentClient:  cfg.InstrumentClient,
 		accountTypeClient: cfg.AccountTypeClient,
 		defaultMethodID:   cfg.DefaultMethodID,
-		logger:            cfg.Logger,
+		logger:            logger,
 	}
 }