fix: resilient account type registration for deprecated state (#2103)

* fix: allow DEPRECATED -> ACTIVE transition for convergent manifest apply

When a manifest is re-applied to a tenant that previously had different
manifests, instruments and account types from the prior manifest get
deprecated. When the new manifest re-declares them, the activate step
fails because DEPRECATED was terminal.

Allow DEPRECATED -> ACTIVE transition for both instruments and account
types, enabling convergent re-application of manifests.

* test: update tests for DEPRECATED -> ACTIVE reactivation

Update tests that asserted DEPRECATED was terminal to reflect the new
convergent-apply behavior where DEPRECATED instruments and account types
can be reactivated.

* test: fix remaining deprecated-terminal assertions in instrument registry

* fix: handle DEPRECATED account types and sagas in convergent apply

Account type ActivateAccountType had a hardcoded != StatusDraft check
that rejected DEPRECATED status even though the transition table now
allows it. Use CanTransitionTo instead.

Also add idempotent ACTIVE check to saga ActivateSaga, and reactive
fallback for account type activation in the applier client.

* fix: correct GetActiveDefinition method name in reactive fallback

* test: update tests for DEPRECATED reactivation and saga idempotency

- Account type: DEPRECATED activation now succeeds (not ErrNotDraft)
- Saga: ACTIVE to ACTIVE is now idempotent (not ErrNotDraft)
- Bump function size baseline to 186

* fix: improve account type registration resilience for deprecated state

Improve reactive fallback for ActivateAccountType to handle both
FailedPrecondition and NotFound errors (the latter happens when
CreateDraft was a no-op and the returned ID doesn't exist in the DB).

---------

Co-authored-by: Ben Coombs <bjcoombs@users.noreply.github.com>

Author: bjcoombs

services/control-plane/internal/applier/reference_data_client.go

@@ -180,11 +180,16 @@ func (c *ReferenceDataClient) RegisterAccountType(ctx *saga.StarlarkContext, par
 	callCtx := prepareCallContext(ctx)
 
 	// Proactive check: if already ACTIVE, return success immediately.
+	// Also handle DEPRECATED by attempting reactivation via the registry
+	// (which now allows DEPRECATED -> ACTIVE transitions).
 	existing, lookupErr := c.accountTypes.GetActiveDefinition(callCtx, &referencedatav1.GetActiveDefinitionRequest{
 		Code: code,
 	})
-	if lookupErr == nil && existing.GetDefinition().GetStatus() == referencedatav1.AccountTypeStatus_ACCOUNT_TYPE_STATUS_ACTIVE {
-		return accountTypeResult(existing.GetDefinition()), nil
+	if lookupErr == nil {
+		defStatus := existing.GetDefinition().GetStatus()
+		if defStatus == referencedatav1.AccountTypeStatus_ACCOUNT_TYPE_STATUS_ACTIVE {
+			return accountTypeResult(existing.GetDefinition()), nil
+		}
 	}
 
 	// Proceed with create + activate flow.
@@ -202,8 +207,9 @@ func (c *ReferenceDataClient) RegisterAccountType(ctx *saga.StarlarkContext, par
 		Id: draftResp.GetDefinition().GetId(),
 	})
 	if err != nil {
-		// Reactive fallback: if FailedPrecondition and account type is ACTIVE, treat as success.
-		if status.Code(err) == codes.FailedPrecondition {
+		// Reactive fallback: if FailedPrecondition or NotFound (wrong ID from CreateDraft
+		// no-op), look up by code and return if ACTIVE.
+		if status.Code(err) == codes.FailedPrecondition || status.Code(err) == codes.NotFound {
 			retryLookup, retryErr := c.accountTypes.GetActiveDefinition(callCtx, &referencedatav1.GetActiveDefinitionRequest{
 				Code: code,
 			})