feat: add batch account_ids filter to position-keeping and financial-accounting (#1883)

Merging with UNSTABLE - all failures pre-existing in services/identity/dex/. Zero errors from position-keeping or financial-accounting changes.

Author: bjcoombs

api/proto/meridian/financial_accounting/v1/financial_accounting.pb.go

@@ -440,6 +440,19 @@ message ListLedgerPostingsRequest {
   meridian.common.v1.TransactionStatus status = 8 [(buf.validate.field).enum = {
     defined_only: true
   }];
+
+  // account_ids filters by multiple account identifiers (optional, max 100).
+  // When provided, takes precedence over account_id.
+  repeated string account_ids = 9 [(buf.validate.field).repeated = {
+    max_items: 100
+    items: {
+      string: {
+        min_len: 1
+        max_len: 255
+        pattern: "^[a-zA-Z0-9_-]+$"
+      }
+    }
+  }];
 }
 
 // ListLedgerPostingsResponse returns a page of ledger postings.

api/proto/meridian/financial_accounting/v1/financial_accounting.proto

@@ -453,6 +453,7 @@ message BulkImportTransactionsResponse {
 // ListFinancialPositionLogsRequest lists financial position logs with filtering.
 message ListFinancialPositionLogsRequest {
   // account_id filters logs by account (optional).
+  // Deprecated in favour of account_ids. When account_ids is provided, account_id is ignored.
   string account_id = 1 [(buf.validate.field).string.max_len = 255];
 
   // status filters logs by current status (optional).
@@ -463,6 +464,18 @@ message ListFinancialPositionLogsRequest {
 
   // pagination controls the page size and offset.
   meridian.common.v1.Pagination pagination = 4;
+
+  // account_ids filters logs by multiple accounts (optional, max 100).
+  // When provided, takes precedence over account_id.
+  repeated string account_ids = 5 [(buf.validate.field).repeated = {
+    max_items: 100
+    items: {
+      string: {
+        min_len: 1
+        max_len: 255
+      }
+    }
+  }];
 }
 
 // ListFinancialPositionLogsResponse returns a list of logs.

api/proto/meridian/position_keeping/v1/position_keeping.pb.go

@@ -612,9 +612,12 @@ type ListPostingsParams struct {
 	// BookingLogID filters by parent booking log (empty for no filter)
 	BookingLogID *uuid.UUID
 
-	// AccountID filters by account identifier (empty for no filter)
+	// AccountID filters by account identifier (empty for no filter). Ignored when AccountIDs is non-empty.
 	AccountID string
 
+	// AccountIDs filters by multiple account identifiers (empty for no filter). Takes precedence over AccountID.
+	AccountIDs []string
+
 	// PostingDirection filters by DEBIT or CREDIT (empty for no filter)
 	PostingDirection string
 
@@ -670,8 +673,10 @@ func (r *LedgerRepository) ListPostings(ctx context.Context, params ListPostings
 			query = query.Where("financial_booking_log_id = ?", *params.BookingLogID)
 		}
 
-		// Apply account ID filter if provided
-		if params.AccountID != "" {
+		// Apply account ID filter - AccountIDs takes precedence over AccountID
+		if len(params.AccountIDs) > 0 {
+			query = query.Where("account_id IN ?", params.AccountIDs)
+		} else if params.AccountID != "" {
 			query = query.Where("account_id = ?", params.AccountID)
 		}
 

api/proto/meridian/position_keeping/v1/position_keeping.proto

@@ -798,3 +798,64 @@ func TestAuditChangedByDefaultsToSystem(t *testing.T) {
 	require.NotNil(t, outbox.ChangedBy)
 	assert.Equal(t, "system", *outbox.ChangedBy)
 }
+
+func TestListPostings_FilterByAccountIDs(t *testing.T) {
+	db, ctx, cleanup := setupTestDB(t)
+	defer cleanup()
+
+	repo := NewLedgerRepository(db)
+
+	bookingLogID := uuid.New()
+	bookingLog := &FinancialBookingLogEntity{
+		ID:                      bookingLogID,
+		FinancialAccountType:    "DEBIT",
+		ProductServiceReference: "PROD-001",
+		BusinessUnitReference:   "BU-001",
+		ChartOfAccountsRules:    "{}",
+		BaseCurrency:            "GBP",
+		Status:                  "ACTIVE",
+		IdempotencyKey:          "test-key-" + uuid.New().String(),
+		CreatedAt:               time.Now(),
+		UpdatedAt:               time.Now(),
+		Version:                 1,
+	}
+	require.NoError(t, db.Create(bookingLog).Error)
+
+	gbpInstrument := domain.MustCurrencyToInstrument(domain.CurrencyGBP)
+	money := domain.NewMoney(decimal.NewFromFloat(100.00), gbpInstrument)
+
+	for _, accID := range []string{"ACC-X1", "ACC-X2", "ACC-OTHER"} {
+		p := &domain.LedgerPosting{
+			ID:                    uuid.New(),
+			FinancialBookingLogID: bookingLogID,
+			Direction:             domain.PostingDirectionDebit,
+			Amount:                money,
+			AccountID:             accID,
+			ValueDate:             time.Now(),
+			Status:                domain.TransactionStatusPending,
+			CreatedAt:             time.Now(),
+		}
+		require.NoError(t, repo.SavePosting(ctx, p))
+	}
+
+	// Filter by two accounts
+	result, err := repo.ListPostings(ctx, ListPostingsParams{
+		PageSize:   10,
+		AccountIDs: []string{"ACC-X1", "ACC-X2"},
+	})
+	require.NoError(t, err)
+	require.Len(t, result.Postings, 2)
+	for _, p := range result.Postings {
+		assert.Contains(t, []string{"ACC-X1", "ACC-X2"}, p.AccountID)
+	}
+
+	// AccountIDs takes precedence over AccountID
+	result, err = repo.ListPostings(ctx, ListPostingsParams{
+		PageSize:   10,
+		AccountID:  "ACC-OTHER",
+		AccountIDs: []string{"ACC-X1"},
+	})
+	require.NoError(t, err)
+	require.Len(t, result.Postings, 1)
+	assert.Equal(t, "ACC-X1", result.Postings[0].AccountID)
+}

frontend/src/api/gen/meridian/financial_accounting/v1/financial_accounting_pb.ts

@@ -1484,6 +1484,114 @@ func TestUpdateFinancialBookingLog_Integration_NonPostedTransition_SkipsValidati
 	assert.Equal(t, commonv1.TransactionStatus_TRANSACTION_STATUS_FAILED, resp.FinancialBookingLog.Status)
 }
 
+// TestListLedgerPostings_Integration_FilterByAccountIDs tests filtering by multiple account IDs.
+func TestListLedgerPostings_Integration_FilterByAccountIDs(t *testing.T) {
+	ts, _ := setupIntegrationTest(t)
+	defer ts.cleanup()
+
+	ctx, cancel := context.WithTimeout(ts.ctx, 10*time.Second)
+	defer cancel()
+
+	bookingLogID := createTestBookingLog(t, ts.db, ts.ctx)
+	gbpInstrument := domain.MustCurrencyToInstrument(domain.CurrencyGBP)
+	amount := domain.NewMoney(decimal.NewFromInt(100), gbpInstrument)
+
+	// Create postings for three different accounts
+	for _, accID := range []string{"ACC-A1", "ACC-A2", "ACC-OTHER"} {
+		posting := &domain.LedgerPosting{
+			ID:                    uuid.New(),
+			FinancialBookingLogID: bookingLogID,
+			Direction:             domain.PostingDirectionDebit,
+			Amount:                amount,
+			AccountID:             accID,
+			ValueDate:             time.Now(),
+			Status:                domain.TransactionStatusPending,
+			CreatedAt:             time.Now(),
+		}
+		require.NoError(t, ts.repo.SavePosting(ctx, posting))
+	}
+
+	// Filter for two accounts only
+	resp, err := ts.grpcClient.ListLedgerPostings(ctx, &financialaccountingv1.ListLedgerPostingsRequest{
+		AccountIds: []string{"ACC-A1", "ACC-A2"},
+		Pagination: &commonv1.Pagination{PageSize: 10},
+	})
+
+	require.NoError(t, err)
+	require.NotNil(t, resp)
+	assert.Len(t, resp.LedgerPostings, 2)
+	for _, p := range resp.LedgerPostings {
+		assert.Contains(t, []string{"ACC-A1", "ACC-A2"}, p.AccountId)
+	}
+}
+
+// TestListLedgerPostings_Integration_AccountIDs_TakesPrecedence verifies account_ids takes
+// precedence over account_id when both are provided.
+func TestListLedgerPostings_Integration_AccountIDs_TakesPrecedence(t *testing.T) {
+	ts, _ := setupIntegrationTest(t)
+	defer ts.cleanup()
+
+	ctx, cancel := context.WithTimeout(ts.ctx, 10*time.Second)
+	defer cancel()
+
+	bookingLogID := createTestBookingLog(t, ts.db, ts.ctx)
+	gbpInstrument := domain.MustCurrencyToInstrument(domain.CurrencyGBP)
+	amount := domain.NewMoney(decimal.NewFromInt(100), gbpInstrument)
+
+	for _, accID := range []string{"ACC-B1", "ACC-B2", "ACC-IGNORED"} {
+		posting := &domain.LedgerPosting{
+			ID:                    uuid.New(),
+			FinancialBookingLogID: bookingLogID,
+			Direction:             domain.PostingDirectionDebit,
+			Amount:                amount,
+			AccountID:             accID,
+			ValueDate:             time.Now(),
+			Status:                domain.TransactionStatusPending,
+			CreatedAt:             time.Now(),
+		}
+		require.NoError(t, ts.repo.SavePosting(ctx, posting))
+	}
+
+	// account_ids should take precedence over account_id
+	resp, err := ts.grpcClient.ListLedgerPostings(ctx, &financialaccountingv1.ListLedgerPostingsRequest{
+		AccountId:  "ACC-IGNORED",
+		AccountIds: []string{"ACC-B1", "ACC-B2"},
+		Pagination: &commonv1.Pagination{PageSize: 10},
+	})
+
+	require.NoError(t, err)
+	require.NotNil(t, resp)
+	assert.Len(t, resp.LedgerPostings, 2)
+	for _, p := range resp.LedgerPostings {
+		assert.Contains(t, []string{"ACC-B1", "ACC-B2"}, p.AccountId)
+	}
+}
+
+// TestListLedgerPostings_Integration_AccountIDs_MaxLimitRejected tests that >100 account_ids
+// is rejected with InvalidArgument.
+func TestListLedgerPostings_Integration_AccountIDs_MaxLimitRejected(t *testing.T) {
+	ts, _ := setupIntegrationTest(t)
+	defer ts.cleanup()
+
+	ctx, cancel := context.WithTimeout(ts.ctx, 10*time.Second)
+	defer cancel()
+
+	tooMany := make([]string, 101)
+	for i := range tooMany {
+		tooMany[i] = "ACC-001"
+	}
+
+	_, err := ts.grpcClient.ListLedgerPostings(ctx, &financialaccountingv1.ListLedgerPostingsRequest{
+		AccountIds: tooMany,
+		Pagination: &commonv1.Pagination{PageSize: 10},
+	})
+
+	require.Error(t, err)
+	st, ok := status.FromError(err)
+	require.True(t, ok)
+	assert.Equal(t, codes.InvalidArgument, st.Code())
+}
+
 // TestUpdateFinancialBookingLog_Integration_CancelledTransition_SkipsValidation tests that
 // transitions to CANCELLED skip balance validation.
 func TestUpdateFinancialBookingLog_Integration_CancelledTransition_SkipsValidation(t *testing.T) {

frontend/src/api/gen/meridian/position_keeping/v1/position_keeping_pb.ts

@@ -157,8 +157,13 @@ func (s *FinancialAccountingService) ListLedgerPostings(
 		params.BookingLogID = &bookingLogID
 	}
 
-	// Apply account ID filter if provided
-	if req.AccountId != "" {
+	// Apply account ID filter - account_ids takes precedence over account_id
+	if len(req.AccountIds) > 0 {
+		if len(req.AccountIds) > 100 {
+			return nil, status.Error(codes.InvalidArgument, "account_ids must not exceed 100 items")
+		}
+		params.AccountIDs = req.AccountIds
+	} else if req.AccountId != "" {
 		params.AccountID = req.AccountId
 	}