Skip to content

feat: move transactions page to features module and clean up pages dir#1421

Merged
bjcoombs merged 1 commit intodevelopfrom
034-frontend-alignment--11--cleanup-pages
Mar 5, 2026
Merged

feat: move transactions page to features module and clean up pages dir#1421
bjcoombs merged 1 commit intodevelopfrom
034-frontend-alignment--11--cleanup-pages

Conversation

@bjcoombs
Copy link
Copy Markdown
Collaborator

@bjcoombs bjcoombs commented Mar 4, 2026

Summary

  • Moves TransactionsPage from pages/transactions/ to features/transactions/pages/
  • Creates a features/transactions/index.ts public API module
  • Updates App.tsx to import TransactionsPage from @/features/transactions instead of @/pages/transactions
  • Removes the now-empty pages/ directory, completing the migration of all pages to feature modules

Changes Made

  • frontend/src/features/transactions/pages/index.tsx — moved from pages/transactions/index.tsx (no logic changes)
  • frontend/src/features/transactions/index.ts — new public API barrel file
  • frontend/src/App.tsx — updated import path from @/pages/transactions to @/features/transactions

Test Plan

  • All existing tests pass (4 pre-existing failures unrelated to this change — AccountStatus enum undefined in accounts/parties tests)
  • No lint errors (0 errors, 2 pre-existing warnings about TanStack Table compatibility)
  • No @/pages/ imports remain anywhere in the frontend source
  • pages/ directory fully removed

Move TransactionsPage from pages/transactions/ to features/transactions/pages/,
create a feature module index, update App.tsx import to use @/features/transactions,
and remove the now-empty pages/ directory.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1ee40ff2-7bbd-473d-86ed-31547d9c66cf

📥 Commits

Reviewing files that changed from the base of the PR and between 5f90221 and 021611b.

📒 Files selected for processing (3)
  • frontend/src/App.tsx
  • frontend/src/features/transactions/index.ts
  • frontend/src/features/transactions/pages/index.tsx

📝 Walkthrough

Walkthrough

The TransactionsPage component is reorganized within the codebase by moving its export to a new feature-based directory structure (@/features/transactions). The App.tsx import path is updated to reference the new location, maintaining the same public interface without functional changes.

Changes

Cohort / File(s) Summary
App Import Update
frontend/src/App.tsx
Import path for TransactionsPage changed from @/pages/transactions to @/features/transactions.
Feature Module Export
frontend/src/features/transactions/index.ts
New barrel export added: TransactionsPage exported from ./pages/index to support the feature-based module structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: moving the transactions page to the features module and cleaning up the pages directory, which matches the actual changeset.
Description check ✅ Passed The description is directly related to the changeset, providing clear details about the file movements, import path updates, and the overall refactoring objective.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 034-frontend-alignment--11--cleanup-pages

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Copy Markdown

claude Bot commented Mar 4, 2026

Claude Code Review

Commit: 021611b | CI: running (security and proto checks passing)

Summary

Clean, minimal PR that completes the migration of all page components into feature modules. The TransactionsPage is moved from pages/transactions/ to features/transactions/pages/ with a proper barrel export, and the App.tsx import is updated accordingly. The now-empty pages/ directory is removed. No logic changes — this is a pure structural reorganization.

This satisfies the requirement to clean up the legacy pages/ directory and align with the feature-module pattern used by all other pages.

Risk Assessment

Area Level Detail
Blast radius Low Single import path change; only affects transactions page loading
Rollback Safe Trivially reversible file move
Scale Low No runtime impact — import path only
Cross-system Low Frontend-only, no backend changes
Migration N/A No database changes

Findings

No issues found. The change is consistent with the pattern established in the prior PR (#1416) that moved configuration pages to feature modules. The barrel file follows the same export { Page } from './pages/index' convention used by other feature modules (e.g., features/accounts, features/payments). The pages/ directory is confirmed fully removed.

Bot Review Notes

No unresolved bot threads at time of review. CodeRabbit review still pending.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean structural change — completes the pages-to-features migration. No issues found. See summary comment for details.

@bjcoombs bjcoombs merged commit 4f987a4 into develop Mar 5, 2026
44 of 46 checks passed
@bjcoombs bjcoombs deleted the 034-frontend-alignment--11--cleanup-pages branch March 5, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant