Skip to content

Commit 59fcc91

Browse files
author
eschleb
committed
Add installContext to VersionAwareTask test
1 parent 25d574a commit 59fcc91

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

core/src/main/java/com/merkle/oss/magnolia/setup/EnhancedModuleVersionHandler.java

+8-8
Original file line numberDiff line numberDiff line change
@@ -90,38 +90,38 @@ private boolean isSnapshot(final Version version) {
9090
}
9191

9292
protected Stream<Task> getInstallTasks(final InstallContext installContext, final Version forVersion) {
93-
return filter(installTasks, forVersion, null);
93+
return filter(installTasks, installContext, forVersion, null);
9494
}
9595

9696
protected Stream<Task> getInstallAndUpdateTasks(final InstallContext installContext, final Version forVersion, @Nullable final Version fromVersion) {
97-
return filter(installAndUpdateTasks, forVersion, fromVersion);
97+
return filter(installAndUpdateTasks, installContext, forVersion, fromVersion);
9898
}
9999

100100
protected Stream<Task> getUpdateTasks(final InstallContext installContext, final Version forVersion, @Nullable final Version fromVersion) {
101-
return filter(updateTasks, forVersion, fromVersion);
101+
return filter(updateTasks, installContext, forVersion, fromVersion);
102102
}
103103

104104
protected Stream<Task> getModuleStartupTasks(final InstallContext installContext, final Version forVersion, @Nullable final Version fromVersion) {
105-
return filter(moduleStartupTasks, forVersion, fromVersion);
105+
return filter(moduleStartupTasks, installContext, forVersion, fromVersion);
106106
}
107107

108108
protected Stream<Task> getSnapshotStartupTasks(final InstallContext installContext, final Version forVersion, @Nullable final Version fromVersion) {
109109
return Stream.of(
110-
filter(snapshotStartupTasks, forVersion, fromVersion),
110+
filter(snapshotStartupTasks, installContext, forVersion, fromVersion),
111111
// execute all general install and update tasks on snapshot
112112
getInstallAndUpdateTasks(installContext, forVersion, fromVersion),
113113
getUpdateTasks(installContext, forVersion, fromVersion)
114114
).flatMap(Function.identity());
115115
}
116116

117117
protected Stream<Task> getLocalDevelopmentStartupTasks(final InstallContext installContext, final Version forVersion, @Nullable final Version fromVersion) {
118-
return filter(localDevelopmentStartupTasks, forVersion, fromVersion);
118+
return filter(localDevelopmentStartupTasks, installContext, forVersion, fromVersion);
119119
}
120120

121-
protected Stream<Task> filter(final Collection<? extends VersionAwareTask> tasks, final Version forVersion, @Nullable final Version fromVersion) {
121+
protected Stream<Task> filter(final Collection<? extends VersionAwareTask> tasks, final InstallContext installContext, final Version forVersion, @Nullable final Version fromVersion) {
122122
return tasks
123123
.stream()
124-
.filter(task -> task.test(forVersion, fromVersion))
124+
.filter(task -> task.test(installContext, forVersion, fromVersion))
125125
.map(task -> task);
126126
}
127127
}

core/src/main/java/com/merkle/oss/magnolia/setup/task/type/VersionAwareTask.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
package com.merkle.oss.magnolia.setup.task.type;
22

3+
import info.magnolia.module.InstallContext;
34
import info.magnolia.module.delta.Task;
45
import info.magnolia.module.model.Version;
56

67
import java.util.Optional;
7-
import java.util.function.BiPredicate;
8-
import java.util.function.Predicate;
98

109
import javax.annotation.Nullable;
1110

12-
public interface VersionAwareTask extends Task, BiPredicate<Version, Version> {
11+
public interface VersionAwareTask extends Task {
1312

14-
@Override
15-
default boolean test(final Version forVersion, @Nullable final Version fromVersion) {
13+
default boolean test(final InstallContext installContext, final Version forVersion, @Nullable final Version fromVersion) {
1614
return true;
1715
}
1816

0 commit comments

Comments
 (0)