Fix nullPointer on new install

eschleb · eschleb · commit c676b1899293 · 2024-10-21T11:38:38.000+02:00
diff --git a/core/src/main/java/com/merkle/oss/magnolia/setup/EnhancedModuleVersionHandler.java b/core/src/main/java/com/merkle/oss/magnolia/setup/EnhancedModuleVersionHandler.java
@@ -65,8 +65,8 @@ private Stream<Delta> getDeltas(final InstallContext installContext, final Versi
     }
 
     private Delta getInstallAndUpdateTasksDelta(final InstallContext installContext, final Version forVersion, @Nullable final Version versionFrom) {
-        final boolean isUpdate = forVersion.isStrictlyAfter(versionFrom);
         final boolean isInstall = versionFrom == null;
+        final boolean isUpdate = !isInstall && forVersion.isStrictlyAfter(versionFrom);
 
         return DeltaBuilder.install(forVersion, "setup-task install and update").addTasks(Stream.of(
                 isInstall ? getInstallTasks(installContext, forVersion) : Stream.<Task>empty(),

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,8 @@ private Stream<Delta> getDeltas(final InstallContext installContext, final Versi`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`private Delta getInstallAndUpdateTasksDelta(final InstallContext installContext, final Version forVersion, @Nullable final Version versionFrom) {`
`68`		`- final boolean isUpdate = forVersion.isStrictlyAfter(versionFrom);`
`69`	`68`	`final boolean isInstall = versionFrom == null;`
	`69`	`+ final boolean isUpdate = !isInstall && forVersion.isStrictlyAfter(versionFrom);`
`70`	`70`
`71`	`71`	`return DeltaBuilder.install(forVersion, "setup-task install and update").addTasks(Stream.of(`
`72`	`72`	`isInstall ? getInstallTasks(installContext, forVersion) : Stream.<Task>empty(),`