Merge pull request #38 from merlos/feature/add-tests

Add unit testing to model

Author: merlos

.gitignore

@@ -32,3 +32,9 @@
 
 # Ignore master key for decrypting credentials and more.
 /config/master.key
+
+# ignore coverage
+/coverage
+
+# Ignore Mac system files
+.DS_Store

Gemfile

@@ -64,4 +64,5 @@ group :test do
   # Use system testing [https://guides.rubyonrails.org/testing.html#system-testing]
   gem "capybara"
   gem "selenium-webdriver"
+  gem "simplecov", require: false
 end

Gemfile.lock

@@ -110,6 +110,7 @@ GEM
     delayed_job_active_record (4.1.11)
       activerecord (>= 3.0, < 9.0)
       delayed_job (>= 3.0, < 5)
+    docile (1.4.1)
     dotenv (3.1.4)
     drb (2.2.1)
     ed25519 (1.3.0)
@@ -287,6 +288,12 @@ GEM
       rexml (~> 3.2, >= 3.2.5)
       rubyzip (>= 1.2.2, < 3.0)
       websocket (~> 1.0)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.13.1)
+    simplecov_json_formatter (0.1.4)
     solid_cable (3.0.4)
       actioncable (>= 7.2)
       activejob (>= 7.2)
@@ -382,6 +389,7 @@ DEPENDENCIES
   rails (~> 8.0.0)
   rubocop-rails-omakase
   selenium-webdriver
+  simplecov
   solid_cable
   solid_cache
   solid_queue

test/models/message_test.rb

@@ -1,7 +1,53 @@
 require "test_helper"
 
 class MessageTest < ActiveSupport::TestCase
-  # test "the truth" do
-  #   assert true
-  # end
+  include ActiveJob::TestHelper
+  def setup
+    @message = Message.new(
+      views_remaining: 10,
+      encrypted_content: "encrypted content",
+    )
+  end
+
+  test "should be valid with valid attributes" do
+    assert @message.valid?
+  end
+
+  test "should not be valid with views_remaining less than 1" do
+    @message.views_remaining = 0
+    assert_not @message.valid?
+  end
+
+  test "should not be valid with views_remaining greater than 50" do
+    @message.views_remaining = 51
+    assert_not @message.valid?
+  end
+
+  test "should not be valid with expiration_time beyond limit" do
+    @message.expiration_time = Time.current + Message::MAX_ALLOWED_TIME + 1.day
+    assert_not @message.valid?
+  end
+
+  test "should set defaults before create" do
+    @message.save
+    assert_not_nil @message.id
+  end
+
+  test "should auto delete expired messages" do
+    @message.expiration_time = Time.current - 1.day
+    @message.save
+    # fixtures has 2 messages + this one
+    assert_difference("Message.count", -3) do
+      Message.auto_delete_expired
+    end
+  end
+
+  test "should destroy message if it has expired" do
+    @message.expiration_time = Time.current - 1.day
+    @message.save
+    assert @message.has_expired
+    assert_difference("Message.count", -1) do
+      @message.auto_delete_expired
+    end
+  end
 end

test/simplecov_helper.rb

@@ -0,0 +1,10 @@
+require "simplecov"
+SimpleCov.start "rails" do
+  add_filter "/bin/"
+  add_filter "/db/"
+  add_filter "/spec/"
+  add_filter "/test/"
+
+  # Set minimum coverage percentage
+  # minimum_coverage 90
+end

test/test_helper.rb

@@ -1,4 +1,5 @@
 ENV["RAILS_ENV"] ||= "test"
+require_relative "simplecov_helper"
 require_relative "../config/environment"
 require "rails/test_help"