Skip to content

Prettier Scans /demos/dev/ failing pnpm tests  #5108

Closed
@FutzMonitor

Description

Description

Currently Prettier checks against the /demos/dev/ directory which causes the tests ran with pnpm test to fail if a file fails. I think it makes sense to check against the example.html file since that's a template that shouldn't change but for any other file there is no benefit to formatting the code properly because they are untracked per the .gitignore file.

Steps to reproduce

  1. Create an HTML file inside of the /demos/dev/ directory. You can simply copy the example.html file and change its name.
  2. Modify the file so that it doesn't abide by Prettier code formatting rules.
  3. Try running pnpm test.
  4. You will notice that the command stops at your file since it doesn't obey the Prettier code formatting rules.

Screenshots

No response

Code Sample

No response

Setup

  • Mermaid version: 10.6.1

Suggested Solutions

Adding some code to the prettierignore file so that the Prettier code formmatter doesn't check the /demos/dev/ directory.

Additional Context

No response

Metadata

Assignees

No one assigned

    Labels

    Status: TriageNeeds to be verified, categorized, etcType: Bug / ErrorSomething isn't working or is incorrect

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions