Merge pull request #8 from augusthorlen0/add-more-custom-attributes

JohannesRudolph · web-flow · commit 52b8e9586188 · 2024-12-04T15:18:02.000+01:00
Add more custom attributes
diff --git a/tap_personio/streams.py b/tap_personio/streams.py
@@ -90,6 +90,12 @@ def schema(self):
                         th.Property("percentage", th.NumberType())
                     )
                 )
+            elif personio_id == "supervisor":
+                json_type = th.ObjectType()
+            elif personio_id == "subcompany":
+                json_type = th.ObjectType()
+            elif personio_id == "office":
+                json_type = th.ObjectType()
             # note: the PersonioAPI is a mess, we probably need more here
 
             properties.append(th.Property(personio_id, json_type, description=attr["label"]))            

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,12 @@ def schema(self):`
`90`	`90`	`th.Property("percentage", th.NumberType())`
`91`	`91`	`)`
`92`	`92`	`)`
	`93`	`+ elif personio_id == "supervisor":`
	`94`	`+ json_type = th.ObjectType()`
	`95`	`+ elif personio_id == "subcompany":`
	`96`	`+ json_type = th.ObjectType()`
	`97`	`+ elif personio_id == "office":`
	`98`	`+ json_type = th.ObjectType()`
`93`	`99`	`# note: the PersonioAPI is a mess, we probably need more here`
`94`	`100`
`95`	`101`	`properties.append(th.Property(personio_id, json_type, description=attr["label"]))`