Commit 4739ad6
committed
Fix GPS +8mA power leak: assert reset pin in stop()
Root cause: MicroNMEALocationProvider::stop() was not asserting the
reset pin. On boards like the Heltec T114 where GPS_RESET (pin 38) is
the same as PIN_3V3_EN, begin() sets pin 38 HIGH (powering the 3V3
rail) but stop() never set it back LOW. This left the GPS module
powered even when disabled, causing +8mA constant draw.
Also reverts previous Serial1.end()/PSEL workaround attempts - the
UART hang was a symptom of the GPS still being powered and sending
NMEA data, not the root cause.
Adds gps_active guard on _location->loop() to avoid processing NMEA
data when GPS is disabled.
Fixes #16281 parent 71d8e57 commit 4739ad6
2 files changed
Lines changed: 4 additions & 22 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
583 | 583 | | |
584 | 584 | | |
585 | 585 | | |
586 | | - | |
587 | | - | |
588 | | - | |
589 | | - | |
590 | | - | |
591 | | - | |
592 | | - | |
593 | | - | |
594 | 586 | | |
595 | 587 | | |
596 | 588 | | |
| |||
688 | 680 | | |
689 | 681 | | |
690 | 682 | | |
691 | | - | |
692 | | - | |
693 | | - | |
694 | | - | |
695 | | - | |
696 | | - | |
697 | | - | |
698 | | - | |
699 | 683 | | |
700 | 684 | | |
701 | 685 | | |
| |||
713 | 697 | | |
714 | 698 | | |
715 | 699 | | |
716 | | - | |
717 | | - | |
718 | | - | |
719 | | - | |
720 | | - | |
721 | 700 | | |
722 | 701 | | |
723 | 702 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
83 | 86 | | |
84 | 87 | | |
85 | 88 | | |
| |||
0 commit comments