Merge pull request #2460 from liamcottle/ui/startup-mute

liamcottle · web-flow · commit 679fb9c0abc6 · 2026-05-02T02:24:37.000+12:00
Don't play startup tune if buzzer pref disabled
diff --git a/examples/companion_radio/ui-new/UITask.cpp b/examples/companion_radio/ui-new/UITask.cpp
@@ -575,6 +575,7 @@ void UITask::begin(DisplayDriver* display, SensorManager* sensors, NodePrefs* no
 #ifdef PIN_BUZZER
   buzzer.begin();
   buzzer.quiet(_node_prefs->buzzer_quiet);
+  buzzer.startup();
 #endif
 
 #ifdef PIN_VIBRATION
diff --git a/examples/companion_radio/ui-orig/UITask.cpp b/examples/companion_radio/ui-orig/UITask.cpp
@@ -57,6 +57,7 @@ void UITask::begin(DisplayDriver* display, SensorManager* sensors, NodePrefs* no
 #ifdef PIN_BUZZER
   buzzer.begin();
   buzzer.quiet(_node_prefs->buzzer_quiet);
+  buzzer.startup();
 #endif
 
   // Initialize digital button if available
diff --git a/src/helpers/ui/buzzer.cpp b/src/helpers/ui/buzzer.cpp
@@ -12,7 +12,6 @@ void genericBuzzer::begin() {
     quiet(false);
     pinMode(PIN_BUZZER, OUTPUT);
     digitalWrite(PIN_BUZZER, LOW); // need to pull low by default to avoid extreme power draw
-    startup();
 }
 
 void genericBuzzer::play(const char *melody) {

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,6 @@ void genericBuzzer::begin() {`
`12`	`12`	`quiet(false);`
`13`	`13`	`pinMode(PIN_BUZZER, OUTPUT);`
`14`	`14`	`digitalWrite(PIN_BUZZER, LOW); // need to pull low by default to avoid extreme power draw`
`15`		`- startup();`
`16`	`15`	`}`
`17`	`16`
`18`	`17`	`void genericBuzzer::play(const char *melody) {`